Re: [PATCH v37 05/17] target/avr: Add instruction translation - Arithmetic and Logic Instructions
On Monday, December 2, 2019, Aleksandar Markovic <
aleksandar.m.m...@gmail.com> wrote:
>
>
> +
> +/* update status register */
> +tcg_gen_movi_tl(cpu_Vf, 0); /* Vf = 0 */
> +tcg_gen_setcondi_tl(TCG_COND_EQ, cpu_Zf, R, 0); /* Zf = R == 0 */
> +gen_ZNSf(R);
> +tcg_gen_mov_tl(Rd, R);
> +
>
My email client drives me crazy, all lines from the above segment should be
consecutive, without any empty lines in between. If you see empty lines,
that is because of my email client.
> The idea is to distinguish visually better the portions for updating
> status register from the central part of the operation (usually marked by
> "/* op */" comment. The code also gets more compact, which looks like a
> good thing too.
>
> Aleksandar
>
>
>> Regards,
>> Michael Rolnik
>>
>> On Sun, Dec 1, 2019 at 1:11 AM Aleksandar Markovic <
>> aleksandar.m.m...@gmail.com> wrote:
>>
>>>
>>>
>>> On Saturday, November 30, 2019, Michael Rolnik
>>> wrote:
>>>
Hi Aleksandar.
thanks for pointing that out I was not aware of that.
I can fix it.
>>> Hey, Michael,
>>>
>>> Please take alook at this:
>>>
>>> https://en.m.wikipedia.org/wiki/ATtiny_microcontroller_comparison_chart
>>>
>>> It looks that all cases of AVR 16-gpr-registers cores belong to the
>>> group "avrtiny10", that actually you may want to add to your solution.
>>> Just a hint.
>>>
>>> Best regards,
>>> Aleksandar
>>>
>>>
>>>
>>> Regards,
Michael Rolnik
On Sat, Nov 30, 2019 at 6:29 PM Aleksandar Markovic <
aleksandar.m.m...@gmail.com> wrote:
>
>
> On Saturday, November 30, 2019, Aleksandar Markovic <
> aleksandar.m.m...@gmail.com> wrote:
>
>>
>>
>> On Wednesday, November 27, 2019, Michael Rolnik
>> wrote:
>>
>> +
>>> +
>>> +/*
>>> + * Performs the logical AND between the contents of register Rd
>>> and register
>>> + * Rr and places the result in the destination register Rd.
>>> + */
>>> +static bool trans_AND(DisasContext *ctx, arg_AND *a)
>>> +{
>>> +TCGv Rd = cpu_r[a->rd];
>>> +TCGv Rr = cpu_r[a->rr];
>>> +TCGv R = tcg_temp_new_i32();
>>> +
>>> +/* op */
>>> +tcg_gen_and_tl(R, Rd, Rr); /* Rd = Rd and Rr */
>>> +
>>> +/* Vf */
>>> +tcg_gen_movi_tl(cpu_Vf, 0); /* Vf = 0 */
>>> +
>>> +/* Zf */
>>> +tcg_gen_setcondi_tl(TCG_COND_EQ, cpu_Zf, R, 0); /* Zf = R == 0
>>> */
>>> +
>>> +gen_ZNSf(R);
>>> +
>>> +/* R */
>>> +tcg_gen_mov_tl(Rd, R);
>>> +
>>> +tcg_temp_free_i32(R);
>>> +
>>> +return true;
>>> +}
>>> +
>>> +
>>>
>>
>> According to specs:
>>
>> http://ww1.microchip.com/downloads/en/devicedoc/atmel-42505-
>> 8-bit-avr-microcontrollers-attiny102-attiny104_datasheet.pdf
>>
>> ... the chips in question have cores with 16 GPRs (that correspond to
>> GPRs R16-R31 of more common AVR cores with 32 GPRs).
>>
>>
> There are more examples;
>
> http://ww1.microchip.com/downloads/en/DeviceDoc/atmel-8127-
> avr-8-bit-microcontroller-attiny4-attiny5-attiny9-
> attiny10_datasheet.pdf
>
> Also ATtiny20, ATtiny40.
>
> How do you handle such cores?
>>
>> I don't see here anything preventing usage of all 32 GPRs, resulting,
>> of course, in an inaccurate emulation.
>>
>> Thanks,
>> Aleksandar
>>
>
--
Best Regards,
Michael Rolnik
>>>
>>
>> --
>> Best Regards,
>> Michael Rolnik
>>
>
Re: [PATCH v37 05/17] target/avr: Add instruction translation - Arithmetic and Logic Instructions
On Monday, December 2, 2019, Michael Rolnik wrote:
> Aleksandar.
>
> I could not find what happens if an instruction with unsupported registers
> is executed. So, I am leaving this tiny core for later.
>
>
No problem with me. You already have instruction support for a rich variety
of cores. These can certainly added it in future.
May I suggest, then, a following cosmetic change: In order for a reader to
get a brtter "first glance" feeling for emulations of ALL instructions that
involve updating status register, I suggest that the code blocks like this
one:
+
+/* Vf */
+tcg_gen_movi_tl(cpu_Vf, 0); /* Vf = 0 */
+
+/* Zf */
+tcg_gen_setcondi_tl(TCG_COND_EQ, cpu_Zf, R, 0); /* Zf = R == 0 */
+
+gen_ZNSf(R);
+
+/* R */
+tcg_gen_mov_tl(Rd, R);
+
be replaced with this one:
+
+/* update status register */
+tcg_gen_movi_tl(cpu_Vf, 0); /* Vf = 0 */
+tcg_gen_setcondi_tl(TCG_COND_EQ, cpu_Zf, R, 0); /* Zf = R == 0 */
+gen_ZNSf(R);
+tcg_gen_mov_tl(Rd, R);
+
The idea is to distinguish visually better the portions for updating status
register from the central part of the operation (usually marked by "/* op
*/" comment. The code also gets more compact, which looks like a good thing
too.
Aleksandar
> Regards,
> Michael Rolnik
>
> On Sun, Dec 1, 2019 at 1:11 AM Aleksandar Markovic <
> aleksandar.m.m...@gmail.com> wrote:
>
>>
>>
>> On Saturday, November 30, 2019, Michael Rolnik wrote:
>>
>>> Hi Aleksandar.
>>>
>>> thanks for pointing that out I was not aware of that.
>>> I can fix it.
>>>
>>>
>> Hey, Michael,
>>
>> Please take alook at this:
>>
>> https://en.m.wikipedia.org/wiki/ATtiny_microcontroller_comparison_chart
>>
>> It looks that all cases of AVR 16-gpr-registers cores belong to the group
>> "avrtiny10", that actually you may want to add to your solution. Just a
>> hint.
>>
>> Best regards,
>> Aleksandar
>>
>>
>>
>> Regards,
>>> Michael Rolnik
>>>
>>> On Sat, Nov 30, 2019 at 6:29 PM Aleksandar Markovic <
>>> aleksandar.m.m...@gmail.com> wrote:
>>>
On Saturday, November 30, 2019, Aleksandar Markovic <
aleksandar.m.m...@gmail.com> wrote:
>
>
> On Wednesday, November 27, 2019, Michael Rolnik
> wrote:
>
> +
>> +
>> +/*
>> + * Performs the logical AND between the contents of register Rd and
>> register
>> + * Rr and places the result in the destination register Rd.
>> + */
>> +static bool trans_AND(DisasContext *ctx, arg_AND *a)
>> +{
>> +TCGv Rd = cpu_r[a->rd];
>> +TCGv Rr = cpu_r[a->rr];
>> +TCGv R = tcg_temp_new_i32();
>> +
>> +/* op */
>> +tcg_gen_and_tl(R, Rd, Rr); /* Rd = Rd and Rr */
>> +
>> +/* Vf */
>> +tcg_gen_movi_tl(cpu_Vf, 0); /* Vf = 0 */
>> +
>> +/* Zf */
>> +tcg_gen_setcondi_tl(TCG_COND_EQ, cpu_Zf, R, 0); /* Zf = R == 0
>> */
>> +
>> +gen_ZNSf(R);
>> +
>> +/* R */
>> +tcg_gen_mov_tl(Rd, R);
>> +
>> +tcg_temp_free_i32(R);
>> +
>> +return true;
>> +}
>> +
>> +
>>
>
> According to specs:
>
> http://ww1.microchip.com/downloads/en/devicedoc/atmel-42505-8-bit-avr-
> microcontrollers-attiny102-attiny104_datasheet.pdf
>
> ... the chips in question have cores with 16 GPRs (that correspond to
> GPRs R16-R31 of more common AVR cores with 32 GPRs).
>
>
There are more examples;
http://ww1.microchip.com/downloads/en/DeviceDoc/atmel-8127-avr-8-bit-
microcontroller-attiny4-attiny5-attiny9-attiny10_datasheet.pdf
Also ATtiny20, ATtiny40.
How do you handle such cores?
>
> I don't see here anything preventing usage of all 32 GPRs, resulting,
> of course, in an inaccurate emulation.
>
> Thanks,
> Aleksandar
>
>>>
>>> --
>>> Best Regards,
>>> Michael Rolnik
>>>
>>
>
> --
> Best Regards,
> Michael Rolnik
>
Re: [PATCH v37 05/17] target/avr: Add instruction translation - Arithmetic and Logic Instructions
Aleksandar.
I could not find what happens if an instruction with unsupported registers
is executed. So, I am leaving this tiny core for later.
Regards,
Michael Rolnik
On Sun, Dec 1, 2019 at 1:11 AM Aleksandar Markovic <
aleksandar.m.m...@gmail.com> wrote:
>
>
> On Saturday, November 30, 2019, Michael Rolnik wrote:
>
>> Hi Aleksandar.
>>
>> thanks for pointing that out I was not aware of that.
>> I can fix it.
>>
>>
> Hey, Michael,
>
> Please take alook at this:
>
> https://en.m.wikipedia.org/wiki/ATtiny_microcontroller_comparison_chart
>
> It looks that all cases of AVR 16-gpr-registers cores belong to the group
> "avrtiny10",
> that actually you may want to add to your solution. Just a hint.
>
> Best regards,
> Aleksandar
>
>
>
> Regards,
>> Michael Rolnik
>>
>> On Sat, Nov 30, 2019 at 6:29 PM Aleksandar Markovic <
>> aleksandar.m.m...@gmail.com> wrote:
>>
>>>
>>>
>>> On Saturday, November 30, 2019, Aleksandar Markovic <
>>> aleksandar.m.m...@gmail.com> wrote:
>>>
On Wednesday, November 27, 2019, Michael Rolnik
wrote:
+
> +
> +/*
> + * Performs the logical AND between the contents of register Rd and
> register
> + * Rr and places the result in the destination register Rd.
> + */
> +static bool trans_AND(DisasContext *ctx, arg_AND *a)
> +{
> +TCGv Rd = cpu_r[a->rd];
> +TCGv Rr = cpu_r[a->rr];
> +TCGv R = tcg_temp_new_i32();
> +
> +/* op */
> +tcg_gen_and_tl(R, Rd, Rr); /* Rd = Rd and Rr */
> +
> +/* Vf */
> +tcg_gen_movi_tl(cpu_Vf, 0); /* Vf = 0 */
> +
> +/* Zf */
> +tcg_gen_setcondi_tl(TCG_COND_EQ, cpu_Zf, R, 0); /* Zf = R == 0 */
> +
> +gen_ZNSf(R);
> +
> +/* R */
> +tcg_gen_mov_tl(Rd, R);
> +
> +tcg_temp_free_i32(R);
> +
> +return true;
> +}
> +
> +
>
According to specs:
http://ww1.microchip.com/downloads/en/devicedoc/atmel-42505-8-bit-avr-microcontrollers-attiny102-attiny104_datasheet.pdf
... the chips in question have cores with 16 GPRs (that correspond to
GPRs R16-R31 of more common AVR cores with 32 GPRs).
>>> There are more examples;
>>>
>>>
>>> http://ww1.microchip.com/downloads/en/DeviceDoc/atmel-8127-avr-8-bit-microcontroller-attiny4-attiny5-attiny9-attiny10_datasheet.pdf
>>>
>>> Also ATtiny20, ATtiny40.
>>>
>>> How do you handle such cores?
I don't see here anything preventing usage of all 32 GPRs, resulting,
of course, in an inaccurate emulation.
Thanks,
Aleksandar
>>>
>>
>> --
>> Best Regards,
>> Michael Rolnik
>>
>
--
Best Regards,
Michael Rolnik
Re: [PATCH v37 05/17] target/avr: Add instruction translation - Arithmetic and Logic Instructions
On Saturday, November 30, 2019, Michael Rolnik wrote:
> Hi Aleksandar.
>
> thanks for pointing that out I was not aware of that.
> I can fix it.
>
>
Hey, Michael,
Please take alook at this:
https://en.m.wikipedia.org/wiki/ATtiny_microcontroller_comparison_chart
It looks that all cases of AVR 16-gpr-registers cores belong to the
group "avrtiny10",
that actually you may want to add to your solution. Just a hint.
Best regards,
Aleksandar
Regards,
> Michael Rolnik
>
> On Sat, Nov 30, 2019 at 6:29 PM Aleksandar Markovic <
> aleksandar.m.m...@gmail.com> wrote:
>
>>
>>
>> On Saturday, November 30, 2019, Aleksandar Markovic <
>> aleksandar.m.m...@gmail.com> wrote:
>>
>>>
>>>
>>> On Wednesday, November 27, 2019, Michael Rolnik
>>> wrote:
>>>
>>> +
+
+/*
+ * Performs the logical AND between the contents of register Rd and
register
+ * Rr and places the result in the destination register Rd.
+ */
+static bool trans_AND(DisasContext *ctx, arg_AND *a)
+{
+TCGv Rd = cpu_r[a->rd];
+TCGv Rr = cpu_r[a->rr];
+TCGv R = tcg_temp_new_i32();
+
+/* op */
+tcg_gen_and_tl(R, Rd, Rr); /* Rd = Rd and Rr */
+
+/* Vf */
+tcg_gen_movi_tl(cpu_Vf, 0); /* Vf = 0 */
+
+/* Zf */
+tcg_gen_setcondi_tl(TCG_COND_EQ, cpu_Zf, R, 0); /* Zf = R == 0 */
+
+gen_ZNSf(R);
+
+/* R */
+tcg_gen_mov_tl(Rd, R);
+
+tcg_temp_free_i32(R);
+
+return true;
+}
+
+
>>>
>>> According to specs:
>>>
>>> http://ww1.microchip.com/downloads/en/devicedoc/atmel-42505-8-bit-avr-
>>> microcontrollers-attiny102-attiny104_datasheet.pdf
>>>
>>> ... the chips in question have cores with 16 GPRs (that correspond to
>>> GPRs R16-R31 of more common AVR cores with 32 GPRs).
>>>
>>>
>> There are more examples;
>>
>> http://ww1.microchip.com/downloads/en/DeviceDoc/atmel-8127-avr-8-bit-
>> microcontroller-attiny4-attiny5-attiny9-attiny10_datasheet.pdf
>>
>> Also ATtiny20, ATtiny40.
>>
>> How do you handle such cores?
>>>
>>> I don't see here anything preventing usage of all 32 GPRs, resulting, of
>>> course, in an inaccurate emulation.
>>>
>>> Thanks,
>>> Aleksandar
>>>
>>
>
> --
> Best Regards,
> Michael Rolnik
>
Re: [PATCH v37 05/17] target/avr: Add instruction translation - Arithmetic and Logic Instructions
Hi Aleksandar.
thanks for pointing that out I was not aware of that.
I can fix it.
Regards,
Michael Rolnik
On Sat, Nov 30, 2019 at 6:29 PM Aleksandar Markovic <
aleksandar.m.m...@gmail.com> wrote:
>
>
> On Saturday, November 30, 2019, Aleksandar Markovic <
> aleksandar.m.m...@gmail.com> wrote:
>
>>
>>
>> On Wednesday, November 27, 2019, Michael Rolnik
>> wrote:
>>
>> +
>>> +
>>> +/*
>>> + * Performs the logical AND between the contents of register Rd and
>>> register
>>> + * Rr and places the result in the destination register Rd.
>>> + */
>>> +static bool trans_AND(DisasContext *ctx, arg_AND *a)
>>> +{
>>> +TCGv Rd = cpu_r[a->rd];
>>> +TCGv Rr = cpu_r[a->rr];
>>> +TCGv R = tcg_temp_new_i32();
>>> +
>>> +/* op */
>>> +tcg_gen_and_tl(R, Rd, Rr); /* Rd = Rd and Rr */
>>> +
>>> +/* Vf */
>>> +tcg_gen_movi_tl(cpu_Vf, 0); /* Vf = 0 */
>>> +
>>> +/* Zf */
>>> +tcg_gen_setcondi_tl(TCG_COND_EQ, cpu_Zf, R, 0); /* Zf = R == 0 */
>>> +
>>> +gen_ZNSf(R);
>>> +
>>> +/* R */
>>> +tcg_gen_mov_tl(Rd, R);
>>> +
>>> +tcg_temp_free_i32(R);
>>> +
>>> +return true;
>>> +}
>>> +
>>> +
>>>
>>
>> According to specs:
>>
>>
>> http://ww1.microchip.com/downloads/en/devicedoc/atmel-42505-8-bit-avr-microcontrollers-attiny102-attiny104_datasheet.pdf
>>
>> ... the chips in question have cores with 16 GPRs (that correspond to
>> GPRs R16-R31 of more common AVR cores with 32 GPRs).
>>
>>
> There are more examples;
>
>
> http://ww1.microchip.com/downloads/en/DeviceDoc/atmel-8127-avr-8-bit-microcontroller-attiny4-attiny5-attiny9-attiny10_datasheet.pdf
>
> Also ATtiny20, ATtiny40.
>
> How do you handle such cores?
>>
>> I don't see here anything preventing usage of all 32 GPRs, resulting, of
>> course, in an inaccurate emulation.
>>
>> Thanks,
>> Aleksandar
>>
>
--
Best Regards,
Michael Rolnik
Re: [PATCH v37 05/17] target/avr: Add instruction translation - Arithmetic and Logic Instructions
On Saturday, November 30, 2019, Michael Rolnik wrote:
> Hi Aleksandar.
>
> thanks for pointing that out I was not aware of that.
> I can fix it.
>
That'd be great!
Thanks,
Aleksandar
>
> Regards,
> Michael Rolnik
>
> On Sat, Nov 30, 2019 at 6:29 PM Aleksandar Markovic <
> aleksandar.m.m...@gmail.com> wrote:
>
>>
>>
>> On Saturday, November 30, 2019, Aleksandar Markovic <
>> aleksandar.m.m...@gmail.com> wrote:
>>
>>>
>>>
>>> On Wednesday, November 27, 2019, Michael Rolnik
>>> wrote:
>>>
>>> +
+
+/*
+ * Performs the logical AND between the contents of register Rd and
register
+ * Rr and places the result in the destination register Rd.
+ */
+static bool trans_AND(DisasContext *ctx, arg_AND *a)
+{
+TCGv Rd = cpu_r[a->rd];
+TCGv Rr = cpu_r[a->rr];
+TCGv R = tcg_temp_new_i32();
+
+/* op */
+tcg_gen_and_tl(R, Rd, Rr); /* Rd = Rd and Rr */
+
+/* Vf */
+tcg_gen_movi_tl(cpu_Vf, 0); /* Vf = 0 */
+
+/* Zf */
+tcg_gen_setcondi_tl(TCG_COND_EQ, cpu_Zf, R, 0); /* Zf = R == 0 */
+
+gen_ZNSf(R);
+
+/* R */
+tcg_gen_mov_tl(Rd, R);
+
+tcg_temp_free_i32(R);
+
+return true;
+}
+
+
>>>
>>> According to specs:
>>>
>>> http://ww1.microchip.com/downloads/en/devicedoc/atmel-42505-8-bit-avr-
>>> microcontrollers-attiny102-attiny104_datasheet.pdf
>>>
>>> ... the chips in question have cores with 16 GPRs (that correspond to
>>> GPRs R16-R31 of more common AVR cores with 32 GPRs).
>>>
>>>
>> There are more examples;
>>
>> http://ww1.microchip.com/downloads/en/DeviceDoc/atmel-8127-avr-8-bit-
>> microcontroller-attiny4-attiny5-attiny9-attiny10_datasheet.pdf
>>
>> Also ATtiny20, ATtiny40.
>>
>> How do you handle such cores?
>>>
>>> I don't see here anything preventing usage of all 32 GPRs, resulting, of
>>> course, in an inaccurate emulation.
>>>
>>> Thanks,
>>> Aleksandar
>>>
>>
>
> --
> Best Regards,
> Michael Rolnik
>
Re: [PATCH v37 05/17] target/avr: Add instruction translation - Arithmetic and Logic Instructions
On Saturday, November 30, 2019, Aleksandar Markovic <
aleksandar.m.m...@gmail.com> wrote:
>
>
> On Wednesday, November 27, 2019, Michael Rolnik wrote:
>
> +
>> +
>> +/*
>> + * Performs the logical AND between the contents of register Rd and
>> register
>> + * Rr and places the result in the destination register Rd.
>> + */
>> +static bool trans_AND(DisasContext *ctx, arg_AND *a)
>> +{
>> +TCGv Rd = cpu_r[a->rd];
>> +TCGv Rr = cpu_r[a->rr];
>> +TCGv R = tcg_temp_new_i32();
>> +
>> +/* op */
>> +tcg_gen_and_tl(R, Rd, Rr); /* Rd = Rd and Rr */
>> +
>> +/* Vf */
>> +tcg_gen_movi_tl(cpu_Vf, 0); /* Vf = 0 */
>> +
>> +/* Zf */
>> +tcg_gen_setcondi_tl(TCG_COND_EQ, cpu_Zf, R, 0); /* Zf = R == 0 */
>> +
>> +gen_ZNSf(R);
>> +
>> +/* R */
>> +tcg_gen_mov_tl(Rd, R);
>> +
>> +tcg_temp_free_i32(R);
>> +
>> +return true;
>> +}
>> +
>> +
>>
>
> According to specs:
>
> http://ww1.microchip.com/downloads/en/devicedoc/atmel-42505-8-bit-avr-
> microcontrollers-attiny102-attiny104_datasheet.pdf
>
> ... the chips in question have cores with 16 GPRs (that correspond to GPRs
> R16-R31 of more common AVR cores with 32 GPRs).
>
>
There are more examples;
http://ww1.microchip.com/downloads/en/DeviceDoc/atmel-8127-avr-8-bit-microcontroller-attiny4-attiny5-attiny9-attiny10_datasheet.pdf
Also ATtiny20, ATtiny40.
How do you handle such cores?
>
> I don't see here anything preventing usage of all 32 GPRs, resulting, of
> course, in an inaccurate emulation.
>
> Thanks,
> Aleksandar
>
Re: [PATCH v37 05/17] target/avr: Add instruction translation - Arithmetic and Logic Instructions
On Wednesday, November 27, 2019, Michael Rolnik wrote:
+
> +
> +/*
> + * Performs the logical AND between the contents of register Rd and
> register
> + * Rr and places the result in the destination register Rd.
> + */
> +static bool trans_AND(DisasContext *ctx, arg_AND *a)
> +{
> +TCGv Rd = cpu_r[a->rd];
> +TCGv Rr = cpu_r[a->rr];
> +TCGv R = tcg_temp_new_i32();
> +
> +/* op */
> +tcg_gen_and_tl(R, Rd, Rr); /* Rd = Rd and Rr */
> +
> +/* Vf */
> +tcg_gen_movi_tl(cpu_Vf, 0); /* Vf = 0 */
> +
> +/* Zf */
> +tcg_gen_setcondi_tl(TCG_COND_EQ, cpu_Zf, R, 0); /* Zf = R == 0 */
> +
> +gen_ZNSf(R);
> +
> +/* R */
> +tcg_gen_mov_tl(Rd, R);
> +
> +tcg_temp_free_i32(R);
> +
> +return true;
> +}
> +
> +
>
According to specs:
http://ww1.microchip.com/downloads/en/devicedoc/atmel-42505-8-bit-avr-microcontrollers-attiny102-attiny104_datasheet.pdf
... the chips in question have cores with 16 GPRs (that correspond to GPRs
R16-R31 of more common AVR cores with 32 GPRs).
How do you handle such cores?
I don't see here anything preventing usage of all 32 GPRs, resulting, of
course, in an inaccurate emulation.
Thanks,
Aleksandar
