Re: [PATCH v4 0/6] python: add QAPI and qapidoc et al to python tests

2025-05-19 Thread John Snow
On Thu, May 15, 2025 at 4:38 AM Markus Armbruster  wrote:

> John Snow  writes:
>
> > Hiya, this series turns on automated linting for scripts/qapi,
> > docs/sphinx/qapidoc.py and docs/sphinx/qapi_domain.py.
> >
> > This includes flake8/isort/pylint/mypy for scripts/qapi, but omits mypy
> > from the Sphinx plugins owing to my inability to strictly type the
> > extensions given the wide versions of Sphinx we actually support.
> >
> > [Maybe this will change soon, but it's not true just yet.]
> >
> > Though I have been using black in my own development, I have not yet
> > enabled it anywhere automatically. Maybe soon.
>
> You lost my series
> Reviewed-by: Markus Armbruster 
>
> :)


My patches tool broke and I was doing things manually for a bit! I've got
it squared away thanks to Stefan Hajnoczi, and sent a PR out with the
proper message IDs and SOBs.

Thanks!


Re: [PATCH v4 0/6] python: add QAPI and qapidoc et al to python tests

2025-05-15 Thread Markus Armbruster
John Snow  writes:

> Hiya, this series turns on automated linting for scripts/qapi,
> docs/sphinx/qapidoc.py and docs/sphinx/qapi_domain.py.
>
> This includes flake8/isort/pylint/mypy for scripts/qapi, but omits mypy
> from the Sphinx plugins owing to my inability to strictly type the
> extensions given the wide versions of Sphinx we actually support.
>
> [Maybe this will change soon, but it's not true just yet.]
>
> Though I have been using black in my own development, I have not yet
> enabled it anywhere automatically. Maybe soon.

You lost my series
Reviewed-by: Markus Armbruster 

:)