Re: [PATCH v4 00/15] qapi: remove all TARGET_* conditionals from the schema

2025-05-27 Thread Markus Armbruster 
Pierrick Bouvier  writes:

> On 5/27/25 6:00 AM, Markus Armbruster wrote:
>> Pierrick Bouvier  writes:
>> 
>>> This series exposes all qmp commands for any target unconditionally, 
>>> allowing to
>>> compile QAPI generated code without any TARGET conditionals.
>>>
>>> Based on original RFC from Daniel P. Berrangé:
>>> https://lore.kernel.org/qemu-devel/[email protected]/
>> I picked a few nits.  I'm happy to address them in my tree without a
>> respin.  If you object to any, please let me know.
>> 
>
> I'm ok if you want to take that in your tree, and address them directly.
> All the comments change requested are ok for me.
> I'll answer on individual commits for your questions.
>
> If you expect a respin on my side, let me know (from what I understand, it's 
> not expected at this point).

Correct.  Thanks!

[...]

Re: [PATCH v4 00/15] qapi: remove all TARGET_* conditionals from the schema

2025-05-27 Thread Markus Armbruster 
Pierrick Bouvier  writes:

> This series exposes all qmp commands for any target unconditionally, allowing 
> to
> compile QAPI generated code without any TARGET conditionals.
>
> Based on original RFC from Daniel P. Berrangé:
> https://lore.kernel.org/qemu-devel/[email protected]/

I picked a few nits.  I'm happy to address them in my tree without a
respin.  If you object to any, please let me know.

Series:
Reviewed-by: Markus Armbruster

Re: [PATCH v4 00/15] qapi: remove all TARGET_* conditionals from the schema

2025-05-27 Thread Pierrick Bouvier 

On 5/27/25 6:00 AM, Markus Armbruster wrote:

Pierrick Bouvier  writes:


This series exposes all qmp commands for any target unconditionally, allowing to
compile QAPI generated code without any TARGET conditionals.

Based on original RFC from Daniel P. Berrangé:
https://lore.kernel.org/qemu-devel/[email protected]/


I picked a few nits.  I'm happy to address them in my tree without a
respin.  If you object to any, please let me know.



I'm ok if you want to take that in your tree, and address them directly.
All the comments change requested are ok for me.
I'll answer on individual commits for your questions.

If you expect a respin on my side, let me know (from what I understand, 
it's not expected at this point).


Thanks,
Pierrick


Series:
Reviewed-by: Markus Armbruster