Re: [PATCH v4 06/15] pc-bios/s390-ccw: Split virtio-ccw and generic virtio

2026-03-05 Thread Eric Farman
On Tue, 2026-03-03 at 21:59 -0500, [email protected] wrote:
> From: Jared Rossi 
> 
> Separate the CCW specific virtio routines and create generic wrappers for 
> easier
> reuse of existing virtio functions with non-CCW devices.
> 
> Signed-off-by: Jared Rossi 
> ---
>  pc-bios/s390-ccw/Makefile|   3 +-
>  pc-bios/s390-ccw/main.c  |   8 +-
>  pc-bios/s390-ccw/netmain.c   |   2 +-
>  pc-bios/s390-ccw/s390-ccw.h  |   3 -
>  pc-bios/s390-ccw/virtio-blkdev.c |  15 +-
>  pc-bios/s390-ccw/virtio-ccw.c| 241 +++
>  pc-bios/s390-ccw/virtio-ccw.h|  24 +++
>  pc-bios/s390-ccw/virtio-net.c|   3 +-
>  pc-bios/s390-ccw/virtio-scsi.c   |   8 +-
>  pc-bios/s390-ccw/virtio-scsi.h   |   2 +-
>  pc-bios/s390-ccw/virtio.c| 239 +-
>  pc-bios/s390-ccw/virtio.h|   5 +-
>  12 files changed, 332 insertions(+), 221 deletions(-)
>  create mode 100644 pc-bios/s390-ccw/virtio-ccw.c
>  create mode 100644 pc-bios/s390-ccw/virtio-ccw.h

This is some good untangling!

Reviewed-by: Eric Farman 



Re: [PATCH v4 06/15] pc-bios/s390-ccw: Split virtio-ccw and generic virtio

2026-03-04 Thread Thomas Huth

On 04/03/2026 03.59, [email protected] wrote:

From: Jared Rossi 

Separate the CCW specific virtio routines and create generic wrappers for easier
reuse of existing virtio functions with non-CCW devices.

Signed-off-by: Jared Rossi 
---
  pc-bios/s390-ccw/Makefile|   3 +-
  pc-bios/s390-ccw/main.c  |   8 +-
  pc-bios/s390-ccw/netmain.c   |   2 +-
  pc-bios/s390-ccw/s390-ccw.h  |   3 -
  pc-bios/s390-ccw/virtio-blkdev.c |  15 +-
  pc-bios/s390-ccw/virtio-ccw.c| 241 +++
  pc-bios/s390-ccw/virtio-ccw.h|  24 +++
  pc-bios/s390-ccw/virtio-net.c|   3 +-
  pc-bios/s390-ccw/virtio-scsi.c   |   8 +-
  pc-bios/s390-ccw/virtio-scsi.h   |   2 +-
  pc-bios/s390-ccw/virtio.c| 239 +-
  pc-bios/s390-ccw/virtio.h|   5 +-
  12 files changed, 332 insertions(+), 221 deletions(-)
  create mode 100644 pc-bios/s390-ccw/virtio-ccw.c
  create mode 100644 pc-bios/s390-ccw/virtio-ccw.h


Reviewed-by: Thomas Huth