Re: [PATCH v4 09/15] qapi: make most CPU commands unconditionally available

2025-05-27 Thread Markus Armbruster
Pierrick Bouvier  writes:

> On 5/27/25 4:38 AM, Markus Armbruster wrote:
>> You took authorship from Daniel.  Intentional?
>> Pierrick Bouvier  writes:
>> 
>>> This removes the TARGET_* conditions from all the CPU commands
>>> that are conceptually target independent. Top level stubs are
>>> provided to cope with targets which do not currently implement
>>> all of the commands. Adjust the doc comments accordingly.
>>>
>>> Reviewed-by: Richard Henderson 
>>> Signed-off-by: Daniel P. Berrangé 
>>> Signed-off-by: Pierrick Bouvier 
>> 
>
> Not intentional. As said in v3, I did a mistake and squashed this commit, so 
> I re-extracted it during an interactive rebase, "stealing" the authorship 
> along the way. You're welcome to change that back under Daniel's name.

Will do, thanks!




Re: [PATCH v4 09/15] qapi: make most CPU commands unconditionally available

2025-05-27 Thread Pierrick Bouvier

On 5/27/25 4:38 AM, Markus Armbruster wrote:

You took authorship from Daniel.  Intentional?

Pierrick Bouvier  writes:


This removes the TARGET_* conditions from all the CPU commands
that are conceptually target independent. Top level stubs are
provided to cope with targets which do not currently implement
all of the commands. Adjust the doc comments accordingly.

Reviewed-by: Richard Henderson 
Signed-off-by: Daniel P. Berrangé 
Signed-off-by: Pierrick Bouvier 




Not intentional. As said in v3, I did a mistake and squashed this 
commit, so I re-extracted it during an interactive rebase, "stealing" 
the authorship along the way. You're welcome to change that back under 
Daniel's name.


Thanks,
Pierrick



Re: [PATCH v4 09/15] qapi: make most CPU commands unconditionally available

2025-05-27 Thread Markus Armbruster
You took authorship from Daniel.  Intentional?

Pierrick Bouvier  writes:

> This removes the TARGET_* conditions from all the CPU commands
> that are conceptually target independent. Top level stubs are
> provided to cope with targets which do not currently implement
> all of the commands. Adjust the doc comments accordingly.
>
> Reviewed-by: Richard Henderson 
> Signed-off-by: Daniel P. Berrangé 
> Signed-off-by: Pierrick Bouvier