Re: [PATCH v4 130/163] target/sh4: Use tcg_gen_addcio_i32 for addc

2025-04-22 Thread Philippe Mathieu-Daudé 

On 15/4/25 21:24, Richard Henderson wrote:

Signed-off-by: Richard Henderson 
---
  target/sh4/translate.c | 10 ++
  1 file changed, 2 insertions(+), 8 deletions(-)


Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v4 130/163] target/sh4: Use tcg_gen_addcio_i32 for addc

2025-04-16 Thread Pierrick Bouvier 

On 4/15/25 12:24, Richard Henderson wrote:

Signed-off-by: Richard Henderson 
---
  target/sh4/translate.c | 10 ++
  1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/target/sh4/translate.c b/target/sh4/translate.c
index 2ef48b1d17..e8029c0c7a 100644
--- a/target/sh4/translate.c
+++ b/target/sh4/translate.c
@@ -694,14 +694,8 @@ static void _decode_opc(DisasContext * ctx)
  tcg_gen_add_i32(REG(B11_8), REG(B11_8), REG(B7_4));
  return;
  case 0x300e: /* addc Rm,Rn */
-{
-TCGv t0, t1;
-t0 = tcg_constant_tl(0);
-t1 = tcg_temp_new();
-tcg_gen_add2_i32(t1, cpu_sr_t, cpu_sr_t, t0, REG(B7_4), t0);
-tcg_gen_add2_i32(REG(B11_8), cpu_sr_t,
- REG(B11_8), t0, t1, cpu_sr_t);
-}
+tcg_gen_addcio_i32(REG(B11_8), cpu_sr_t,
+   REG(B11_8), REG(B7_4), cpu_sr_t);
  return;
  case 0x300f: /* addv Rm,Rn */
  {


Reviewed-by: Pierrick Bouvier