Re: [PATCH v5 00/12] pc-bios: s390x: Cleanup part 1

2020-06-30 Thread Thomas Huth
On 24/06/2020 12.57, Janosch Frank wrote: On 6/24/20 12:46 PM, Thomas Huth wrote: On 24/06/2020 12.44, Cornelia Huck wrote: On Wed, 24 Jun 2020 03:52:14 -0400 Janosch Frank wrote: The bios is in dire need for a cleanup as there are still a lot of magic constants being used throughout as well

Re: [PATCH v5 00/12] pc-bios: s390x: Cleanup part 1

2020-06-24 Thread Cornelia Huck
On Wed, 24 Jun 2020 12:46:49 +0200 Thomas Huth wrote: > On 24/06/2020 12.44, Cornelia Huck wrote: > > On Wed, 24 Jun 2020 03:52:14 -0400 > > Janosch Frank wrote: > > > >> The bios is in dire need for a cleanup as there are still a lot of > >> magic constants being used throughout as well as d

Re: [PATCH v5 00/12] pc-bios: s390x: Cleanup part 1

2020-06-24 Thread Janosch Frank
On 6/24/20 12:46 PM, Thomas Huth wrote: > On 24/06/2020 12.44, Cornelia Huck wrote: >> On Wed, 24 Jun 2020 03:52:14 -0400 >> Janosch Frank wrote: >> >>> The bios is in dire need for a cleanup as there are still a lot of >>> magic constants being used throughout as well as duplicated code. >>> >>>

Re: [PATCH v5 00/12] pc-bios: s390x: Cleanup part 1

2020-06-24 Thread Thomas Huth
On 24/06/2020 12.44, Cornelia Huck wrote: On Wed, 24 Jun 2020 03:52:14 -0400 Janosch Frank wrote: The bios is in dire need for a cleanup as there are still a lot of magic constants being used throughout as well as duplicated code. In the first part of this series we consolidate constants and

Re: [PATCH v5 00/12] pc-bios: s390x: Cleanup part 1

2020-06-24 Thread Cornelia Huck
On Wed, 24 Jun 2020 03:52:14 -0400 Janosch Frank wrote: > The bios is in dire need for a cleanup as there are still a lot of > magic constants being used throughout as well as duplicated code. > > In the first part of this series we consolidate constants and > functions, as well as doing some mi

Re: [PATCH v5 00/12] pc-bios: s390x: Cleanup part 1

2020-06-24 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200624075226.92728-1-fran...@linux.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v5 00/12] pc-bios: s390x: Cleanup part 1 Type: series Message-id: 20200624075226.92728-1-fran...