Re: [PATCH v5 17/22] tests/guest-debug: add a simple test runner

2020-01-15 Thread Richard Henderson
On 1/14/20 5:09 AM, Alex Bennée wrote: > +if "system" in args.qemu: > +cmd = "%s %s %s -s -S" % (args.qemu, args.qargs, args.binary) > +else: > +cmd = "%s %s -g 1234 %s" % (args.qemu, args.qargs, args.binary) Oh, hard-coding of the port is going to cause failures.

Re: [PATCH v5 17/22] tests/guest-debug: add a simple test runner

2020-01-15 Thread Richard Henderson
On 1/14/20 5:09 AM, Alex Bennée wrote: > +gdb_cmd = "%s %s -ex 'target remote localhost:1234' -x %s" % (args.gdb, > args.binary, args.test) It'd be nice to wrap this line. Otherwise, Reviewed-by: Richard Henderson r~