Re: [PATCH v7 0/3] Add support for TPM devices over I2C bus

2023-03-27 Thread Stefan Berger
On 3/27/23 08:31, Stefan Berger wrote: On 3/27/23 07:11, Stefan Berger wrote: We get this message when booting from a kernel: [    0.582699] tpm_tis_i2c 12-002e: 2.0 TPM (device-id 0x1, rev-id 1) [    0.586361] tpm tpm0: A TPM error (256) occurred attempting the self test [   

Re: [PATCH v7 0/3] Add support for TPM devices over I2C bus

2023-03-27 Thread Stefan Berger
On 3/27/23 07:11, Stefan Berger wrote: We get this message when booting from a kernel: [    0.582699] tpm_tis_i2c 12-002e: 2.0 TPM (device-id 0x1, rev-id 1) [    0.586361] tpm tpm0: A TPM error (256) occurred attempting the self test [    0.586623] tpm tpm0: starting up the TPM manually

Re: [PATCH v7 0/3] Add support for TPM devices over I2C bus

2023-03-27 Thread Stefan Berger
On 3/27/23 07:18, Joel Stanley wrote: On Mon, 27 Mar 2023 at 11:11, Stefan Berger wrote: On 3/26/23 21:05, Joel Stanley wrote: Hi Ninad, On Sun, 26 Mar 2023 at 22:44, Ninad Palsule wrote: Hello, I have incorporated review comments from Stefan. Please review. This drop adds support

Re: [PATCH v7 0/3] Add support for TPM devices over I2C bus

2023-03-27 Thread Joel Stanley
On Mon, 27 Mar 2023 at 11:11, Stefan Berger wrote: > > > > On 3/26/23 21:05, Joel Stanley wrote: > > Hi Ninad, > > > > On Sun, 26 Mar 2023 at 22:44, Ninad Palsule wrote: > >> > >> Hello, > >> > >> I have incorporated review comments from Stefan. Please review. > >> > >> This drop adds support

Re: [PATCH v7 0/3] Add support for TPM devices over I2C bus

2023-03-27 Thread Stefan Berger
On 3/27/23 04:04, Joel Stanley wrote: On Mon, 27 Mar 2023 at 03:52, Ninad Palsule wrote: Hi Joel, On 3/26/23 8:05 PM, Joel Stanley wrote: Hi Ninad, On Sun, 26 Mar 2023 at 22:44, Ninad Palsule wrote: Hello, I have incorporated review comments from Stefan. Please review. This drop

Re: [PATCH v7 0/3] Add support for TPM devices over I2C bus

2023-03-27 Thread Stefan Berger
On 3/26/23 21:05, Joel Stanley wrote: Hi Ninad, On Sun, 26 Mar 2023 at 22:44, Ninad Palsule wrote: Hello, I have incorporated review comments from Stefan. Please review. This drop adds support for the TPM devices attached to the I2C bus. It only supports the TPM2 protocol. You need to

Re: [PATCH v7 0/3] Add support for TPM devices over I2C bus

2023-03-27 Thread Joel Stanley
On Mon, 27 Mar 2023 at 08:21, Cédric Le Goater wrote: > > >>> However on a clean boot into the TPM, the u-boot tpm commands fail: > >>> > >>> ast# tpm info > >>> tpm@2e v2.0: VendorID 0x1014, DeviceID 0x0001, RevisionID 0x01 [closed] > >>> ast# tpINTERRUPT> > >>> ast# tpm init > >>> ast# tpm info

Re: [PATCH v7 0/3] Add support for TPM devices over I2C bus

2023-03-27 Thread Cédric Le Goater
However on a clean boot into the TPM, the u-boot tpm commands fail: ast# tpm info tpm@2e v2.0: VendorID 0x1014, DeviceID 0x0001, RevisionID 0x01 [closed] ast# tpINTERRUPT> ast# tpm init ast# tpm info tpm@2e v2.0: VendorID 0x1014, DeviceID 0x0001, RevisionID 0x01 [open] ast# tpm pcr_read 0

Re: [PATCH v7 0/3] Add support for TPM devices over I2C bus

2023-03-27 Thread Joel Stanley
On Mon, 27 Mar 2023 at 03:52, Ninad Palsule wrote: > > Hi Joel, > > On 3/26/23 8:05 PM, Joel Stanley wrote: > > Hi Ninad, > > > > On Sun, 26 Mar 2023 at 22:44, Ninad Palsule wrote: > >> Hello, > >> > >> I have incorporated review comments from Stefan. Please review. > >> > >> This drop adds

Re: [PATCH v7 0/3] Add support for TPM devices over I2C bus

2023-03-26 Thread Ninad Palsule
Hi Joel, On 3/26/23 8:05 PM, Joel Stanley wrote: Hi Ninad, On Sun, 26 Mar 2023 at 22:44, Ninad Palsule wrote: Hello, I have incorporated review comments from Stefan. Please review. This drop adds support for the TPM devices attached to the I2C bus. It only supports the TPM2 protocol. You

Re: [PATCH v7 0/3] Add support for TPM devices over I2C bus

2023-03-26 Thread Joel Stanley
Hi Ninad, On Sun, 26 Mar 2023 at 22:44, Ninad Palsule wrote: > > Hello, > > I have incorporated review comments from Stefan. Please review. > > This drop adds support for the TPM devices attached to the I2C bus. It > only supports the TPM2 protocol. You need to run it with the external > TPM