Re: [Qemu-devel] [PATCH] block: implement the bdrv_reopen_prepare helper for LUKS driver

2018-03-06 Thread Kevin Wolf
Am 18.01.2018 um 11:31 hat Daniel P. Berrange geschrieben: > If the bdrv_reopen_prepare helper isn't provided, the qemu-img commit > command fails to re-open the base layer after committing changes into > it. Provide a no-op implementation for the LUKS driver, since there > is not any custom work t

Re: [Qemu-devel] [PATCH] block: implement the bdrv_reopen_prepare helper for LUKS driver

2018-03-06 Thread Daniel P . Berrangé
Ping On Fri, Feb 16, 2018 at 01:53:12PM +, Daniel P. Berrangé wrote: > Ping, can this be queued in the block tree, since it appears the no-op impl > is ok ? > > On Thu, Jan 18, 2018 at 10:31:43AM +, Daniel P. Berrange wrote: > > If the bdrv_reopen_prepare helper isn't provided, the qemu-

Re: [Qemu-devel] [PATCH] block: implement the bdrv_reopen_prepare helper for LUKS driver

2018-02-16 Thread Daniel P . Berrangé
Ping, can this be queued in the block tree, since it appears the no-op impl is ok ? On Thu, Jan 18, 2018 at 10:31:43AM +, Daniel P. Berrange wrote: > If the bdrv_reopen_prepare helper isn't provided, the qemu-img commit > command fails to re-open the base layer after committing changes into >

Re: [Qemu-devel] [PATCH] block: implement the bdrv_reopen_prepare helper for LUKS driver

2018-01-31 Thread Max Reitz
On 2018-01-18 11:31, Daniel P. Berrange wrote: > If the bdrv_reopen_prepare helper isn't provided, the qemu-img commit > command fails to re-open the base layer after committing changes into > it. Provide a no-op implementation for the LUKS driver, since there > is not any custom work that needs do

Re: [Qemu-devel] [PATCH] block: implement the bdrv_reopen_prepare helper for LUKS driver

2018-01-19 Thread Daniel P. Berrange
On Thu, Jan 18, 2018 at 01:51:36PM -0600, Eric Blake wrote: > On 01/18/2018 04:31 AM, Daniel P. Berrange wrote: > > If the bdrv_reopen_prepare helper isn't provided, the qemu-img commit > > command fails to re-open the base layer after committing changes into > > it. Provide a no-op implementation

Re: [Qemu-devel] [PATCH] block: implement the bdrv_reopen_prepare helper for LUKS driver

2018-01-18 Thread Eric Blake
On 01/18/2018 04:31 AM, Daniel P. Berrange wrote: > If the bdrv_reopen_prepare helper isn't provided, the qemu-img commit > command fails to re-open the base layer after committing changes into > it. Provide a no-op implementation for the LUKS driver, since there > is not any custom work that needs