Re: [Qemu-devel] [PATCH] chardev/char-socket: add POLLHUP handler

2018-01-18 Thread Daniel P. Berrange
On Thu, Jan 18, 2018 at 12:41:08PM +0300, klim wrote: > On 01/16/2018 08:25 PM, Paolo Bonzini wrote: > > On 10/01/2018 14:18, Klim Kireev wrote: > > > The following behavior was observed for QEMU configured by libvirt > > > to use guest agent as usual for the guests without virtio-serial > > >

Re: [Qemu-devel] [PATCH] chardev/char-socket: add POLLHUP handler

2018-01-18 Thread klim
On 01/18/2018 12:44 PM, Paolo Bonzini wrote: On 18/01/2018 10:41, klim wrote: I propose to install a separate pullhup watcher regardless of whether the device waits for data or not. After closing the connection, the guest has a capability to read the data within timeout. I don't understand the

Re: [Qemu-devel] [PATCH] chardev/char-socket: add POLLHUP handler

2018-01-18 Thread Paolo Bonzini
On 18/01/2018 10:41, klim wrote: >>> >>> I propose to install a separate pullhup watcher regardless of >>> whether the device waits for data or not. After closing the connection, >>> the guest has a capability to read the data within timeout. >> I don't understand the timeout part. > The timeout

Re: [Qemu-devel] [PATCH] chardev/char-socket: add POLLHUP handler

2018-01-18 Thread klim
On 01/16/2018 08:25 PM, Paolo Bonzini wrote: On 10/01/2018 14:18, Klim Kireev wrote: The following behavior was observed for QEMU configured by libvirt to use guest agent as usual for the guests without virtio-serial driver (Windows or the guest remaining in BIOS stage). In QEMU on first

Re: [Qemu-devel] [PATCH] chardev/char-socket: add POLLHUP handler

2018-01-16 Thread Daniel P. Berrange
On Tue, Jan 16, 2018 at 06:56:20PM +0100, Marc-André Lureau wrote: > Hi > > On Wed, Jan 10, 2018 at 2:18 PM, Klim Kireev > wrote: > > The following behavior was observed for QEMU configured by libvirt > > to use guest agent as usual for the guests without

Re: [Qemu-devel] [PATCH] chardev/char-socket: add POLLHUP handler

2018-01-16 Thread Marc-André Lureau
Hi On Wed, Jan 10, 2018 at 2:18 PM, Klim Kireev wrote: > The following behavior was observed for QEMU configured by libvirt > to use guest agent as usual for the guests without virtio-serial > driver (Windows or the guest remaining in BIOS stage). > > In QEMU on first

Re: [Qemu-devel] [PATCH] chardev/char-socket: add POLLHUP handler

2018-01-16 Thread Paolo Bonzini
On 10/01/2018 14:18, Klim Kireev wrote: > The following behavior was observed for QEMU configured by libvirt > to use guest agent as usual for the guests without virtio-serial > driver (Windows or the guest remaining in BIOS stage). > > In QEMU on first connect to listen character device socket >