Re: [Qemu-devel] [PATCH] file-posix: Consolidate the locking error message

2018-06-07 Thread Daniel P . Berrangé
On Thu, Jun 07, 2018 at 03:20:24PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Fri, Jun 01, 2018 at 05:18:35PM +0800, Fam Zheng wrote: > >> When hot-plugging a block device fails due to image locking errors, > >> users won't see the helpful 'Is another process using the

Re: [Qemu-devel] [PATCH] file-posix: Consolidate the locking error message

2018-06-07 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Fri, Jun 01, 2018 at 05:18:35PM +0800, Fam Zheng wrote: >> When hot-plugging a block device fails due to image locking errors, >> users won't see the helpful 'Is another process using the image?' >> message in QMP because currently the error hint is not carried

Re: [Qemu-devel] [PATCH] file-posix: Consolidate the locking error message

2018-06-01 Thread Fam Zheng
On Fri, 06/01 15:00, Daniel P. Berrangé wrote: > On Fri, Jun 01, 2018 at 09:33:59PM +0800, Fam Zheng wrote: > > On Fri, 06/01 13:43, Daniel P. Berrangé wrote: > > > On Fri, Jun 01, 2018 at 05:18:35PM +0800, Fam Zheng wrote: > > > > When hot-plugging a block device fails due to image locking

Re: [Qemu-devel] [PATCH] file-posix: Consolidate the locking error message

2018-06-01 Thread Daniel P . Berrangé
On Fri, Jun 01, 2018 at 09:33:59PM +0800, Fam Zheng wrote: > On Fri, 06/01 13:43, Daniel P. Berrangé wrote: > > On Fri, Jun 01, 2018 at 05:18:35PM +0800, Fam Zheng wrote: > > > When hot-plugging a block device fails due to image locking errors, > > > users won't see the helpful 'Is another process

Re: [Qemu-devel] [PATCH] file-posix: Consolidate the locking error message

2018-06-01 Thread Fam Zheng
On Fri, 06/01 07:32, Eric Blake wrote: > On 06/01/2018 04:18 AM, Fam Zheng wrote: > > When hot-plugging a block device fails due to image locking errors, > > users won't see the helpful 'Is another process using the image?' > > message in QMP because currently the error hint is not carried over >

Re: [Qemu-devel] [PATCH] file-posix: Consolidate the locking error message

2018-06-01 Thread Fam Zheng
On Fri, 06/01 13:43, Daniel P. Berrangé wrote: > On Fri, Jun 01, 2018 at 05:18:35PM +0800, Fam Zheng wrote: > > When hot-plugging a block device fails due to image locking errors, > > users won't see the helpful 'Is another process using the image?' > > message in QMP because currently the error

Re: [Qemu-devel] [PATCH] file-posix: Consolidate the locking error message

2018-06-01 Thread Daniel P . Berrangé
On Fri, Jun 01, 2018 at 05:18:35PM +0800, Fam Zheng wrote: > When hot-plugging a block device fails due to image locking errors, > users won't see the helpful 'Is another process using the image?' > message in QMP because currently the error hint is not carried over > there. > > Even though

Re: [Qemu-devel] [PATCH] file-posix: Consolidate the locking error message

2018-06-01 Thread Eric Blake
On 06/01/2018 04:18 AM, Fam Zheng wrote: When hot-plugging a block device fails due to image locking errors, users won't see the helpful 'Is another process using the image?' message in QMP because currently the error hint is not carried over there. Even though extending QMP to include hint is