On 09/10/2018 07:55, Li Qiang wrote: > As the bios is a ROM, just using rom API. > AFAICS no functionality changed. > > Signed-off-by: Li Qiang <liq...@gmail.com> > ---
ROM and RAM are just the same, with the readonly flag defaulting to either true or false. Because the alias here: memory_region_init_alias(isa_bios, NULL, "isa-bios", bios, bios_size - isa_bios_size, isa_bios_size); if (!isapc_ram_fw) { memory_region_set_readonly(isa_bios, true); } defaults to read-write (and your patch is wrong in changing the direction of the if), it makes sense to do the same for the bios memory region. Thanks, Paolo