Re: [Qemu-devel] [PATCH] increase BlockConf.min_io_size type from uint16_t to uint32_t

2012-05-02 Thread Kevin Wolf
Am 30.04.2012 17:52, schrieb Michael Tokarev: This value is used currently for virtio-blk only. It was defined as uint16_t before, which is the same as in kernel=user interface (in virtio_blk.h, struct virtio_blk_config). But the problem is that in kernel=user interface the units are sectors

Re: [Qemu-devel] [PATCH] increase BlockConf.min_io_size type from uint16_t to uint32_t

2012-05-02 Thread Michael Tokarev
02.05.2012 13:57, Kevin Wolf пишет: Am 30.04.2012 17:52, schrieb Michael Tokarev: This value is used currently for virtio-blk only. It was defined as uint16_t before, which is the same as in kernel=user interface (in virtio_blk.h, struct virtio_blk_config). But the problem is that in

Re: [Qemu-devel] [PATCH] increase BlockConf.min_io_size type from uint16_t to uint32_t

2012-05-02 Thread Kevin Wolf
Am 02.05.2012 12:08, schrieb Michael Tokarev: 02.05.2012 13:57, Kevin Wolf пишет: Am 30.04.2012 17:52, schrieb Michael Tokarev: This value is used currently for virtio-blk only. It was defined as uint16_t before, which is the same as in kernel=user interface (in virtio_blk.h, struct

Re: [Qemu-devel] [PATCH] increase BlockConf.min_io_size type from uint16_t to uint32_t

2012-05-02 Thread Michael Tokarev
On 02.05.2012 18:35, Kevin Wolf wrote: [] As I already mentioned, the virtio protocol has the same defect (but there it is less serious due to usage of larger units). And that's where the additional overflow needs to be ELIMINATED, not just checked. Ie, the protocol should be changed somehow

Re: [Qemu-devel] [PATCH] increase BlockConf.min_io_size type from uint16_t to uint32_t

2012-05-02 Thread Kevin Wolf
Am 02.05.2012 17:37, schrieb Michael Tokarev: On 02.05.2012 18:35, Kevin Wolf wrote: [] As I already mentioned, the virtio protocol has the same defect (but there it is less serious due to usage of larger units). And that's where the additional overflow needs to be ELIMINATED, not just

Re: [Qemu-devel] [PATCH] increase BlockConf.min_io_size type from uint16_t to uint32_t

2012-05-01 Thread Stefan Hajnoczi
On Mon, Apr 30, 2012 at 4:52 PM, Michael Tokarev m...@tls.msk.ru wrote: This value is used currently for virtio-blk only.  It was defined as uint16_t before, which is the same as in kernel=user interface (in virtio_blk.h, struct virtio_blk_config).  But the problem is that in kernel=user

Re: [Qemu-devel] [PATCH] increase BlockConf.min_io_size type from uint16_t to uint32_t

2012-05-01 Thread Michael Tokarev
On 01.05.2012 12:27, Stefan Hajnoczi wrote: On Mon, Apr 30, 2012 at 4:52 PM, Michael Tokarev m...@tls.msk.ru wrote: This value is used currently for virtio-blk only. It was defined as uint16_t before, which is the same as in kernel=user interface (in virtio_blk.h, struct virtio_blk_config).