Re: [Qemu-devel] [PATCH] log-for-trace.h: Split out parts of log.h used by trace.h

2018-03-08 Thread Peter Maydell
On 23 February 2018 at 16:33, Stefan Hajnoczi wrote: > On Tue, Feb 13, 2018 at 02:00:29PM +, Peter Maydell wrote: >> A persistent build problem we see is where a source file >> accidentally omits the #include of log.h. This slips through >> local developer testing because

Re: [Qemu-devel] [PATCH] log-for-trace.h: Split out parts of log.h used by trace.h

2018-02-23 Thread Stefan Hajnoczi
On Tue, Feb 13, 2018 at 02:00:29PM +, Peter Maydell wrote: > A persistent build problem we see is where a source file > accidentally omits the #include of log.h. This slips through > local developer testing because if you configure with the > default (log) trace backend trace.h will pull in

Re: [Qemu-devel] [PATCH] log-for-trace.h: Split out parts of log.h used by trace.h

2018-02-13 Thread Peter Maydell
On 13 February 2018 at 15:19, Eric Blake wrote: > On 02/13/2018 08:00 AM, Peter Maydell wrote: >> +++ b/scripts/tracetool/backend/log.py >> @@ -20,7 +20,7 @@ PUBLIC = True >> def generate_h_begin(events, group): >> -out('#include "qemu/log.h"', >> +out('#include

Re: [Qemu-devel] [PATCH] log-for-trace.h: Split out parts of log.h used by trace.h

2018-02-13 Thread Richard Henderson
On 02/13/2018 06:00 AM, Peter Maydell wrote: > A persistent build problem we see is where a source file > accidentally omits the #include of log.h. This slips through > local developer testing because if you configure with the > default (log) trace backend trace.h will pull in log.h for you. >

Re: [Qemu-devel] [PATCH] log-for-trace.h: Split out parts of log.h used by trace.h

2018-02-13 Thread Eric Blake
On 02/13/2018 08:00 AM, Peter Maydell wrote: A persistent build problem we see is where a source file accidentally omits the #include of log.h. This slips through local developer testing because if you configure with the default (log) trace backend trace.h will pull in log.h for you. Compilation