Re: [Qemu-devel] [PATCH] maintainers: Add myself as a OpenBSD maintainer

2018-02-23 Thread Peter Maydell 
On 16 February 2018 at 16:46, Brad Smith  wrote:
> Add myself as an OpenBSD maintainer and add OpenBSD as maintained.
>
> Signed-off-by: Brad Smith 
>
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 57358a08e2..86329e274f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -386,6 +386,12 @@ M: Kamil Rytarowski 
>  S: Maintained
>  K: ^Subject:.*(?i)NetBSD
>
> +OPENBSD
> +L: qemu-devel@nongnu.org
> +M: Brad Smith 
> +S: Maintained
> +K: ^Subject:.*(?i)OpenBSD
> +
>  W32, W64
>  L: qemu-devel@nongnu.org
>  M: Stefan Weil 
> diff --git a/configure b/configure
> index 913e14839d..850c46ebac 100755
> --- a/configure
> +++ b/configure
> @@ -760,6 +760,7 @@ OpenBSD)
>audio_drv_list="sdl"
>audio_possible_drivers="sdl"
>HOST_VARIANT_DIR="openbsd"
> +  supported_os="yes"
>  ;;
>  Darwin)
>bsd="yes"

Thanks for agreeing to help us with the BSD host maintenance.
I've applied this patch to master. If you and Kamil want to
maintain a subtree for doing pull requests for BSD host
patches that's fine with me; otherwise we can continue to
ad-hoc apply patches through whatever route is simplest.

thanks
-- PMM

Re: [Qemu-devel] [PATCH] maintainers: Add myself as a OpenBSD maintainer

2018-02-23 Thread Fam Zheng 
On Fri, 02/16 14:44, Philippe Mathieu-Daudé wrote:
> On 02/16/2018 02:41 PM, Kamil Rytarowski wrote:
> > On 16.02.2018 18:30, Philippe Mathieu-Daudé wrote:
> >> But before announcing the host OS being supported again, I'd rather see
> >> reproducible build/tests logs, in a (public - if possible) continuous
> >> integration system. Else it is hard to notice when it get broken.
> >>
> > 
> > This is already done for FreeBSD, NetBSD and OpenBSD.
> 
> We have the ability to run those, but afaik no CI are using them.

That's right. I can try enabling them on patchew, but my gut feeling is that
these still need to be optimized (especially, enabling persisted ccache like our
docker tests, so it is reasonably efficient for our limited resources).

Fam

Re: [Qemu-devel] [PATCH] maintainers: Add myself as a OpenBSD maintainer

2018-02-16 Thread Philippe Mathieu-Daudé 
On 02/16/2018 02:41 PM, Kamil Rytarowski wrote:
> On 16.02.2018 18:30, Philippe Mathieu-Daudé wrote:
>> But before announcing the host OS being supported again, I'd rather see
>> reproducible build/tests logs, in a (public - if possible) continuous
>> integration system. Else it is hard to notice when it get broken.
>>
> 
> This is already done for FreeBSD, NetBSD and OpenBSD.

We have the ability to run those, but afaik no CI are using them.

$ make vm-test
vm-test: Test QEMU in preconfigured virtual machines

  vm-build-ubuntu.i386- Build QEMU in ubuntu i386 VM
  vm-build-freebsd- Build QEMU in FreeBSD VM
  vm-build-netbsd - Build QEMU in NetBSD VM
  vm-build-openbsd- Build QEMU in OpenBSD VM

> 
> CC: Fam who can confirm this.




signature.asc
Description: OpenPGP digital signature

Re: [Qemu-devel] [PATCH] maintainers: Add myself as a OpenBSD maintainer

2018-02-16 Thread Daniel P . Berrangé 
On Fri, Feb 16, 2018 at 05:37:32PM +, Peter Maydell wrote:
> On 16 February 2018 at 17:30, Philippe Mathieu-Daudé  wrote:
> > But before announcing the host OS being supported again, I'd rather see
> > reproducible build/tests logs, in a (public - if possible) continuous
> > integration system. Else it is hard to notice when it get broken.
> 
> I do include OpenBSD in my set of build/tests for merges.

There's also "make vm-build-openbsd"  for devs who want to test easily in
an OpenBSD VM, or investigate brokeness.

Regards,
Daniel
-- 
|: https://berrange.com  -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|

Re: [Qemu-devel] [PATCH] maintainers: Add myself as a OpenBSD maintainer

2018-02-16 Thread Kamil Rytarowski 
On 16.02.2018 18:30, Philippe Mathieu-Daudé wrote:
> But before announcing the host OS being supported again, I'd rather see
> reproducible build/tests logs, in a (public - if possible) continuous
> integration system. Else it is hard to notice when it get broken.
> 

This is already done for FreeBSD, NetBSD and OpenBSD.

CC: Fam who can confirm this.



signature.asc
Description: OpenPGP digital signature

Re: [Qemu-devel] [PATCH] maintainers: Add myself as a OpenBSD maintainer

2018-02-16 Thread Peter Maydell 
On 16 February 2018 at 17:30, Philippe Mathieu-Daudé  wrote:
> But before announcing the host OS being supported again, I'd rather see
> reproducible build/tests logs, in a (public - if possible) continuous
> integration system. Else it is hard to notice when it get broken.

I do include OpenBSD in my set of build/tests for merges.

thanks
-- PMM

Re: [Qemu-devel] [PATCH] maintainers: Add myself as a OpenBSD maintainer

2018-02-16 Thread Philippe Mathieu-Daudé 
Hi Brad,

On 02/16/2018 01:46 PM, Brad Smith wrote:
> Add myself as an OpenBSD maintainer and add OpenBSD as maintained.
> 
> Signed-off-by: Brad Smith 
> 
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 57358a08e2..86329e274f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -386,6 +386,12 @@ M: Kamil Rytarowski 
>  S: Maintained
>  K: ^Subject:.*(?i)NetBSD
>  
> +OPENBSD
> +L: qemu-devel@nongnu.org
> +M: Brad Smith 
> +S: Maintained
> +K: ^Subject:.*(?i)OpenBSD
> +

No problem here,

>  W32, W64
>  L: qemu-devel@nongnu.org
>  M: Stefan Weil 
> diff --git a/configure b/configure
> index 913e14839d..850c46ebac 100755
> --- a/configure
> +++ b/configure
> @@ -760,6 +760,7 @@ OpenBSD)
>audio_drv_list="sdl"
>audio_possible_drivers="sdl"
>HOST_VARIANT_DIR="openbsd"
> +  supported_os="yes"

But before announcing the host OS being supported again, I'd rather see
reproducible build/tests logs, in a (public - if possible) continuous
integration system. Else it is hard to notice when it get broken.

>  ;;
>  Darwin)
>bsd="yes"
> 

Regards,

Phil.

Re: [Qemu-devel] [PATCH] maintainers: Add myself as a OpenBSD maintainer

2018-02-16 Thread Kamil Rytarowski 
On 16.02.2018 17:46, Brad Smith wrote:
> Add myself as an OpenBSD maintainer and add OpenBSD as maintained.
> 
> Signed-off-by: Brad Smith 
> 

Reviewed-by: Kamil Rytarowski 

Would you like to co-maintain with myself a merge-branch for BSD? Right
now I send patches through other developers and it does not always work
smoothly.

> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 57358a08e2..86329e274f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -386,6 +386,12 @@ M: Kamil Rytarowski 
>  S: Maintained
>  K: ^Subject:.*(?i)NetBSD
>  
> +OPENBSD
> +L: qemu-devel@nongnu.org
> +M: Brad Smith 
> +S: Maintained
> +K: ^Subject:.*(?i)OpenBSD
> +
>  W32, W64
>  L: qemu-devel@nongnu.org
>  M: Stefan Weil 
> diff --git a/configure b/configure
> index 913e14839d..850c46ebac 100755
> --- a/configure
> +++ b/configure
> @@ -760,6 +760,7 @@ OpenBSD)
>audio_drv_list="sdl"
>audio_possible_drivers="sdl"
>HOST_VARIANT_DIR="openbsd"
> +  supported_os="yes"
>  ;;
>  Darwin)
>bsd="yes"
> 




signature.asc
Description: OpenPGP digital signature