Re: [Qemu-devel] [PATCH] misc: don't use hwaddr as a type in trace events

2018-03-06 Thread Mark Cave-Ayland
On 06/03/18 13:24, Daniel P. Berrangé wrote: Use types that are defined by QEMU in trace events caused build failures for the UST trace backend: In file included from trace-ust-all.c:13:0: trace-ust-all.h:11844:206: error: unknown type name ‘hwaddr’ It only knows about C built-in types,

Re: [Qemu-devel] [PATCH] misc: don't use hwaddr as a type in trace events

2018-03-06 Thread Peter Maydell
On 6 March 2018 at 13:24, Daniel P. Berrangé wrote: > Use types that are defined by QEMU in trace events caused build failures > for the UST trace backend: > > In file included from trace-ust-all.c:13:0: > trace-ust-all.h:11844:206: error: unknown type name ‘hwaddr’ > >

Re: [Qemu-devel] [PATCH] misc: don't use hwaddr as a type in trace events

2018-03-06 Thread Peter Maydell
On 6 March 2018 at 13:38, Daniel P. Berrangé wrote: > On Tue, Mar 06, 2018 at 01:33:42PM +, Peter Maydell wrote: >> If the type isn't "hwaddr" then HWADDR_PRIx is the wrong >> format string macro -- those should change to PRIx64. > > Eeek, that HWADDR_PRIx macro is used

Re: [Qemu-devel] [PATCH] misc: don't use hwaddr as a type in trace events

2018-03-06 Thread Daniel P . Berrangé
On Tue, Mar 06, 2018 at 01:33:42PM +, Peter Maydell wrote: > On 6 March 2018 at 13:24, Daniel P. Berrangé wrote: > > Use types that are defined by QEMU in trace events caused build failures > > for the UST trace backend: > > > > In file included from