Re: [Qemu-devel] [PATCH] modules-test: ui-spice-app is not built as module

2019-08-23 Thread Peter Maydell
On Thu, 22 Aug 2019 at 18:42, Paolo Bonzini wrote: > > $(call land, $(CONFIG_SPICE), $(CONFIG_GIO)) will never return "m" so > ui-spice-app is always linked into QEMU. > > Signed-off-by: Paolo Bonzini > --- > tests/modules-test.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH] modules-test: ui-spice-app is not built as module

2019-08-23 Thread Miroslav Rezanina
On Thu, Aug 22, 2019 at 07:42:14PM +0200, Paolo Bonzini wrote: > $(call land, $(CONFIG_SPICE), $(CONFIG_GIO)) will never return "m" so > ui-spice-app is always linked into QEMU. > > Signed-off-by: Paolo Bonzini > --- > tests/modules-test.c | 3 --- > 1 file changed, 3 deletions(-) > > diff

Re: [Qemu-devel] [PATCH] modules-test: ui-spice-app is not built as module

2019-08-23 Thread Paolo Bonzini
On 23/08/19 09:32, Marc-André Lureau wrote: > On Thu, Aug 22, 2019 at 9:43 PM Paolo Bonzini wrote: >> >> $(call land, $(CONFIG_SPICE), $(CONFIG_GIO)) will never return "m" so >> ui-spice-app is always linked into QEMU. >> >> Signed-off-by: Paolo Bonzini > > I would rather build the module: >

Re: [Qemu-devel] [PATCH] modules-test: ui-spice-app is not built as module

2019-08-23 Thread Marc-André Lureau
On Thu, Aug 22, 2019 at 9:43 PM Paolo Bonzini wrote: > > $(call land, $(CONFIG_SPICE), $(CONFIG_GIO)) will never return "m" so > ui-spice-app is always linked into QEMU. > > Signed-off-by: Paolo Bonzini I would rather build the module: -common-obj-$(call land,$(CONFIG_SPICE),$(CONFIG_GIO)) +=