Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again

On 04/18/2018 11:32 AM, Philippe Mathieu-Daudé wrote: > Hi Marc-André, > > On 04/18/2018 07:36 AM, Marc-André Lureau wrote: >> In commit cd9526ab7c04f2c32c63340b04401f6ed25682b9 >> Author: Philippe Mathieu-Daudé >> Date: Thu Mar 8 23:39:32 2018 +0100 >> >> hw/isa/superio:

Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again

Hi Marc-André, On 04/18/2018 07:36 AM, Marc-André Lureau wrote: > In commit cd9526ab7c04f2c32c63340b04401f6ed25682b9 > Author: Philippe Mathieu-Daudé > Date: Thu Mar 8 23:39:32 2018 +0100 > > hw/isa/superio: Factor out the serial code from pc87312.c > > You changed

Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again

Hi On Wed, Apr 18, 2018 at 3:47 PM, Paolo Bonzini wrote: > On 18/04/2018 14:22, Marc-André Lureau wrote: - Chardev: stdio, mux, ringbuf, pty, file, null etc.. - CharBackend: the "user" end - frontend: the "user" >>> The frontend is the device, the monitor, etc. >>

Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again

On 18/04/2018 14:06, Peter Maydell wrote: > >> In case of a mux chardev, it may already >> have an active frontend (yeah be is CharBackend which is the frontend, >> I still can't grasp that either, please Paolo change your mind! ;). > I agree with Marc-André that the terminology for our chardev >

Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again

On 18/04/2018 14:22, Marc-André Lureau wrote: >>> - Chardev: stdio, mux, ringbuf, pty, file, null etc.. >>> - CharBackend: the "user" end >>> - frontend: the "user" >> The frontend is the device, the monitor, etc. > yes, I should have listed it for clarity > >> The backend is how the >> frontend

Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again

Hi On Wed, Apr 18, 2018 at 1:55 PM, Paolo Bonzini wrote: > On 18/04/2018 13:35, Marc-André Lureau wrote: >>> CharBackend is not the frontend, it is *used* by the front-end. It is >>> the qemu_chr_* functions that are named wrong (they're named according >>> to the user

Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again

On 18 April 2018 at 11:36, Marc-André Lureau wrote: > In commit cd9526ab7c04f2c32c63340b04401f6ed25682b9 > Author: Philippe Mathieu-Daudé > Date: Thu Mar 8 23:39:32 2018 +0100 > > hw/isa/superio: Factor out the serial code from pc87312.c > >

Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again

On 18/04/2018 13:35, Marc-André Lureau wrote: >> CharBackend is not the frontend, it is *used* by the front-end. It is >> the qemu_chr_* functions that are named wrong (they're named according >> to the user rather than the recipient). > If I follow you and the naming, you have this in mind: > >

Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again

Hi On Wed, Apr 18, 2018 at 12:55 PM, Paolo Bonzini wrote: > On 18/04/2018 12:36, Marc-André Lureau wrote: >> >> +if (chr == NULL || chr->be) { >> +name = g_strdup_printf("discarding-serial%d", i); >> +chr = qemu_chr_new(name,

Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again

On 18/04/2018 12:36, Marc-André Lureau wrote: > > +if (chr == NULL || chr->be) { > +name = g_strdup_printf("discarding-serial%d", i); > +chr = qemu_chr_new(name, "null"); > +} else { > +name = g_strdup_printf("serial%d", i);

Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again

Hi On Tue, Apr 17, 2018 at 8:36 PM, Philippe Mathieu-Daudé wrote: > Hi, > On 16 April 2018 at 19:18, Marc-André Lureau wrote: > Commit fb5e19d2e1472e96d72d5e4d89c20033f8ab345c originally fixed the > regression, but was

Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again

Hi On Tue, Apr 17, 2018 at 11:19 PM, Peter Maydell wrote: > On 17 April 2018 at 19:36, Philippe Mathieu-Daudé wrote: >> Since this commit, the console on the Malta board stay black... >> >> Before: >> $ qemu-system-mips -M malta -m 512 \ >> -kernel

Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again

On 17 April 2018 at 19:36, Philippe Mathieu-Daudé wrote: > Since this commit, the console on the Malta board stay black... > > Before: > $ qemu-system-mips -M malta -m 512 \ > -kernel vmlinux-3.2.0-4-4kc-malta -append 'root=/dev/sda1' \ > -nographic > [0.00]

Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again

On 17 April 2018 at 19:36, Philippe Mathieu-Daudé wrote: > Hi, > Opinions welcome on whether this is a regression fix worth putting into rc4. >>> >>> It is a regression, but a long standing one - we've been broken for quite >>> a while since 2.9.0 or even before. >>>

Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again

Hi, >>> On 16 April 2018 at 19:18, Marc-André Lureau >>> wrote: Commit fb5e19d2e1472e96d72d5e4d89c20033f8ab345c originally fixed the regression, but was inadvertently broken again in merge commit 2d6752d38d8acda. Fixes:

Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again

On 16 April 2018 at 19:44, Daniel P. Berrangé wrote: > On Mon, Apr 16, 2018 at 07:28:28PM +0100, Peter Maydell wrote: >> On 16 April 2018 at 19:18, Marc-André Lureau >> wrote: >> > Commit fb5e19d2e1472e96d72d5e4d89c20033f8ab345c originally fixed

Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again

On Mon, Apr 16, 2018 at 07:28:28PM +0100, Peter Maydell wrote: > On 16 April 2018 at 19:18, Marc-André Lureau > wrote: > > Commit fb5e19d2e1472e96d72d5e4d89c20033f8ab345c originally fixed the > > regression, but was inadvertently broken again in merge commit > >

Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again

On 16 April 2018 at 19:18, Marc-André Lureau wrote: > Commit fb5e19d2e1472e96d72d5e4d89c20033f8ab345c originally fixed the > regression, but was inadvertently broken again in merge commit > 2d6752d38d8acda. > > Fixes: > https://bugs.launchpad.net/qemu/+bug/1654137 > >