Re: [Qemu-devel] [PATCH] netdev: fix socket backend implementation and docs

2018-11-14 Thread Daniel P . Berrangé
On Tue, Nov 13, 2018 at 04:13:04PM +0600, Artem Pisarenko wrote: > > Incidentally this method should not even be part of this header > > files. qemu/sockets.h is for code that lives in util/qemu-sockets.c > > > > The parse_host_port declaration and impl should better live in > > net/util.{c,h},

Re: [Qemu-devel] [PATCH] netdev: fix socket backend implementation and docs

2018-11-13 Thread Artem Pisarenko
> Incidentally this method should not even be part of this header > files. qemu/sockets.h is for code that lives in util/qemu-sockets.c > > The parse_host_port declaration and impl should better live in > net/util.{c,h}, so I'd recommend moving that as the first patch > in a series. Ok. > This

Re: [Qemu-devel] [PATCH] netdev: fix socket backend implementation and docs

2018-11-12 Thread Daniel P . Berrangé
On Wed, Nov 07, 2018 at 12:57:30PM +0600, Artem Pisarenko wrote: > Changes: > - user documentation and QAPI 'NetdevSocketOptions' comments updated > to match current implementation ('udp' type description added, 'fd' > option separated to exclusive type and described, 'localaddr'-related >