Re: [Qemu-devel] [PATCH] nvdimm: allow read/write zero-size namespace label

2017-01-16 Thread Stefan Hajnoczi
On Sat, Jan 14, 2017 at 07:22:28PM +0800, Li Qiang wrote: > Hello Guangrong, > > > 2017-01-13 17:00 GMT+08:00 Xiao Guangrong : > > > > > > > On 01/13/2017 11:02 AM, Li Qiang wrote: > > > >> From: Li Qiang > >> > >> The spec doesn't say the namespace label can't be zero > >> when read/write it.

Re: [Qemu-devel] [PATCH] nvdimm: allow read/write zero-size namespace label

2017-01-14 Thread Li Qiang
Hello Guangrong, 2017-01-13 17:00 GMT+08:00 Xiao Guangrong : > > > On 01/13/2017 11:02 AM, Li Qiang wrote: > >> From: Li Qiang >> >> The spec doesn't say the namespace label can't be zero >> when read/write it. As this is no harmful, just allow >> it. >> >> > WHY? > > The spec said that the lab

Re: [Qemu-devel] [PATCH] nvdimm: allow read/write zero-size namespace label

2017-01-13 Thread Xiao Guangrong
On 01/13/2017 11:02 AM, Li Qiang wrote: From: Li Qiang The spec doesn't say the namespace label can't be zero when read/write it. As this is no harmful, just allow it. WHY? The spec said that the label should be at least 128K.