Re: [Qemu-devel] [PATCH] qmp: fix object-add assert() without props

2016-09-22 Thread Markus Armbruster
Marc-André Lureau writes: > Since commit ad739706bbadee49, user_creatable_add_type() expects to be > given a qdict. However, if object-add is called without props, you reach > the assert: "qemu/qom/object_interfaces.c:115: user_creatable_add_type: > Assertion `qdict' failed.", because the qdict i

Re: [Qemu-devel] [PATCH] qmp: fix object-add assert() without props

2016-09-22 Thread Daniel P. Berrange
On Wed, Sep 21, 2016 at 11:41:26PM +0400, Marc-André Lureau wrote: > Since commit ad739706bbadee49, user_creatable_add_type() expects to be > given a qdict. However, if object-add is called without props, you reach > the assert: "qemu/qom/object_interfaces.c:115: user_creatable_add_type: > Assertio

Re: [Qemu-devel] [PATCH] qmp: fix object-add assert() without props

2016-09-21 Thread Paolo Bonzini
On 21/09/2016 21:41, Marc-André Lureau wrote: > Since commit ad739706bbadee49, user_creatable_add_type() expects to be > given a qdict. However, if object-add is called without props, you reach > the assert: "qemu/qom/object_interfaces.c:115: user_creatable_add_type: > Assertion `qdict' failed.",

Re: [Qemu-devel] [PATCH] qmp: fix object-add assert() without props

2016-09-21 Thread Eric Blake
On 09/21/2016 02:41 PM, Marc-André Lureau wrote: > Since commit ad739706bbadee49, user_creatable_add_type() expects to be > given a qdict. However, if object-add is called without props, you reach > the assert: "qemu/qom/object_interfaces.c:115: user_creatable_add_type: > Assertion `qdict' failed."