Re: [Qemu-devel] [PATCH] rtc: placing RTC memory region outside BQL

2018-02-06 Thread Gonglei (Arei)
> -Original Message- > From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: Tuesday, February 06, 2018 5:49 PM > To: Gonglei (Arei) > Cc: Paolo Bonzini; QEMU Developers; Huangweidong (C) > Subject: Re: [Qemu-devel] [PATCH] rtc: placing RTC memory region out

Re: [Qemu-devel] [PATCH] rtc: placing RTC memory region outside BQL

2018-02-06 Thread Peter Maydell
On 6 February 2018 at 08:24, Gonglei (Arei) wrote: > So, taking BQL is necessary, and what we can do is trying our best to narrow > down the process of locking ? For example, do the following wrapping: > > static void rtc_rasie_irq(RTCState *s) > { > qemu_mutex_lock_iothread(); > qemu_irq_

Re: [Qemu-devel] [PATCH] rtc: placing RTC memory region outside BQL

2018-02-06 Thread Gonglei (Arei)
> -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Monday, February 05, 2018 10:04 PM > To: Peter Maydell > Cc: Gonglei (Arei); QEMU Developers; Huangweidong (C) > Subject: Re: [Qemu-devel] [PATCH] rtc: placing RTC memory region outside BQL

Re: [Qemu-devel] [PATCH] rtc: placing RTC memory region outside BQL

2018-02-05 Thread Paolo Bonzini
On 04/02/2018 19:02, Peter Maydell wrote: > On 1 February 2018 at 14:23, Paolo Bonzini wrote: >> On 01/02/2018 08:47, Gonglei wrote: >>> diff --git a/hw/timer/mc146818rtc.c b/hw/timer/mc146818rtc.c >>> index 35a05a6..d9d99c5 100644 >>> --- a/hw/timer/mc146818rtc.c >>> +++ b/hw/timer/mc146818rtc.c

Re: [Qemu-devel] [PATCH] rtc: placing RTC memory region outside BQL

2018-02-04 Thread Peter Maydell
On 1 February 2018 at 14:23, Paolo Bonzini wrote: > On 01/02/2018 08:47, Gonglei wrote: >> diff --git a/hw/timer/mc146818rtc.c b/hw/timer/mc146818rtc.c >> index 35a05a6..d9d99c5 100644 >> --- a/hw/timer/mc146818rtc.c >> +++ b/hw/timer/mc146818rtc.c >> @@ -986,6 +986,7 @@ static void rtc_realizefn(

Re: [Qemu-devel] [PATCH] rtc: placing RTC memory region outside BQL

2018-02-03 Thread Gonglei (Arei)
> -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Thursday, February 01, 2018 10:24 PM > To: Gonglei (Arei); qemu-devel@nongnu.org > Cc: Huangweidong (C) > Subject: Re: [PATCH] rtc: placing RTC memory region outside BQL > > On 01/02/2018 08:47, Gonglei wrote:

Re: [Qemu-devel] [PATCH] rtc: placing RTC memory region outside BQL

2018-02-01 Thread Paolo Bonzini
On 01/02/2018 08:47, Gonglei wrote: > As windows guest use rtc as the clock source device, > and access rtc frequently. Let's move the rtc memory > region outside BQL to decrease overhead for windows guests. > > strace -tt -p $1 -c -o result_$1.log & > sleep $2 > pid=$(pidof strace) > kill $pid >