Re: [Qemu-devel] [PATCH] slirp: use less predictable directory name in /tmp for smb config (CVE-2015-4037)

On Thu, May 28, 2015 at 02:15:43PM +0300, Michael Tokarev wrote: In this version I used mkdtemp(3) which is: _BSD_SOURCE || /* Since glibc 2.10: */ (_POSIX_C_SOURCE = 200809L || _XOPEN_SOURCE = 700) so should be available on systems we care about.

Re: [Qemu-devel] [PATCH] slirp: use less predictable directory name in /tmp for smb config (CVE-2015-4037)

Michael Tokarev m...@tls.msk.ru writes: 01.06.2015 11:01, Markus Armbruster wrote: [] -snprintf(s-smb_dir, sizeof(s-smb_dir), /tmp/qemu-smb.%ld-%d, - (long)getpid(), instance++); -if (mkdir(s-smb_dir, 0700) 0) { +strcpy(s-smb_dir, /tmp/qemu-smb.XX); +if

Re: [Qemu-devel] [PATCH] slirp: use less predictable directory name in /tmp for smb config (CVE-2015-4037)

01.06.2015 11:01, Markus Armbruster wrote: [] -snprintf(s-smb_dir, sizeof(s-smb_dir), /tmp/qemu-smb.%ld-%d, - (long)getpid(), instance++); -if (mkdir(s-smb_dir, 0700) 0) { +strcpy(s-smb_dir, /tmp/qemu-smb.XX); +if (!mkdtemp(s-smb_dir)) {

Re: [Qemu-devel] [PATCH] slirp: use less predictable directory name in /tmp for smb config (CVE-2015-4037)

Michael Tokarev m...@tls.msk.ru writes: In this version I used mkdtemp(3) which is: _BSD_SOURCE || /* Since glibc 2.10: */ (_POSIX_C_SOURCE = 200809L || _XOPEN_SOURCE = 700) so should be available on systems we care about. Signed-off-by: Michael Tokarev

Re: [Qemu-devel] [PATCH] slirp: use less predictable directory name in /tmp for smb config (CVE-2015-4037)

Michael Tokarev m...@tls.msk.ru writes: In this version I used mkdtemp(3) which is: _BSD_SOURCE || /* Since glibc 2.10: */ (_POSIX_C_SOURCE = 200809L || _XOPEN_SOURCE = 700) In short, it's POSIX.1-2008. so should be available on systems we care about. Yes.