Re: [Qemu-devel] [PATCH] tests: fix nbd test to work correctly with raw images

2018-11-21 Thread Kevin Wolf
[ Cc: qemu-block ]

Am 20.11.2018 um 18:56 hat Daniel P. Berrangé geschrieben:
> The first qemu-io command must honour the $IMGFMT that is set rather
> than hardcoding qcow2. The qemu-nbd commands should also set $IMGFMT
> to avoid the insecure format probe warning.
> 
> Signed-off-by: Daniel P. Berrangé 

Thanks, applied to the block branch.

Kevin



Re: [Qemu-devel] [PATCH] tests: fix nbd test to work correctly with raw images

2018-11-20 Thread Eric Blake

On 11/20/18 11:56 AM, Daniel P. Berrangé wrote:

The first qemu-io command must honour the $IMGFMT that is set rather
than hardcoding qcow2. The qemu-nbd commands should also set $IMGFMT
to avoid the insecure format probe warning.

Signed-off-by: Daniel P. Berrangé 
---
  tests/qemu-iotests/233 | 9 ++---
  1 file changed, 6 insertions(+), 3 deletions(-)



Reviewed-by: Eric Blake 

I'm fine if this goes through Kevin's tree (if he beats me to a next 
pull request) since he has been looking at other iotests issues; 
otherwise I'll plan on an NBD pull request for -rc3.


--
Eric Blake, Principal Software Engineer
Red Hat, Inc.   +1-919-301-3266
Virtualization:  qemu.org | libvirt.org