Re: [Qemu-devel] [PATCH] throttle-groups: fix restart coroutine iothread race

2019-01-14 Thread Alberto Garcia
On Mon 14 Jan 2019 05:31:17 PM CET, Stefan Hajnoczi wrote: > On Mon, Jan 14, 2019 at 05:26:48PM +0100, Alberto Garcia wrote: >> On Mon 14 Jan 2019 05:15:25 PM CET, Stefan Hajnoczi wrote: >> >> > I've been able to reproduce this in an iotest, please see v2 of this >> >> > series. >> >> >> >> That

Re: [Qemu-devel] [PATCH] throttle-groups: fix restart coroutine iothread race

2019-01-14 Thread Stefan Hajnoczi
On Mon, Jan 14, 2019 at 05:26:48PM +0100, Alberto Garcia wrote: > On Mon 14 Jan 2019 05:15:25 PM CET, Stefan Hajnoczi wrote: > >> > I've been able to reproduce this in an iotest, please see v2 of this > >> > series. > >> > >> That iotest doesn't crash for me :-? > > > > Does my iotest pass for

Re: [Qemu-devel] [PATCH] throttle-groups: fix restart coroutine iothread race

2019-01-14 Thread Alberto Garcia
On Mon 14 Jan 2019 05:15:25 PM CET, Stefan Hajnoczi wrote: >> > I've been able to reproduce this in an iotest, please see v2 of this >> > series. >> >> That iotest doesn't crash for me :-? > > Does my iotest pass for you? Yes, it does. I'm trying to figure out why because if I run the QMP

Re: [Qemu-devel] [PATCH] throttle-groups: fix restart coroutine iothread race

2019-01-14 Thread Stefan Hajnoczi
On Mon, Jan 14, 2019 at 03:40:39PM +0100, Alberto Garcia wrote: > On Mon 14 Jan 2019 02:35:53 PM CET, Stefan Hajnoczi wrote: > > On Fri, Jan 11, 2019 at 03:14:08PM +0100, Alberto Garcia wrote: > >> On Fri 11 Jan 2019 02:24:16 PM CET, Kevin Wolf wrote: > >> >> >> The following QMP command leads to

Re: [Qemu-devel] [PATCH] throttle-groups: fix restart coroutine iothread race

2019-01-14 Thread Alberto Garcia
On Mon 14 Jan 2019 02:35:53 PM CET, Stefan Hajnoczi wrote: > On Fri, Jan 11, 2019 at 03:14:08PM +0100, Alberto Garcia wrote: >> On Fri 11 Jan 2019 02:24:16 PM CET, Kevin Wolf wrote: >> >> >> The following QMP command leads to a crash when iothreads are used: >> >> >> >> >> >> { 'execute':

Re: [Qemu-devel] [PATCH] throttle-groups: fix restart coroutine iothread race

2019-01-14 Thread Stefan Hajnoczi
On Fri, Jan 11, 2019 at 03:14:08PM +0100, Alberto Garcia wrote: > On Fri 11 Jan 2019 02:24:16 PM CET, Kevin Wolf wrote: > >> >> The following QMP command leads to a crash when iothreads are used: > >> >> > >> >> { 'execute': 'device_del', 'arguments': {'id': 'data'} } > >> > > >> > How did you

Re: [Qemu-devel] [PATCH] throttle-groups: fix restart coroutine iothread race

2019-01-11 Thread Paolo Bonzini
On 09/01/19 12:01, Stefan Hajnoczi wrote: > g_free(data); > + > +tgm->restart_pending--; > +aio_wait_kick(); > } > > static void throttle_group_restart_queue(ThrottleGroupMember *tgm, bool > is_write) > @@ -430,6 +433,8 @@ static void >

Re: [Qemu-devel] [PATCH] throttle-groups: fix restart coroutine iothread race

2019-01-11 Thread Alberto Garcia
On Fri 11 Jan 2019 02:24:16 PM CET, Kevin Wolf wrote: >> >> The following QMP command leads to a crash when iothreads are used: >> >> >> >> { 'execute': 'device_del', 'arguments': {'id': 'data'} } >> > >> > How did you reproduce this? Do you have a test case? >> >> Ok, I finally reproduced it,

Re: [Qemu-devel] [PATCH] throttle-groups: fix restart coroutine iothread race

2019-01-11 Thread Kevin Wolf
Am 11.01.2019 um 14:19 hat Alberto Garcia geschrieben: > On Wed 09 Jan 2019 04:34:10 PM CET, Alberto Garcia wrote: > > On Wed 09 Jan 2019 12:01:44 PM CET, Stefan Hajnoczi wrote: > >> The following QMP command leads to a crash when iothreads are used: > >> > >> { 'execute': 'device_del',

Re: [Qemu-devel] [PATCH] throttle-groups: fix restart coroutine iothread race

2019-01-11 Thread Alberto Garcia
On Wed 09 Jan 2019 04:34:10 PM CET, Alberto Garcia wrote: > On Wed 09 Jan 2019 12:01:44 PM CET, Stefan Hajnoczi wrote: >> The following QMP command leads to a crash when iothreads are used: >> >> { 'execute': 'device_del', 'arguments': {'id': 'data'} } > > How did you reproduce this? Do you have

Re: [Qemu-devel] [PATCH] throttle-groups: fix restart coroutine iothread race

2019-01-09 Thread Alberto Garcia
On Wed 09 Jan 2019 12:01:44 PM CET, Stefan Hajnoczi wrote: > The following QMP command leads to a crash when iothreads are used: > > { 'execute': 'device_del', 'arguments': {'id': 'data'} } How did you reproduce this? Do you have a test case? Berto

Re: [Qemu-devel] [PATCH] throttle-groups: fix restart coroutine iothread race

2019-01-09 Thread Alberto Garcia
On Wed 09 Jan 2019 12:01:44 PM CET, Stefan Hajnoczi wrote: > The following QMP command leads to a crash when iothreads are used: > > { 'execute': 'device_del', 'arguments': {'id': 'data'} } I was trying to reproduce this and I found this crashing in master: $ qemu-system-x86_64 -enable-kvm