Re: [Qemu-devel] [PATCH] util/qemu-sockets: fix keep_alive handling in inet_connect_saddr

2019-09-25 Thread Eric Blake
On 9/25/19 6:33 AM, Vladimir Sementsov-Ogievskiy wrote: > 11.09.2019 15:08, Vladimir Sementsov-Ogievskiy wrote: >> 10.09.2019 16:59, Eric Blake wrote: >>> On 9/10/19 3:03 AM, Daniel P. Berrangé wrote: On Tue, Sep 10, 2019 at 10:59:43AM +0300, Vladimir Sementsov-Ogievskiy wrote: > In

Re: [Qemu-devel] [PATCH] util/qemu-sockets: fix keep_alive handling in inet_connect_saddr

2019-09-25 Thread Vladimir Sementsov-Ogievskiy
11.09.2019 15:08, Vladimir Sementsov-Ogievskiy wrote: > 10.09.2019 16:59, Eric Blake wrote: >> On 9/10/19 3:03 AM, Daniel P. Berrangé wrote: >>> On Tue, Sep 10, 2019 at 10:59:43AM +0300, Vladimir Sementsov-Ogievskiy >>> wrote: In "if (saddr->keep_alive) {" we may already be on error path, wit

Re: [Qemu-devel] [PATCH] util/qemu-sockets: fix keep_alive handling in inet_connect_saddr

2019-09-11 Thread Vladimir Sementsov-Ogievskiy
10.09.2019 16:59, Eric Blake wrote: > On 9/10/19 3:03 AM, Daniel P. Berrangé wrote: >> On Tue, Sep 10, 2019 at 10:59:43AM +0300, Vladimir Sementsov-Ogievskiy wrote: >>> In "if (saddr->keep_alive) {" we may already be on error path, with >>> invalid sock < 0. Fix it by returning error earlier. >>> >

Re: [Qemu-devel] [PATCH] util/qemu-sockets: fix keep_alive handling in inet_connect_saddr

2019-09-10 Thread Eric Blake
On 9/10/19 3:03 AM, Daniel P. Berrangé wrote: > On Tue, Sep 10, 2019 at 10:59:43AM +0300, Vladimir Sementsov-Ogievskiy wrote: >> In "if (saddr->keep_alive) {" we may already be on error path, with >> invalid sock < 0. Fix it by returning error earlier. >> >> Reported-by: Coverity (CID 1405300) >> S

Re: [Qemu-devel] [PATCH] util/qemu-sockets: fix keep_alive handling in inet_connect_saddr

2019-09-10 Thread Stefano Garzarella
On Tue, Sep 10, 2019 at 10:59:43AM +0300, Vladimir Sementsov-Ogievskiy wrote: > In "if (saddr->keep_alive) {" we may already be on error path, with > invalid sock < 0. Fix it by returning error earlier. > > Reported-by: Coverity (CID 1405300) > Suggested-by: Peter Maydell > Signed-off-by: Vladimi

Re: [Qemu-devel] [PATCH] util/qemu-sockets: fix keep_alive handling in inet_connect_saddr

2019-09-10 Thread Daniel P . Berrangé
On Tue, Sep 10, 2019 at 10:59:43AM +0300, Vladimir Sementsov-Ogievskiy wrote: > In "if (saddr->keep_alive) {" we may already be on error path, with > invalid sock < 0. Fix it by returning error earlier. > > Reported-by: Coverity (CID 1405300) > Suggested-by: Peter Maydell > Signed-off-by: Vladimi