Re: [Qemu-devel] [PATCH 0/3] tests: more test cases for virtio-9p

[Cornelia Huck]

On Thu, 15 Sep 2016 14:45:06 +0200
Greg Kurz  wrote:

> On Thu, 15 Sep 2016 10:41:38 +0200
> Cornelia Huck  wrote:
> 
> > On Fri, 09 Sep 2016 10:04:37 +0200
> > Greg Kurz  wrote:
> > 
> > > As with other virtio-* qtests, PC platform is assumed.
> > > 
> > > ---
> > > 
> > > Greg Kurz (3):
> > >   tests: virtio-9p: introduce start/stop functions
> > >   tests: virtio-9p: add basic configuration test
> > >   tests: virtio-9p: add basic transaction test
> > > 
> > > 
> > >  tests/Makefile.include |2 -
> > >  tests/virtio-9p-test.c |  179 
> > > 
> > >  2 files changed, 164 insertions(+), 17 deletions(-)
> > >   
> > 
> > I took a quick look and nothing bad jumped out at me, but that is
> > probably not saying much :/
> > 
> 
> Not much is a lot more than nothing, as it is usually the case with 9pfs
> patches that don't fix security issues or deprecated glibc calls ;)
> 
> Can this "nothing bad jumped out" be formalized into an Acked-by ?

Feel free:

Acked-by: Cornelia Huck 

Re: [Qemu-devel] [PATCH 0/3] tests: more test cases for virtio-9p

[Greg Kurz]

On Thu, 15 Sep 2016 10:41:38 +0200
Cornelia Huck  wrote:

> On Fri, 09 Sep 2016 10:04:37 +0200
> Greg Kurz  wrote:
> 
> > As with other virtio-* qtests, PC platform is assumed.
> > 
> > ---
> > 
> > Greg Kurz (3):
> >   tests: virtio-9p: introduce start/stop functions
> >   tests: virtio-9p: add basic configuration test
> >   tests: virtio-9p: add basic transaction test
> > 
> > 
> >  tests/Makefile.include |2 -
> >  tests/virtio-9p-test.c |  179 
> > 
> >  2 files changed, 164 insertions(+), 17 deletions(-)
> >   
> 
> I took a quick look and nothing bad jumped out at me, but that is
> probably not saying much :/
> 

Not much is a lot more than nothing, as it is usually the case with 9pfs
patches that don't fix security issues or deprecated glibc calls ;)

Can this "nothing bad jumped out" be formalized into an Acked-by ?

Thanks.

--
Greg

Re: [Qemu-devel] [PATCH 0/3] tests: more test cases for virtio-9p

[Cornelia Huck]

On Fri, 09 Sep 2016 10:04:37 +0200
Greg Kurz  wrote:

> As with other virtio-* qtests, PC platform is assumed.
> 
> ---
> 
> Greg Kurz (3):
>   tests: virtio-9p: introduce start/stop functions
>   tests: virtio-9p: add basic configuration test
>   tests: virtio-9p: add basic transaction test
> 
> 
>  tests/Makefile.include |2 -
>  tests/virtio-9p-test.c |  179 
> 
>  2 files changed, 164 insertions(+), 17 deletions(-)
> 

I took a quick look and nothing bad jumped out at me, but that is
probably not saying much :/

Re: [Qemu-devel] [PATCH 0/3] tests: more test cases for virtio-9p

[Greg Kurz]

Hi,

Even if I am maintainer for 9P stuff, I'm not sure I can send a pull request
for patches without at least an Acked-by... :-\

I plan to add true 9P functional tests in the future, but these are more
about the virtio device actually.

Any chances some virtio people can have a look and ack or nack ?

Cheers.

--
Greg

On Fri, 09 Sep 2016 10:04:37 +0200
Greg Kurz  wrote:
> As with other virtio-* qtests, PC platform is assumed.
> 
> ---
> 
> Greg Kurz (3):
>   tests: virtio-9p: introduce start/stop functions
>   tests: virtio-9p: add basic configuration test
>   tests: virtio-9p: add basic transaction test
> 
> 
>  tests/Makefile.include |2 -
>  tests/virtio-9p-test.c |  179 
> 
>  2 files changed, 164 insertions(+), 17 deletions(-)
> 
> --
> Greg
> 
> 

Re: [Qemu-devel] [PATCH 0/3] tests: more test cases for virtio-9p

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 147340827736.6462.8546871953640244651.stgit@bahia
Subject: [Qemu-devel] [PATCH 0/3] tests: more test cases for virtio-9p

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag] patchew/147340827736.6462.8546871953640244651.stgit@bahia 
-> patchew/147340827736.6462.8546871953640244651.stgit@bahia
Switched to a new branch 'test'
04c0f1e tests: virtio-9p: add basic transaction test
5194780 tests: virtio-9p: add basic configuration test
e762ebb tests: virtio-9p: introduce start/stop functions

=== OUTPUT BEGIN ===
Checking PATCH 1/3: tests: virtio-9p: introduce start/stop functions...
Checking PATCH 2/3: tests: virtio-9p: add basic configuration test...
ERROR: "foo* bar" should be "foo *bar"
#105: FILE: tests/virtio-9p-test.c:97:
+char* tag;

total: 1 errors, 0 warnings, 113 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 3/3: tests: virtio-9p: add basic transaction test...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@freelists.org