Re: [Qemu-devel] [PATCH 0/4] tcg: fix dirty bitmap race with MTTCG
Paolo Bonzini writes: > On 30/10/2018 13:21, Alex Bennée wrote: >> >> Paolo Bonzini writes: >> >>> This is a race that can happen when migrating TCG guests under load. >>> It was introduced by the change to run vCPUs outside the big QEMU >>> lock. >> >> Did this ever get re-spun? > > No, the issue is that *without MTTCG* all work items must come from the > same list, otherwise you get a deadlock. However the cleanup part of > the series was applied. I say there was: commit a8efa60633575a2ee4dbf807a71cb44d44b0e0f8 Author: Paolo Bonzini Date: Wed Nov 14 12:36:57 2018 +0100 cpus: run work items for all vCPUs if single-threaded Was this an effort to fix this problem? -- Alex Bennée
Re: [Qemu-devel] [PATCH 0/4] tcg: fix dirty bitmap race with MTTCG
On 30/10/2018 13:21, Alex Bennée wrote: > > Paolo Bonzini writes: > >> This is a race that can happen when migrating TCG guests under load. >> It was introduced by the change to run vCPUs outside the big QEMU >> lock. > > Did this ever get re-spun? No, the issue is that *without MTTCG* all work items must come from the same list, otherwise you get a deadlock. However the cleanup part of the series was applied. Paolo
Re: [Qemu-devel] [PATCH 0/4] tcg: fix dirty bitmap race with MTTCG
Paolo Bonzini writes: > This is a race that can happen when migrating TCG guests under load. > It was introduced by the change to run vCPUs outside the big QEMU > lock. Did this ever get re-spun? -- Alex Bennée
Re: [Qemu-devel] [PATCH 0/4] tcg: fix dirty bitmap race with MTTCG
* Paolo Bonzini (pbonz...@redhat.com) wrote: > This is a race that can happen when migrating TCG guests under load. > It was introduced by the change to run vCPUs outside the big QEMU lock. That does seem to fix the case I was seeing on x86; rmmod kvm-intel taskset -c 0 bash export QTEST_QEMU_BINARY=$PWD/x86_64-softmmu/qemu-system-x86_64 for S in $(seq 1 10); do ./tests/migration-test & done that would throw a : 'Memory content inconsistency' most times (may have to increase the 10 to get it to do it every time?) Dave > Paolo Bonzini (4): > memory: remove memory_region_test_and_clear_dirty > memory: hide memory_region_sync_dirty_bitmap behind > DirtyBitmapSnapshot > memory: introduce memory_global_after_dirty_log_sync > memory: unify loops to sync dirty log bitmap > > exec.c | 31 ++ > hw/display/cg3.c | 1 - > hw/display/exynos4210_fimd.c | 1 - > hw/display/framebuffer.c | 1 - > hw/display/g364fb.c | 1 - > hw/display/sm501.c | 1 - > hw/display/tcx.c | 2 -- > hw/display/vga.c | 6 > include/exec/memory.h| 47 +-- > memory.c | 76 > +--- > migration/ram.c | 1 + > 11 files changed, 76 insertions(+), 92 deletions(-) > > -- > 2.14.3 > -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
Re: [Qemu-devel] [PATCH 0/4] tcg: fix dirty bitmap race with MTTCG
* Paolo Bonzini (pbonz...@redhat.com) wrote: > This is a race that can happen when migrating TCG guests under load. > It was introduced by the change to run vCPUs outside the big QEMU lock. I can't yet confirming this fixes it; my test on the ARM box I was using are doing ... odd things - I've got some tests that aren't finishing under load (as opposed to crashing). Dave > Paolo Bonzini (4): > memory: remove memory_region_test_and_clear_dirty > memory: hide memory_region_sync_dirty_bitmap behind > DirtyBitmapSnapshot > memory: introduce memory_global_after_dirty_log_sync > memory: unify loops to sync dirty log bitmap > > exec.c | 31 ++ > hw/display/cg3.c | 1 - > hw/display/exynos4210_fimd.c | 1 - > hw/display/framebuffer.c | 1 - > hw/display/g364fb.c | 1 - > hw/display/sm501.c | 1 - > hw/display/tcx.c | 2 -- > hw/display/vga.c | 6 > include/exec/memory.h| 47 +-- > memory.c | 76 > +--- > migration/ram.c | 1 + > 11 files changed, 76 insertions(+), 92 deletions(-) > > -- > 2.14.3 > -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
Re: [Qemu-devel] [PATCH 0/4] tcg: fix dirty bitmap race with MTTCG
Hi, This series failed build test on ppcle host. Please find the details below. Type: series Message-id: 20180209104546.29401-1-pbonz...@redhat.com Subject: [Qemu-devel] [PATCH 0/4] tcg: fix dirty bitmap race with MTTCG === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a commit that has the patches applied on top of "base" # branch set -e echo "=== ENV ===" env echo "=== PACKAGES ===" rpm -qa echo "=== TEST BEGIN ===" INSTALL=$PWD/install BUILD=$PWD/build mkdir -p $BUILD $INSTALL SRC=$PWD cd $BUILD $SRC/configure --prefix=$INSTALL make -j100 # XXX: we need reliable clean up # make check -j100 V=1 make install === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20180209085755.30414-1-f4...@amsat.org -> patchew/20180209085755.30414-1-f4...@amsat.org * [new tag] patchew/20180209104546.29401-1-pbonz...@redhat.com -> patchew/20180209104546.29401-1-pbonz...@redhat.com Submodule 'capstone' (git://git.qemu.org/capstone.git) registered for path 'capstone' Submodule 'dtc' (git://git.qemu-project.org/dtc.git) registered for path 'dtc' Submodule 'roms/QemuMacDrivers' (git://git.qemu.org/QemuMacDrivers.git) registered for path 'roms/QemuMacDrivers' Submodule 'roms/SLOF' (git://git.qemu-project.org/SLOF.git) registered for path 'roms/SLOF' Submodule 'roms/ipxe' (git://git.qemu-project.org/ipxe.git) registered for path 'roms/ipxe' Submodule 'roms/openbios' (git://git.qemu-project.org/openbios.git) registered for path 'roms/openbios' Submodule 'roms/openhackware' (git://git.qemu-project.org/openhackware.git) registered for path 'roms/openhackware' Submodule 'roms/qemu-palcode' (git://github.com/rth7680/qemu-palcode.git) registered for path 'roms/qemu-palcode' Submodule 'roms/seabios' (git://git.qemu-project.org/seabios.git/) registered for path 'roms/seabios' Submodule 'roms/seabios-hppa' (git://github.com/hdeller/seabios-hppa.git) registered for path 'roms/seabios-hppa' Submodule 'roms/sgabios' (git://git.qemu-project.org/sgabios.git) registered for path 'roms/sgabios' Submodule 'roms/skiboot' (git://git.qemu.org/skiboot.git) registered for path 'roms/skiboot' Submodule 'roms/u-boot' (git://git.qemu-project.org/u-boot.git) registered for path 'roms/u-boot' Submodule 'roms/vgabios' (git://git.qemu-project.org/vgabios.git/) registered for path 'roms/vgabios' Submodule 'ui/keycodemapdb' (git://git.qemu.org/keycodemapdb.git) registered for path 'ui/keycodemapdb' Cloning into 'capstone'... Submodule path 'capstone': checked out '22ead3e0bfdb87516656453336160e0a37b066bf' Cloning into 'dtc'... Submodule path 'dtc': checked out 'e54388015af1fb4bf04d0bca99caba1074d9cc42' Cloning into 'roms/QemuMacDrivers'... Submodule path 'roms/QemuMacDrivers': checked out 'd4e7d7ac663fcb55f1b93575445fcbca372f17a7' Cloning into 'roms/SLOF'... Submodule path 'roms/SLOF': checked out 'fa981320a1e0968d6fc1b8de319723ff8212b337' Cloning into 'roms/ipxe'... Submodule path 'roms/ipxe': checked out '0600d3ae94f93efd10fc6b3c7420a9557a3a1670' Cloning into 'roms/openbios'... Submodule path 'roms/openbios': checked out 'b5c93acd14b7b3886c2c81d84cd18e666984a4c8' Cloning into 'roms/openhackware'... Submodule path 'roms/openhackware': checked out 'c559da7c8eec5e45ef1f67978827af6f0b9546f5' Cloning into 'roms/qemu-palcode'... Submodule path 'roms/qemu-palcode': checked out 'f3c7e44c70254975df2a00af39701eafbac4d471' Cloning into 'roms/seabios'... Submodule path 'roms/seabios': checked out '63451fca13c75870e1703eb3e20584d91179aebc' Cloning into 'roms/seabios-hppa'... Submodule path 'roms/seabios-hppa': checked out '649e6202b8d65d46c69f542b1380f840fbe8ab13' Cloning into 'roms/sgabios'... Submodule path 'roms/sgabios': checked out 'cbaee52287e5f32373181cff50a00b6c4ac9015a' Cloning into 'roms/skiboot'... Submodule path 'roms/skiboot': checked out 'e0ee24c27a172bcf482f6f2bc905e6211c134bcc' Cloning into 'roms/u-boot'... Submodule path 'roms/u-boot': checked out 'd85ca029f257b53a96da6c2fb421e78a003a9943' Cloning into 'roms/vgabios'... Submodule path 'roms/vgabios': checked out '19ea12c230ded95928ecaef0db47a82231c2e485' Cloning into 'ui/keycodemapdb'... Submodule path 'ui/keycodemapdb': checked out '6b3d716e2b6472eb7189d3220552280ef3d832ce' Switched to a new branch 'test' de8539b memory: unify loops to sync dirty log bitmap 61d5164 memory: introduce memory_global_after_dirty_log_sync 3514d84 memory: hide memory_region_sync_dirty_bitmap behind DirtyBitmapSnapshot 744fb47 memory: remove memory_region_test_and_clear_dirty === OUTPUT BEGIN === === ENV === XDG_SESSION_ID=180443 SHELL=/bin/sh USER=patchew PATCHEW=/home/patchew/patchew/patchew-cli -s http://patchew.org --nodebug PATH=/usr/bin:/bin PWD=/var/tmp/patchew-tester-tmp-p8m9az0i/src LANG=en_US.UTF-8 HOME=/home/patchew SHLVL=2 LOGNAME=patchew XDG_RUNTIME_DIR=/run/user/1000 _=/usr/bin/env === PACKAGES ===
Re: [Qemu-devel] [PATCH 0/4] tcg: fix dirty bitmap race with MTTCG
Hi, This series failed build test on ppcbe host. Please find the details below. Subject: [Qemu-devel] [PATCH 0/4] tcg: fix dirty bitmap race with MTTCG Message-id: 20180209104546.29401-1-pbonz...@redhat.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a commit that has the patches applied on top of "base" # branch set -e echo "=== ENV ===" env echo "=== PACKAGES ===" rpm -qa echo "=== TEST BEGIN ===" INSTALL=$PWD/install BUILD=$PWD/build mkdir -p $BUILD $INSTALL SRC=$PWD cd $BUILD $SRC/configure --prefix=$INSTALL make -j100 # XXX: we need reliable clean up # make check -j100 V=1 make install === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20180209085755.30414-1-f4...@amsat.org -> patchew/20180209085755.30414-1-f4...@amsat.org * [new tag] patchew/20180209104546.29401-1-pbonz...@redhat.com -> patchew/20180209104546.29401-1-pbonz...@redhat.com Submodule 'capstone' (git://git.qemu.org/capstone.git) registered for path 'capstone' Submodule 'dtc' (git://git.qemu-project.org/dtc.git) registered for path 'dtc' Submodule 'roms/QemuMacDrivers' (git://git.qemu.org/QemuMacDrivers.git) registered for path 'roms/QemuMacDrivers' Submodule 'roms/SLOF' (git://git.qemu-project.org/SLOF.git) registered for path 'roms/SLOF' Submodule 'roms/ipxe' (git://git.qemu-project.org/ipxe.git) registered for path 'roms/ipxe' Submodule 'roms/openbios' (git://git.qemu-project.org/openbios.git) registered for path 'roms/openbios' Submodule 'roms/openhackware' (git://git.qemu-project.org/openhackware.git) registered for path 'roms/openhackware' Submodule 'roms/qemu-palcode' (git://github.com/rth7680/qemu-palcode.git) registered for path 'roms/qemu-palcode' Submodule 'roms/seabios' (git://git.qemu-project.org/seabios.git/) registered for path 'roms/seabios' Submodule 'roms/seabios-hppa' (git://github.com/hdeller/seabios-hppa.git) registered for path 'roms/seabios-hppa' Submodule 'roms/sgabios' (git://git.qemu-project.org/sgabios.git) registered for path 'roms/sgabios' Submodule 'roms/skiboot' (git://git.qemu.org/skiboot.git) registered for path 'roms/skiboot' Submodule 'roms/u-boot' (git://git.qemu-project.org/u-boot.git) registered for path 'roms/u-boot' Submodule 'roms/vgabios' (git://git.qemu-project.org/vgabios.git/) registered for path 'roms/vgabios' Submodule 'ui/keycodemapdb' (git://git.qemu.org/keycodemapdb.git) registered for path 'ui/keycodemapdb' Cloning into 'capstone'... Submodule path 'capstone': checked out '22ead3e0bfdb87516656453336160e0a37b066bf' Cloning into 'dtc'... Submodule path 'dtc': checked out 'e54388015af1fb4bf04d0bca99caba1074d9cc42' Cloning into 'roms/QemuMacDrivers'... Submodule path 'roms/QemuMacDrivers': checked out 'd4e7d7ac663fcb55f1b93575445fcbca372f17a7' Cloning into 'roms/SLOF'... Submodule path 'roms/SLOF': checked out 'fa981320a1e0968d6fc1b8de319723ff8212b337' Cloning into 'roms/ipxe'... Submodule path 'roms/ipxe': checked out '0600d3ae94f93efd10fc6b3c7420a9557a3a1670' Cloning into 'roms/openbios'... Submodule path 'roms/openbios': checked out 'b5c93acd14b7b3886c2c81d84cd18e666984a4c8' Cloning into 'roms/openhackware'... Submodule path 'roms/openhackware': checked out 'c559da7c8eec5e45ef1f67978827af6f0b9546f5' Cloning into 'roms/qemu-palcode'... Submodule path 'roms/qemu-palcode': checked out 'f3c7e44c70254975df2a00af39701eafbac4d471' Cloning into 'roms/seabios'... Submodule path 'roms/seabios': checked out '63451fca13c75870e1703eb3e20584d91179aebc' Cloning into 'roms/seabios-hppa'... Submodule path 'roms/seabios-hppa': checked out '649e6202b8d65d46c69f542b1380f840fbe8ab13' Cloning into 'roms/sgabios'... Submodule path 'roms/sgabios': checked out 'cbaee52287e5f32373181cff50a00b6c4ac9015a' Cloning into 'roms/skiboot'... Submodule path 'roms/skiboot': checked out 'e0ee24c27a172bcf482f6f2bc905e6211c134bcc' Cloning into 'roms/u-boot'... Submodule path 'roms/u-boot': checked out 'd85ca029f257b53a96da6c2fb421e78a003a9943' Cloning into 'roms/vgabios'... Submodule path 'roms/vgabios': checked out '19ea12c230ded95928ecaef0db47a82231c2e485' Cloning into 'ui/keycodemapdb'... Submodule path 'ui/keycodemapdb': checked out '6b3d716e2b6472eb7189d3220552280ef3d832ce' Switched to a new branch 'test' de8539b memory: unify loops to sync dirty log bitmap 61d5164 memory: introduce memory_global_after_dirty_log_sync 3514d84 memory: hide memory_region_sync_dirty_bitmap behind DirtyBitmapSnapshot 744fb47 memory: remove memory_region_test_and_clear_dirty === OUTPUT BEGIN === === ENV === XDG_SESSION_ID=28310 SHELL=/bin/sh USER=patchew PATCHEW=./patchew-cli -s https://patchew.org PATH=/usr/bin:/bin PWD=/var/tmp/patchew-tester-tmp-01gfyrfk/src LANG=en_US.UTF-8 HOME=/home/patchew SHLVL=2 LOGNAME=patchew XDG_RUNTIME_DIR=/run/user/1000 _=/usr/bin/env === PACKAGES === telepathy-filesystem-0.0.2-6.el7.noarch
Re: [Qemu-devel] [PATCH 0/4] tcg: fix dirty bitmap race with MTTCG
Hi, This series failed build test on s390x host. Please find the details below. Type: series Message-id: 20180209104546.29401-1-pbonz...@redhat.com Subject: [Qemu-devel] [PATCH 0/4] tcg: fix dirty bitmap race with MTTCG === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a commit that has the patches applied on top of "base" # branch set -e echo "=== ENV ===" env echo "=== PACKAGES ===" rpm -qa echo "=== TEST BEGIN ===" CC=$HOME/bin/cc INSTALL=$PWD/install BUILD=$PWD/build echo -n "Using CC: " realpath $CC mkdir -p $BUILD $INSTALL SRC=$PWD cd $BUILD $SRC/configure --cc=$CC --prefix=$INSTALL make -j4 # XXX: we need reliable clean up # make check -j4 V=1 make install === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20180209104546.29401-1-pbonz...@redhat.com -> patchew/20180209104546.29401-1-pbonz...@redhat.com Switched to a new branch 'test' de8539b492 memory: unify loops to sync dirty log bitmap 61d5164b56 memory: introduce memory_global_after_dirty_log_sync 3514d84ddc memory: hide memory_region_sync_dirty_bitmap behind DirtyBitmapSnapshot 744fb47152 memory: remove memory_region_test_and_clear_dirty === OUTPUT BEGIN === === ENV === LANG=en_US.UTF-8 XDG_SESSION_ID=48386 USER=fam PWD=/var/tmp/patchew-tester-tmp-iref1x30/src HOME=/home/fam SHELL=/bin/sh SHLVL=2 PATCHEW=/home/fam/patchew/patchew-cli -s http://patchew.org --nodebug LOGNAME=fam DBUS_SESSION_BUS_ADDRESS=unix:path=/run/user/1012/bus XDG_RUNTIME_DIR=/run/user/1012 PATH=/usr/bin:/bin _=/usr/bin/env === PACKAGES === gpg-pubkey-873529b8-54e386ff glibc-debuginfo-common-2.24-10.fc25.s390x fedora-release-26-1.noarch dejavu-sans-mono-fonts-2.35-4.fc26.noarch xemacs-filesystem-21.5.34-22.20170124hgf412e9f093d4.fc26.noarch bash-4.4.12-7.fc26.s390x freetype-2.7.1-9.fc26.s390x libSM-1.2.2-5.fc26.s390x libmpc-1.0.2-6.fc26.s390x libaio-0.3.110-7.fc26.s390x libverto-0.2.6-7.fc26.s390x perl-Scalar-List-Utils-1.48-1.fc26.s390x iptables-libs-1.6.1-2.fc26.s390x perl-threads-shared-1.57-1.fc26.s390x p11-kit-trust-0.23.9-2.fc26.s390x tcl-8.6.6-2.fc26.s390x libxshmfence-1.2-4.fc26.s390x expect-5.45-23.fc26.s390x perl-Thread-Queue-3.12-1.fc26.noarch perl-encoding-2.19-6.fc26.s390x keyutils-1.5.10-1.fc26.s390x gmp-devel-6.1.2-4.fc26.s390x enchant-1.6.0-16.fc26.s390x net-snmp-libs-5.7.3-17.fc26.s390x python-gobject-base-3.24.1-1.fc26.s390x python3-distro-1.0.3-1.fc26.noarch python3-enchant-1.6.10-1.fc26.noarch python-lockfile-0.11.0-6.fc26.noarch python2-pyparsing-2.1.10-3.fc26.noarch python2-lxml-4.1.1-1.fc26.s390x librados2-10.2.7-2.fc26.s390x trousers-lib-0.3.13-7.fc26.s390x libpaper-1.1.24-14.fc26.s390x libdatrie-0.2.9-4.fc26.s390x libsoup-2.58.2-1.fc26.s390x passwd-0.79-9.fc26.s390x bind99-libs-9.9.10-3.P3.fc26.s390x python3-rpm-4.13.0.2-1.fc26.s390x mock-core-configs-27.4-1.fc26.noarch systemd-233-7.fc26.s390x virglrenderer-0.6.0-1.20170210git76b3da97b.fc26.s390x s390utils-ziomon-1.36.1-3.fc26.s390x s390utils-osasnmpd-1.36.1-3.fc26.s390x libXrandr-1.5.1-2.fc26.s390x libglvnd-glx-1.0.0-1.fc26.s390x texlive-ifxetex-svn19685.0.5-33.fc26.2.noarch texlive-psnfss-svn33946.9.2a-33.fc26.2.noarch texlive-dvipdfmx-def-svn40328-33.fc26.2.noarch texlive-natbib-svn20668.8.31b-33.fc26.2.noarch texlive-xdvi-bin-svn40750-33.20160520.fc26.2.s390x texlive-cm-svn32865.0-33.fc26.2.noarch texlive-beton-svn15878.0-33.fc26.2.noarch texlive-fpl-svn15878.1.002-33.fc26.2.noarch texlive-mflogo-svn38628-33.fc26.2.noarch texlive-texlive-docindex-svn41430-33.fc26.2.noarch texlive-luaotfload-bin-svn34647.0-33.20160520.fc26.2.noarch texlive-koma-script-svn41508-33.fc26.2.noarch texlive-pst-tree-svn24142.1.12-33.fc26.2.noarch texlive-breqn-svn38099.0.98d-33.fc26.2.noarch texlive-xetex-svn41438-33.fc26.2.noarch gstreamer1-plugins-bad-free-1.12.3-1.fc26.s390x xorg-x11-font-utils-7.5-33.fc26.s390x ghostscript-fonts-5.50-36.fc26.noarch libXext-devel-1.3.3-5.fc26.s390x libusbx-devel-1.0.21-2.fc26.s390x libglvnd-devel-1.0.0-1.fc26.s390x emacs-25.3-3.fc26.s390x alsa-lib-devel-1.1.4.1-1.fc26.s390x kbd-2.0.4-2.fc26.s390x dconf-0.26.0-2.fc26.s390x ccache-3.3.4-1.fc26.s390x glibc-static-2.25-12.fc26.s390x mc-4.8.19-5.fc26.s390x doxygen-1.8.13-9.fc26.s390x dpkg-1.18.24-1.fc26.s390x libtdb-1.3.13-1.fc26.s390x python2-pynacl-1.1.1-1.fc26.s390x nss-sysinit-3.34.0-1.0.fc26.s390x kernel-4.13.16-202.fc26.s390x perl-Filter-1.58-1.fc26.s390x python2-pip-9.0.1-11.fc26.noarch dnf-2.7.5-2.fc26.noarch pcre2-utf16-10.23-11.fc26.s390x glusterfs-devel-3.10.8-1.fc26.s390x sssd-common-1.16.0-4.fc26.s390x python2-sssdconfig-1.16.0-4.fc26.noarch acpica-tools-20171110-1.fc26.s390x glibc-debuginfo-2.24-10.fc25.s390x fedora-repos-26-1.noarch dejavu-fonts-common-2.35-4.fc26.noarch bind99-license-9.9.10-3.P3.fc26.noarch ncurses-libs-6.0-8.20170212.fc26.s390x libpng-1.6.28-2.fc26.s390x libICE-1.0.9-9.fc26.s390x kmod-24-1.fc26.s390x
