Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-04-01 Thread Alex Williamson
On Mon, 1 Apr 2019 04:40:03 -0400 Yan Zhao wrote: > On Mon, Apr 01, 2019 at 04:14:30PM +0800, Cornelia Huck wrote: > > On Wed, 27 Mar 2019 16:10:20 -0600 > > Alex Williamson wrote: > > > > > On Wed, 27 Mar 2019 20:18:54 + > > > "Dr. David Alan Gilbert" wrote: > > > > > > > * Zhao Yan

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-04-01 Thread Yan Zhao
On Mon, Apr 01, 2019 at 04:14:30PM +0800, Cornelia Huck wrote: > On Wed, 27 Mar 2019 16:10:20 -0600 > Alex Williamson wrote: > > > On Wed, 27 Mar 2019 20:18:54 + > > "Dr. David Alan Gilbert" wrote: > > > > > * Zhao Yan (yan.y.z...@intel.com) wrote: > > > > On Wed, Feb 20, 2019 at

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-04-01 Thread Cornelia Huck
On Wed, 27 Mar 2019 16:10:20 -0600 Alex Williamson wrote: > On Wed, 27 Mar 2019 20:18:54 + > "Dr. David Alan Gilbert" wrote: > > > * Zhao Yan (yan.y.z...@intel.com) wrote: > > > On Wed, Feb 20, 2019 at 07:42:42PM +0800, Cornelia Huck wrote: > > > > > > > > b) How do we detect if

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-03-31 Thread Zhao Yan
On Sat, Mar 30, 2019 at 10:14:07PM +0800, Alex Williamson wrote: > On Fri, 29 Mar 2019 19:10:50 -0400 > Zhao Yan wrote: > > > On Fri, Mar 29, 2019 at 10:26:39PM +0800, Alex Williamson wrote: > > > On Thu, 28 Mar 2019 22:47:04 -0400 > > > Zhao Yan wrote: > > > > > > > On Fri, Mar 29, 2019 at

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-03-30 Thread Alex Williamson
On Fri, 29 Mar 2019 19:10:50 -0400 Zhao Yan wrote: > On Fri, Mar 29, 2019 at 10:26:39PM +0800, Alex Williamson wrote: > > On Thu, 28 Mar 2019 22:47:04 -0400 > > Zhao Yan wrote: > > > > > On Fri, Mar 29, 2019 at 12:04:31AM +0800, Alex Williamson wrote: > > > > On Thu, 28 Mar 2019 10:21:38

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-03-29 Thread Zhao Yan
On Fri, Mar 29, 2019 at 10:26:39PM +0800, Alex Williamson wrote: > On Thu, 28 Mar 2019 22:47:04 -0400 > Zhao Yan wrote: > > > On Fri, Mar 29, 2019 at 12:04:31AM +0800, Alex Williamson wrote: > > > On Thu, 28 Mar 2019 10:21:38 +0100 > > > Erik Skultety wrote: > > > > > > > On Thu, Mar 28,

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-03-29 Thread Alex Williamson
On Thu, 28 Mar 2019 22:47:04 -0400 Zhao Yan wrote: > On Fri, Mar 29, 2019 at 12:04:31AM +0800, Alex Williamson wrote: > > On Thu, 28 Mar 2019 10:21:38 +0100 > > Erik Skultety wrote: > > > > > On Thu, Mar 28, 2019 at 04:36:03AM -0400, Zhao Yan wrote: > > > > hi Alex and Dave, > > > > Thanks

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-03-28 Thread Zhao Yan
On Fri, Mar 29, 2019 at 12:04:31AM +0800, Alex Williamson wrote: > On Thu, 28 Mar 2019 10:21:38 +0100 > Erik Skultety wrote: > > > On Thu, Mar 28, 2019 at 04:36:03AM -0400, Zhao Yan wrote: > > > hi Alex and Dave, > > > Thanks for your replies. > > > Please see my comments inline. > > > > > > On

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-03-28 Thread Alex Williamson
On Thu, 28 Mar 2019 10:21:38 +0100 Erik Skultety wrote: > On Thu, Mar 28, 2019 at 04:36:03AM -0400, Zhao Yan wrote: > > hi Alex and Dave, > > Thanks for your replies. > > Please see my comments inline. > > > > On Thu, Mar 28, 2019 at 06:10:20AM +0800, Alex Williamson wrote: > > > On Wed, 27

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-03-28 Thread Erik Skultety
On Thu, Mar 28, 2019 at 04:36:03AM -0400, Zhao Yan wrote: > hi Alex and Dave, > Thanks for your replies. > Please see my comments inline. > > On Thu, Mar 28, 2019 at 06:10:20AM +0800, Alex Williamson wrote: > > On Wed, 27 Mar 2019 20:18:54 + > > "Dr. David Alan Gilbert" wrote: > > > > > *

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-03-28 Thread Zhao Yan
hi Alex and Dave, Thanks for your replies. Please see my comments inline. On Thu, Mar 28, 2019 at 06:10:20AM +0800, Alex Williamson wrote: > On Wed, 27 Mar 2019 20:18:54 + > "Dr. David Alan Gilbert" wrote: > > > * Zhao Yan (yan.y.z...@intel.com) wrote: > > > On Wed, Feb 20, 2019 at

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-03-27 Thread Alex Williamson
On Wed, 27 Mar 2019 20:18:54 + "Dr. David Alan Gilbert" wrote: > * Zhao Yan (yan.y.z...@intel.com) wrote: > > On Wed, Feb 20, 2019 at 07:42:42PM +0800, Cornelia Huck wrote: > > > > > > > b) How do we detect if we're migrating from/to the wrong device > > > > > > > or > > > > > > >

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-03-27 Thread Dr. David Alan Gilbert
* Zhao Yan (yan.y.z...@intel.com) wrote: > On Wed, Feb 20, 2019 at 07:42:42PM +0800, Cornelia Huck wrote: > > > > > > b) How do we detect if we're migrating from/to the wrong device or > > > > > > version of device? Or say to a device with older firmware or > > > > > > perhaps > > > > > > a

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-03-27 Thread Zhao Yan
On Wed, Feb 20, 2019 at 07:42:42PM +0800, Cornelia Huck wrote: > > > > > b) How do we detect if we're migrating from/to the wrong device or > > > > > version of device? Or say to a device with older firmware or perhaps > > > > > a device that has less device memory ? > > > > Actually it's

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-03-17 Thread Zhao Yan
On Mon, Mar 18, 2019 at 11:09:04AM +0800, Alex Williamson wrote: > On Sun, 17 Mar 2019 22:51:27 -0400 > Zhao Yan wrote: > > > On Fri, Mar 15, 2019 at 10:24:02AM +0800, Alex Williamson wrote: > > > On Thu, 14 Mar 2019 19:05:06 -0400 > > > Zhao Yan wrote: > > > > > > > On Fri, Mar 15, 2019 at

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-03-17 Thread Alex Williamson
On Sun, 17 Mar 2019 22:51:27 -0400 Zhao Yan wrote: > On Fri, Mar 15, 2019 at 10:24:02AM +0800, Alex Williamson wrote: > > On Thu, 14 Mar 2019 19:05:06 -0400 > > Zhao Yan wrote: > > > > > On Fri, Mar 15, 2019 at 06:44:58AM +0800, Alex Williamson wrote: > > > > On Wed, 13 Mar 2019 21:12:22

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-03-17 Thread Zhao Yan
On Fri, Mar 15, 2019 at 10:24:02AM +0800, Alex Williamson wrote: > On Thu, 14 Mar 2019 19:05:06 -0400 > Zhao Yan wrote: > > > On Fri, Mar 15, 2019 at 06:44:58AM +0800, Alex Williamson wrote: > > > On Wed, 13 Mar 2019 21:12:22 -0400 > > > Zhao Yan wrote: > > > > > > > On Thu, Mar 14, 2019 at

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-03-14 Thread Alex Williamson
On Thu, 14 Mar 2019 19:05:06 -0400 Zhao Yan wrote: > On Fri, Mar 15, 2019 at 06:44:58AM +0800, Alex Williamson wrote: > > On Wed, 13 Mar 2019 21:12:22 -0400 > > Zhao Yan wrote: > > > > > On Thu, Mar 14, 2019 at 03:14:54AM +0800, Alex Williamson wrote: > > > > On Tue, 12 Mar 2019 21:13:01

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-03-14 Thread Zhao Yan
On Fri, Mar 15, 2019 at 06:44:58AM +0800, Alex Williamson wrote: > On Wed, 13 Mar 2019 21:12:22 -0400 > Zhao Yan wrote: > > > On Thu, Mar 14, 2019 at 03:14:54AM +0800, Alex Williamson wrote: > > > On Tue, 12 Mar 2019 21:13:01 -0400 > > > Zhao Yan wrote: > > > > > > > hi Alex > > > > Any

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-03-14 Thread Alex Williamson
On Wed, 13 Mar 2019 21:12:22 -0400 Zhao Yan wrote: > On Thu, Mar 14, 2019 at 03:14:54AM +0800, Alex Williamson wrote: > > On Tue, 12 Mar 2019 21:13:01 -0400 > > Zhao Yan wrote: > > > > > hi Alex > > > Any comments to the sequence below? > > > > > > Actaully we have some concerns and

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-03-13 Thread Zhao Yan
On Thu, Mar 14, 2019 at 03:14:54AM +0800, Alex Williamson wrote: > On Tue, 12 Mar 2019 21:13:01 -0400 > Zhao Yan wrote: > > > hi Alex > > Any comments to the sequence below? > > > > Actaully we have some concerns and suggestions to userspace-opaque migration > > data. > > > > 1. if data is

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-03-13 Thread Alex Williamson
On Tue, 12 Mar 2019 02:48:39 + "Tian, Kevin" wrote: > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > Sent: Tuesday, March 12, 2019 4:19 AM > > On Mon, 11 Mar 2019 02:33:11 + > > "Tian, Kevin" wrote: > > > [...] > > > > I think I've fully conceded any notion of

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-03-13 Thread Alex Williamson
On Tue, 12 Mar 2019 21:13:01 -0400 Zhao Yan wrote: > hi Alex > Any comments to the sequence below? > > Actaully we have some concerns and suggestions to userspace-opaque migration > data. > > 1. if data is opaque to userspace, kernel interface must be tightly bound to > migration. >e.g.

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-03-12 Thread Zhao Yan
hi Alex Any comments to the sequence below? Actaully we have some concerns and suggestions to userspace-opaque migration data. 1. if data is opaque to userspace, kernel interface must be tightly bound to migration. e.g. vendor driver has to know state (running + not logging) should not

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-03-11 Thread Zhao Yan
hi Alex thanks for your reply. So, if we choose migration data to be userspace opaque, do you think below sequence is the right behavior for vendor driver to follow: 1. initially LOGGING state is not set. If userspace calls GET_BUFFER to vendor driver, vendor driver should reject and return 0.

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-03-11 Thread Tian, Kevin
> From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Tuesday, March 12, 2019 4:19 AM > On Mon, 11 Mar 2019 02:33:11 + > "Tian, Kevin" wrote: > [...] > > I think I've fully conceded any notion of security by obscurity towards > opaque data already, but segregating types of

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-03-11 Thread Alex Williamson
On Mon, 11 Mar 2019 02:33:11 + "Tian, Kevin" wrote: > > From: Alex Williamson > > Sent: Saturday, March 9, 2019 6:03 AM > > > > On Fri, 8 Mar 2019 16:21:46 + > > "Dr. David Alan Gilbert" wrote: > > > > > * Alex Williamson (alex.william...@redhat.com) wrote: > > > > On Thu, 7 Mar

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-03-10 Thread Tian, Kevin
> From: Alex Williamson > Sent: Saturday, March 9, 2019 6:03 AM > > On Fri, 8 Mar 2019 16:21:46 + > "Dr. David Alan Gilbert" wrote: > > > * Alex Williamson (alex.william...@redhat.com) wrote: > > > On Thu, 7 Mar 2019 23:20:36 + > > > "Tian, Kevin" wrote: > > > > > > > > From: Alex

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-03-08 Thread Alex Williamson
On Fri, 8 Mar 2019 16:21:46 + "Dr. David Alan Gilbert" wrote: > * Alex Williamson (alex.william...@redhat.com) wrote: > > On Thu, 7 Mar 2019 23:20:36 + > > "Tian, Kevin" wrote: > > > > > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > > > Sent: Friday, March 8, 2019

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-03-08 Thread Dr. David Alan Gilbert
* Alex Williamson (alex.william...@redhat.com) wrote: > On Thu, 7 Mar 2019 23:20:36 + > "Tian, Kevin" wrote: > > > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > > Sent: Friday, March 8, 2019 1:44 AM > > > > > > > > > > > This kind of data needs to be saved /

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-03-08 Thread Alex Williamson
On Thu, 7 Mar 2019 23:20:36 + "Tian, Kevin" wrote: > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > Sent: Friday, March 8, 2019 1:44 AM > > > > > > > > > This kind of data needs to be saved / loaded in pre-copy and > > > > > stop-and-copy phase. > > > > >

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-03-07 Thread Tian, Kevin
> From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Friday, March 8, 2019 1:44 AM > > > > > > > This kind of data needs to be saved / loaded in pre-copy and > > > > stop-and-copy phase. > > > > The data of device memory is held in device memory region. > > >

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-03-07 Thread Alex Williamson
Hi Yan, Sorry for the delay, I've been on PTO... On Sun, 24 Feb 2019 21:22:56 -0500 Zhao Yan wrote: > On Thu, Feb 21, 2019 at 01:40:51PM -0700, Alex Williamson wrote: > > Hi Yan, > > > > Thanks for working on this! > > > > On Tue, 19 Feb 2019 16:50:54 +0800 > > Yan Zhao wrote: > > > > >

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-03-05 Thread Zhao Yan
hi Alex we still have some opens as below. could you kindly help review on that? :) Thanks Yan On Mon, Feb 25, 2019 at 10:22:56AM +0800, Zhao Yan wrote: > On Thu, Feb 21, 2019 at 01:40:51PM -0700, Alex Williamson wrote: > > Hi Yan, > > > > Thanks for working on this! > > > > On Tue, 19 Feb

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-02-24 Thread Zhao Yan
On Thu, Feb 21, 2019 at 01:40:51PM -0700, Alex Williamson wrote: > Hi Yan, > > Thanks for working on this! > > On Tue, 19 Feb 2019 16:50:54 +0800 > Yan Zhao wrote: > > > This patchset enables VFIO devices to have live migration capability. > > Currently it does not support post-copy phase. > >

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-02-21 Thread Alex Williamson
Hi Yan, Thanks for working on this! On Tue, 19 Feb 2019 16:50:54 +0800 Yan Zhao wrote: > This patchset enables VFIO devices to have live migration capability. > Currently it does not support post-copy phase. > > It follows Alex's comments on last version of VFIO live migration patches, >

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-02-21 Thread Dr. David Alan Gilbert
* Zhao Yan (yan.y.z...@intel.com) wrote: > On Wed, Feb 20, 2019 at 11:01:43AM +, Dr. David Alan Gilbert wrote: > > * Zhao Yan (yan.y.z...@intel.com) wrote: > > > On Tue, Feb 19, 2019 at 11:32:13AM +, Dr. David Alan Gilbert wrote: > > > > * Yan Zhao (yan.y.z...@intel.com) wrote: > > > > >

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-02-20 Thread Gonglei (Arei)
> > > > > -Original Message- > > > From: Zhao Yan [mailto:yan.y.z...@intel.com] > > > Sent: Thursday, February 21, 2019 10:05 AM > > > To: Gonglei (Arei) > > > Cc: alex.william...@redhat.com; qemu-devel@nongnu.org; > > > intel-gvt-...@lists.freedesktop.org; zhengxiao...@alibaba-inc.com; >

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-02-20 Thread Gonglei (Arei)
> -Original Message- > From: Zhao Yan [mailto:yan.y.z...@intel.com] > Sent: Thursday, February 21, 2019 12:08 PM > To: Gonglei (Arei) > Cc: c...@nvidia.com; k...@vger.kernel.org; a...@ozlabs.ru; > zhengxiao...@alibaba-inc.com; shuangtai@alibaba-inc.com; > qemu-devel@nongnu.org;

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-02-20 Thread Zhao Yan
On Thu, Feb 21, 2019 at 03:16:45AM +, Gonglei (Arei) wrote: > > > > > -Original Message- > > From: Zhao Yan [mailto:yan.y.z...@intel.com] > > Sent: Thursday, February 21, 2019 10:05 AM > > To: Gonglei (Arei) > > Cc: alex.william...@redhat.com; qemu-devel@nongnu.org; > >

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-02-20 Thread Zhao Yan
On Thu, Feb 21, 2019 at 03:33:24AM +, Gonglei (Arei) wrote: > > > -Original Message- > > From: Zhao Yan [mailto:yan.y.z...@intel.com] > > Sent: Thursday, February 21, 2019 9:59 AM > > To: Gonglei (Arei) > > Cc: alex.william...@redhat.com; qemu-devel@nongnu.org; > >

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-02-20 Thread Gonglei (Arei)
> -Original Message- > From: Zhao Yan [mailto:yan.y.z...@intel.com] > Sent: Thursday, February 21, 2019 9:59 AM > To: Gonglei (Arei) > Cc: alex.william...@redhat.com; qemu-devel@nongnu.org; > intel-gvt-...@lists.freedesktop.org; zhengxiao...@alibaba-inc.com; > yi.l@intel.com;

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-02-20 Thread Gonglei (Arei)
> -Original Message- > From: Zhao Yan [mailto:yan.y.z...@intel.com] > Sent: Thursday, February 21, 2019 10:05 AM > To: Gonglei (Arei) > Cc: alex.william...@redhat.com; qemu-devel@nongnu.org; > intel-gvt-...@lists.freedesktop.org; zhengxiao...@alibaba-inc.com; > yi.l@intel.com;

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-02-20 Thread Zhao Yan
> > > > > 5) About log sync, why not register log_global_start/stop in > > vfio_memory_listener? > > > > > > > > seems log_global_start/stop cannot be iterately called in pre-copy phase? > > for dirty pages in system memory, it's better to transfer dirty data > > iteratively to reduce down time,

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-02-20 Thread Zhao Yan
On Thu, Feb 21, 2019 at 01:35:43AM +, Gonglei (Arei) wrote: > > > > -Original Message- > > From: Zhao Yan [mailto:yan.y.z...@intel.com] > > Sent: Thursday, February 21, 2019 8:25 AM > > To: Gonglei (Arei) > > Cc: alex.william...@redhat.com; qemu-devel@nongnu.org; > >

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-02-20 Thread Gonglei (Arei)
> -Original Message- > From: Zhao Yan [mailto:yan.y.z...@intel.com] > Sent: Thursday, February 21, 2019 8:25 AM > To: Gonglei (Arei) > Cc: alex.william...@redhat.com; qemu-devel@nongnu.org; > intel-gvt-...@lists.freedesktop.org; zhengxiao...@alibaba-inc.com; > yi.l@intel.com;

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-02-20 Thread Zhao Yan
On Wed, Feb 20, 2019 at 11:01:43AM +, Dr. David Alan Gilbert wrote: > * Zhao Yan (yan.y.z...@intel.com) wrote: > > On Tue, Feb 19, 2019 at 11:32:13AM +, Dr. David Alan Gilbert wrote: > > > * Yan Zhao (yan.y.z...@intel.com) wrote: > > > > This patchset enables VFIO devices to have live

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-02-20 Thread Zhao Yan
On Wed, Feb 20, 2019 at 11:56:01AM +, Gonglei (Arei) wrote: > Hi yan, > > Thanks for your work. > > I have some suggestions or questions: > > 1) Would you add msix mode support,? if not, pls add a check in > vfio_pci_save_config(), likes Nvidia's solution. ok. > 2) We should start vfio

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-02-20 Thread Gonglei (Arei)
> -Original Message- > From: Cornelia Huck [mailto:coh...@redhat.com] > Sent: Wednesday, February 20, 2019 7:43 PM > To: Gonglei (Arei) > Cc: Dr. David Alan Gilbert ; Zhao Yan > ; c...@nvidia.com; k...@vger.kernel.org; > a...@ozlabs.ru; zhengxiao...@alibaba-inc.com;

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-02-20 Thread Gonglei (Arei)
Hi yan, Thanks for your work. I have some suggestions or questions: 1) Would you add msix mode support,? if not, pls add a check in vfio_pci_save_config(), likes Nvidia's solution. 2) We should start vfio devices before vcpu resumes, so we can't rely on vm start change handler completely. 3)

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-02-20 Thread Cornelia Huck
On Wed, 20 Feb 2019 11:28:46 + "Gonglei (Arei)" wrote: > > -Original Message- > > From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com] > > Sent: Wednesday, February 20, 2019 7:02 PM > > To: Zhao Yan > > Cc: c...@nvidia.com; k...@vger.kernel.org; a...@ozlabs.ru; > >

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-02-20 Thread Gonglei (Arei)
> -Original Message- > From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com] > Sent: Wednesday, February 20, 2019 7:02 PM > To: Zhao Yan > Cc: c...@nvidia.com; k...@vger.kernel.org; a...@ozlabs.ru; > zhengxiao...@alibaba-inc.com; shuangtai@alibaba-inc.com; >

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-02-20 Thread Dr. David Alan Gilbert
* Zhao Yan (yan.y.z...@intel.com) wrote: > On Tue, Feb 19, 2019 at 11:32:13AM +, Dr. David Alan Gilbert wrote: > > * Yan Zhao (yan.y.z...@intel.com) wrote: > > > This patchset enables VFIO devices to have live migration capability. > > > Currently it does not support post-copy phase. > > > >

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-02-19 Thread Zhao Yan
On Tue, Feb 19, 2019 at 11:32:13AM +, Dr. David Alan Gilbert wrote: > * Yan Zhao (yan.y.z...@intel.com) wrote: > > This patchset enables VFIO devices to have live migration capability. > > Currently it does not support post-copy phase. > > > > It follows Alex's comments on last version of

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-02-19 Thread Dr. David Alan Gilbert
* Yan Zhao (yan.y.z...@intel.com) wrote: > This patchset enables VFIO devices to have live migration capability. > Currently it does not support post-copy phase. > > It follows Alex's comments on last version of VFIO live migration patches, > including device states, VFIO device state region