Re: [Qemu-devel] [PATCH 00/26] trivial: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)

2016-09-19 Thread Cornelia Huck
On Fri, 16 Sep 2016 16:45:06 +0100 Peter Maydell wrote: > On 16 September 2016 at 16:39, Daniel P. Berrange wrote: > > On Fri, Sep 16, 2016 at 03:47:37PM +0100, Peter Maydell wrote: > >> On 16 September 2016 at 14:55, Laurent Vivier wrote: > >> > This series is the result of coccinelle patch >

Re: [Qemu-devel] [PATCH 00/26] trivial: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)

2016-09-19 Thread Peter Maydell
On 19 September 2016 at 10:46, Laurent Vivier wrote: > --- > Portability note: Some non-POSIX systems use different conventions for > exit status values. For greater portability, you can use the macros > EXIT_SUCCESS and EXIT_FAIL

Re: [Qemu-devel] [PATCH 00/26] trivial: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)

2016-09-19 Thread Laurent Vivier
On 16/09/2016 17:45, Peter Maydell wrote: > On 16 September 2016 at 16:39, Daniel P. Berrange wrote: >> On Fri, Sep 16, 2016 at 03:47:37PM +0100, Peter Maydell wrote: >>> On 16 September 2016 at 14:55, Laurent Vivier wrote: This series is the result of coccinelle patch scripts/coccine

Re: [Qemu-devel] [PATCH 00/26] trivial: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)

2016-09-19 Thread Markus Armbruster
Peter Maydell writes: > On 16 September 2016 at 16:39, Daniel P. Berrange wrote: >> On Fri, Sep 16, 2016 at 03:47:37PM +0100, Peter Maydell wrote: >>> On 16 September 2016 at 14:55, Laurent Vivier wrote: >>> > This series is the result of coccinelle patch >>> > scripts/coccinelle/exit.cocci >>>

Re: [Qemu-devel] [PATCH 00/26] trivial: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)

2016-09-16 Thread Peter Maydell
On 16 September 2016 at 16:39, Daniel P. Berrange wrote: > On Fri, Sep 16, 2016 at 03:47:37PM +0100, Peter Maydell wrote: >> On 16 September 2016 at 14:55, Laurent Vivier wrote: >> > This series is the result of coccinelle patch >> > scripts/coccinelle/exit.cocci >> > provided by the first patch

Re: [Qemu-devel] [PATCH 00/26] trivial: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)

2016-09-16 Thread Daniel P. Berrange
On Fri, Sep 16, 2016 at 03:47:37PM +0100, Peter Maydell wrote: > On 16 September 2016 at 14:55, Laurent Vivier wrote: > > This series is the result of coccinelle patch > > scripts/coccinelle/exit.cocci > > provided by the first patch of the series. > > > > It replaces exit(0) by exit(EXIT_SUCCESS)

Re: [Qemu-devel] [PATCH 00/26] trivial: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)

2016-09-16 Thread Eric Blake
On 09/16/2016 10:27 AM, Daniel P. Berrange wrote: > On Fri, Sep 16, 2016 at 03:55:51PM +0200, Laurent Vivier wrote: >> This series is the result of coccinelle patch >> scripts/coccinelle/exit.cocci >> provided by the first patch of the series. >> >> It replaces exit(0) by exit(EXIT_SUCCESS) >> and

Re: [Qemu-devel] [PATCH 00/26] trivial: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)

2016-09-16 Thread Daniel P. Berrange
On Fri, Sep 16, 2016 at 03:55:51PM +0200, Laurent Vivier wrote: > This series is the result of coccinelle patch > scripts/coccinelle/exit.cocci > provided by the first patch of the series. > > It replaces exit(0) by exit(EXIT_SUCCESS) > and exit(1) by exit(EXIT_FAILURE). Some places use '_exit' a

Re: [Qemu-devel] [PATCH 00/26] trivial: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)

2016-09-16 Thread Peter Maydell
On 16 September 2016 at 14:55, Laurent Vivier wrote: > This series is the result of coccinelle patch > scripts/coccinelle/exit.cocci > provided by the first patch of the series. > > It replaces exit(0) by exit(EXIT_SUCCESS) > and exit(1) by exit(EXIT_FAILURE). > > All other exit() are not modified

Re: [Qemu-devel] [PATCH 00/26] trivial: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)

2016-09-16 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1474034177-17663-1-git-send-email-lviv...@redhat.com Subject: [Qemu-devel] [PATCH 00/26] trivial: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE) === TEST SCRIPT BEGIN === #!/