Re: [Qemu-devel] [PATCH 03/12] migration: fix counting xbzrle cache_miss_rate
* guangrong.x...@gmail.com (guangrong.x...@gmail.com) wrote: > From: Xiao Guangrong > > Sync up xbzrle_cache_miss_prev only after migration iteration goes > forward > > Signed-off-by: Xiao Guangrong This patch (not the whole set) queued > --- > migration/ram.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/migration/ram.c b/migration/ram.c > index dbf24d8c87..dd1283dd45 100644 > --- a/migration/ram.c > +++ b/migration/ram.c > @@ -1189,9 +1189,9 @@ static void migration_bitmap_sync(RAMState *rs) > (double)(xbzrle_counters.cache_miss - > rs->xbzrle_cache_miss_prev) / > (rs->iterations - rs->iterations_prev); > +rs->xbzrle_cache_miss_prev = xbzrle_counters.cache_miss; > } > rs->iterations_prev = rs->iterations; > -rs->xbzrle_cache_miss_prev = xbzrle_counters.cache_miss; > } > > /* reset period counters */ > -- > 2.14.4 > > -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
Re: [Qemu-devel] [PATCH 03/12] migration: fix counting xbzrle cache_miss_rate
* guangrong.x...@gmail.com (guangrong.x...@gmail.com) wrote: > From: Xiao Guangrong > > Sync up xbzrle_cache_miss_prev only after migration iteration goes > forward > > Signed-off-by: Xiao Guangrong Yeh, I think you're right. Reviewed-by: Dr. David Alan Gilbert > --- > migration/ram.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/migration/ram.c b/migration/ram.c > index dbf24d8c87..dd1283dd45 100644 > --- a/migration/ram.c > +++ b/migration/ram.c > @@ -1189,9 +1189,9 @@ static void migration_bitmap_sync(RAMState *rs) > (double)(xbzrle_counters.cache_miss - > rs->xbzrle_cache_miss_prev) / > (rs->iterations - rs->iterations_prev); > +rs->xbzrle_cache_miss_prev = xbzrle_counters.cache_miss; > } > rs->iterations_prev = rs->iterations; > -rs->xbzrle_cache_miss_prev = xbzrle_counters.cache_miss; > } > > /* reset period counters */ > -- > 2.14.4 > -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
