Re: [Qemu-devel] [PATCH 03/14] qdev: add qdev_add_properties

2012-05-01 Thread Anthony Liguori
On 05/01/2012 05:12 PM, Paolo Bonzini wrote: Il 02/05/2012 00:01, Anthony Liguori ha scritto: There's magic in the qdev layer now to decide whether a Property in the array of properties becomes a legacy or static property (it's only ever exposed as one type). I don't think this is true: a leg

Re: [Qemu-devel] [PATCH 03/14] qdev: add qdev_add_properties

2012-05-01 Thread Paolo Bonzini
Il 02/05/2012 00:01, Anthony Liguori ha scritto: > > There's magic in the qdev layer now to decide whether a Property in the > array of properties becomes a legacy or static property (it's only ever > exposed as one type). I don't think this is true: a legacy property always has a static counterp

Re: [Qemu-devel] [PATCH 03/14] qdev: add qdev_add_properties

2012-05-01 Thread Anthony Liguori
On 05/01/2012 03:57 PM, Peter Maydell wrote: On 1 May 2012 21:48, Anthony Liguori wrote: Legacy properties != static properties. qdev_add_properties adds both legacy and static properties. I'm happy to put static properties into object but not legacy properties. So, er, how are you defining

Re: [Qemu-devel] [PATCH 03/14] qdev: add qdev_add_properties

2012-05-01 Thread Andreas Färber
Am 01.05.2012 22:37, schrieb Anthony Liguori: > On 05/01/2012 02:05 PM, Andreas Färber wrote: >> Am 01.05.2012 20:18, schrieb Anthony Liguori: >>> This allows a base class to easily add properties. >>> >>> Signed-off-by: Anthony Liguori >> >> Implementation looks okay but /me not so happy with it:

Re: [Qemu-devel] [PATCH 03/14] qdev: add qdev_add_properties

2012-05-01 Thread Peter Maydell
On 1 May 2012 21:48, Anthony Liguori wrote: > Legacy properties != static properties. > > qdev_add_properties adds both legacy and static properties.  I'm happy to > put static properties into object but not legacy properties. So, er, how are you defining legacy and static properties? I would hav

Re: [Qemu-devel] [PATCH 03/14] qdev: add qdev_add_properties

2012-05-01 Thread Anthony Liguori
On 05/01/2012 03:43 PM, Andreas Färber wrote: Am 01.05.2012 22:37, schrieb Anthony Liguori: On 05/01/2012 02:05 PM, Andreas Färber wrote: Am 01.05.2012 20:18, schrieb Anthony Liguori: This allows a base class to easily add properties. Signed-off-by: Anthony Liguori Implementation looks okay

Re: [Qemu-devel] [PATCH 03/14] qdev: add qdev_add_properties

2012-05-01 Thread Anthony Liguori
On 05/01/2012 02:05 PM, Andreas Färber wrote: Am 01.05.2012 20:18, schrieb Anthony Liguori: This allows a base class to easily add properties. Signed-off-by: Anthony Liguori Implementation looks okay but /me not so happy with it: This conflicts with the move of the qdev static property infras

Re: [Qemu-devel] [PATCH 03/14] qdev: add qdev_add_properties

2012-05-01 Thread Andreas Färber
Am 01.05.2012 20:18, schrieb Anthony Liguori: > This allows a base class to easily add properties. > > Signed-off-by: Anthony Liguori Implementation looks okay but /me not so happy with it: This conflicts with the move of the qdev static property infrastructure from DeviceState to Object. Consi