Re: [Qemu-devel] [PATCH 05/10] linux-user: init_guest_space: Clarify page alignment logic

[Laurent Vivier]

Le 28/12/2017 à 19:08, Luke Shumaker a écrit :
> From: Luke Shumaker 
> 
> There are 3 parts to this change:
>  - Add a comment showing the relative sizes and positions of the blocks of
>memory
>  - introduce and use new aligned_{start,size} instead of adjusting
>real_{start_size}
>  - When we clean up (on failure), munmap(real_start, real_size) instead of
>munmap(aligned_start, aligned_size).  It *shouldn't* make any
>difference, but I will admit that this does mean we are making the
>syscall with different values, so this isn't quite a no-op patch.
> 
> Signed-off-by: Luke Shumaker 
> ---
>  linux-user/elfload.c | 43 +--
>  1 file changed, 33 insertions(+), 10 deletions(-)
> 

Applied to my 'linux-user-for-2.12' branch.

Thanks,
Laurent

Re: [Qemu-devel] [PATCH 05/10] linux-user: init_guest_space: Clarify page alignment logic

[Peter Maydell]

On 28 December 2017 at 18:08, Luke Shumaker  wrote:
> From: Luke Shumaker 
>
> There are 3 parts to this change:
>  - Add a comment showing the relative sizes and positions of the blocks of
>memory
>  - introduce and use new aligned_{start,size} instead of adjusting
>real_{start_size}
>  - When we clean up (on failure), munmap(real_start, real_size) instead of
>munmap(aligned_start, aligned_size).  It *shouldn't* make any
>difference, but I will admit that this does mean we are making the
>syscall with different values, so this isn't quite a no-op patch.
>
> Signed-off-by: Luke Shumaker 
> ---
>  linux-user/elfload.c | 43 +--
>  1 file changed, 33 insertions(+), 10 deletions(-)

Reviewed-by: Peter Maydell 

thanks
-- PMM