Re: [Qemu-devel] [PATCH 07/22] qcow2-bitmap: introduce auto-loading bitmaps

2016-10-21 Thread Max Reitz
On 20.10.2016 14:22, Vladimir Sementsov-Ogievskiy wrote: > On 01.10.2016 19:26, Max Reitz wrote: >> On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: >>> Auto loading bitmaps are bitmaps in Qcow2, with AUTO flag set. They are > > [...] > >> diff --git a/block/qcow2.c b/block/qcow2.c >> ind

Re: [Qemu-devel] [PATCH 07/22] qcow2-bitmap: introduce auto-loading bitmaps

2016-10-21 Thread Max Reitz
On 21.10.2016 13:59, Vladimir Sementsov-Ogievskiy wrote: > 07.10.2016 22:25, Max Reitz пишет: >> On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: >>> Auto loading bitmaps are bitmaps in Qcow2, with AUTO flag set. They are >>> loaded at image open and becomes BdrvDirtyBitmap's for correspond

Re: [Qemu-devel] [PATCH 07/22] qcow2-bitmap: introduce auto-loading bitmaps

2016-10-21 Thread Vladimir Sementsov-Ogievskiy
07.10.2016 22:25, Max Reitz пишет: On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: Auto loading bitmaps are bitmaps in Qcow2, with AUTO flag set. They are loaded at image open and becomes BdrvDirtyBitmap's for corresponding drive. These bitmaps are deleted from Qcow2 image after loading

Re: [Qemu-devel] [PATCH 07/22] qcow2-bitmap: introduce auto-loading bitmaps

2016-10-20 Thread Vladimir Sementsov-Ogievskiy
On 01.10.2016 19:26, Max Reitz wrote: On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: Auto loading bitmaps are bitmaps in Qcow2, with AUTO flag set. They are [...] diff --git a/block/qcow2.c b/block/qcow2.c index 08c4ef9..02ec224 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -21

Re: [Qemu-devel] [PATCH 07/22] qcow2-bitmap: introduce auto-loading bitmaps

2016-10-15 Thread Vladimir Sementsov-Ogievskiy
On 15.10.2016 20:03, Max Reitz wrote: On 14.10.2016 20:44, Vladimir Sementsov-Ogievskiy wrote: On 01.10.2016 19:26, Max Reitz wrote: On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: Auto loading bitmaps are bitmaps in Qcow2, with AUTO flag set. They are ... +goto fail; +

Re: [Qemu-devel] [PATCH 07/22] qcow2-bitmap: introduce auto-loading bitmaps

2016-10-15 Thread Max Reitz
On 14.10.2016 20:44, Vladimir Sementsov-Ogievskiy wrote: > On 01.10.2016 19:26, Max Reitz wrote: >> On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: >>> Auto loading bitmaps are bitmaps in Qcow2, with AUTO flag set. They are > > ... > >> +goto fail; >> +} >> + >> +/* loop

Re: [Qemu-devel] [PATCH 07/22] qcow2-bitmap: introduce auto-loading bitmaps

2016-10-14 Thread Vladimir Sementsov-Ogievskiy
On 01.10.2016 19:26, Max Reitz wrote: On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: Auto loading bitmaps are bitmaps in Qcow2, with AUTO flag set. They are ... +goto fail; +} + +/* loop is safe because next entry offset is calculated after conversion to Should it b

Re: [Qemu-devel] [PATCH 07/22] qcow2-bitmap: introduce auto-loading bitmaps

2016-10-07 Thread Max Reitz
On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: > Auto loading bitmaps are bitmaps in Qcow2, with AUTO flag set. They are > loaded at image open and becomes BdrvDirtyBitmap's for corresponding > drive. These bitmaps are deleted from Qcow2 image after loading to avoid > conflicts. > > Extr

Re: [Qemu-devel] [PATCH 07/22] qcow2-bitmap: introduce auto-loading bitmaps

2016-10-01 Thread Max Reitz
On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: > Auto loading bitmaps are bitmaps in Qcow2, with AUTO flag set. They are *with the AUTO flag set > loaded at image open and becomes BdrvDirtyBitmap's for corresponding "loaded when the image is opened and become BdrvDirtyBitmaps for the c