Re: [Qemu-devel] [PATCH 09/13] nbd: don't change socket block during negotiate

2013-12-01 Thread Marc-André Lureau
- Original Message - Il 30/11/2013 16:49, Marc-André Lureau ha scritto: So you suggest this block/unblock: (I haven't reviewed all callers of unix_connect_opts(), I am not sure that's what you meant) Other option would be to move the nonblock to unix_socket_outgoing. diff

Re: [Qemu-devel] [PATCH 09/13] nbd: don't change socket block during negotiate

2013-11-30 Thread Paolo Bonzini
Il 30/11/2013 16:49, Marc-André Lureau ha scritto: So you suggest this block/unblock: (I haven't reviewed all callers of unix_connect_opts(), I am not sure that's what you meant) Other option would be to move the nonblock to unix_socket_outgoing. diff --git a/block/nbd-client.c

Re: [Qemu-devel] [PATCH 09/13] nbd: don't change socket block during negotiate

2013-11-29 Thread Paolo Bonzini
Il 29/11/2013 15:58, Marc-André Lureau ha scritto: From: Marc-André Lureau marcandre.lur...@redhat.com The caller might handle non-blocking using coroutine. Leave the choice to the caller to use a blocking or non-blocking negotiate. Signed-off-by: Marc-André Lureau