Re: [Qemu-devel] [PATCH 1/1] virtio-ccw: clean up notify

[Cornelia Huck]

On Wed, 16 May 2018 15:27:57 +0200
Halil Pasic  wrote:

> Coverity recently started complaining about virtio_ccw_notify().  Turns
> out, there is a couple of things that can be cleaned up.  Let's clean!
> 
> Reported-by: Peter Maydell 
> Fixes: CID 1390619
> Signed-off-by: Halil Pasic 
> ---
>  hw/s390x/virtio-ccw.c | 13 +
>  1 file changed, 9 insertions(+), 4 deletions(-)

Thanks, applied.

Re: [Qemu-devel] [PATCH 1/1] virtio-ccw: clean up notify

[Halil Pasic]

On 05/17/2018 05:26 PM, Cornelia Huck wrote:

On Wed, 16 May 2018 15:27:57 +0200
Halil Pasic  wrote:


Coverity recently started complaining about virtio_ccw_notify().  Turns
out, there is a couple of things that can be cleaned up.  Let's clean!


Changes look good to me.

I wanted to come up with a better patch description, but failed (well,
I did not try much.) So I'm inclined to merge this as-is.



I also gave up on a good patch description real soon. The patch does not do
a single thing, but I don't think splitting it up would make things better.
So I was like: the changes are pretty straight-forward, and the commit message
should just hint refactoring.

Thanks!

Halil




Reported-by: Peter Maydell 
Fixes: CID 1390619
Signed-off-by: Halil Pasic 
---
  hw/s390x/virtio-ccw.c | 13 +
  1 file changed, 9 insertions(+), 4 deletions(-)

Re: [Qemu-devel] [PATCH 1/1] virtio-ccw: clean up notify

[Cornelia Huck]

On Wed, 16 May 2018 15:27:57 +0200
Halil Pasic  wrote:

> Coverity recently started complaining about virtio_ccw_notify().  Turns
> out, there is a couple of things that can be cleaned up.  Let's clean!

Changes look good to me.

I wanted to come up with a better patch description, but failed (well,
I did not try much.) So I'm inclined to merge this as-is.

> 
> Reported-by: Peter Maydell 
> Fixes: CID 1390619
> Signed-off-by: Halil Pasic 
> ---
>  hw/s390x/virtio-ccw.c | 13 +
>  1 file changed, 9 insertions(+), 4 deletions(-)