Re: [Qemu-devel] [PATCH 1/3] pvpanic: use FWCfgState explicitly

2013-05-30 Thread Laszlo Ersek
On 05/30/13 15:27, Michael S. Tsirkin wrote: Use the type-safe FWCfgState structure instead of the unsafe void *. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/misc/pvpanic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/pvpanic.c

Re: [Qemu-devel] [PATCH 1/3] pvpanic: use FWCfgState explicitly

2013-05-30 Thread Paolo Bonzini
Il 30/05/2013 17:05, Laszlo Ersek ha scritto: But, again object_resolve_path() returns pointer-to-Object. I'm checking struct Object in include/qom/object.h, and it suggests that derived structs should embed Object as first member. However FWCfgState is *not* such a derived member. What's

Re: [Qemu-devel] [PATCH 1/3] pvpanic: use FWCfgState explicitly

2013-05-30 Thread Laszlo Ersek
On 05/30/13 17:41, Paolo Bonzini wrote: Il 30/05/2013 17:05, Laszlo Ersek ha scritto: But, again object_resolve_path() returns pointer-to-Object. I'm checking struct Object in include/qom/object.h, and it suggests that derived structs should embed Object as first member. However FWCfgState is

Re: [Qemu-devel] [PATCH 1/3] pvpanic: use FWCfgState explicitly

2013-05-30 Thread Paolo Bonzini
Il 30/05/2013 18:03, Laszlo Ersek ha scritto: On 05/30/13 17:05, Laszlo Ersek wrote: On 05/30/13 15:27, Michael S. Tsirkin wrote: Use the type-safe FWCfgState structure instead of the unsafe void *. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/misc/pvpanic.c | 2 +- 1 file

Re: [Qemu-devel] [PATCH 1/3] pvpanic: use FWCfgState explicitly

2013-05-30 Thread Laszlo Ersek
On 05/30/13 17:05, Laszlo Ersek wrote: On 05/30/13 15:27, Michael S. Tsirkin wrote: Use the type-safe FWCfgState structure instead of the unsafe void *. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/misc/pvpanic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [Qemu-devel] [PATCH 1/3] pvpanic: use FWCfgState explicitly

2013-05-30 Thread Michael S. Tsirkin
On Thu, May 30, 2013 at 05:05:51PM +0200, Laszlo Ersek wrote: On 05/30/13 15:27, Michael S. Tsirkin wrote: Use the type-safe FWCfgState structure instead of the unsafe void *. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/misc/pvpanic.c | 2 +- 1 file changed, 1