Re: [Qemu-devel] [PATCH 11/14] qbus: move get_fw_dev_path to DeviceClass

2012-05-02 Thread Paolo Bonzini
Il 02/05/2012 00:36, Andreas Färber ha scritto: > Sorry, I reviewed the patches in mail reception order. ;) > > I meant 08/14 (qdev: convert busses to QEMU object model) where macros > for other bus types were introduced. Seemed like an oversight. A lot of these were missing, and furthermore they

Re: [Qemu-devel] [PATCH 11/14] qbus: move get_fw_dev_path to DeviceClass

2012-05-01 Thread Andreas Färber
Am 02.05.2012 00:24, schrieb Anthony Liguori: > On 05/01/2012 02:34 PM, Andreas Färber wrote: >> Am 01.05.2012 20:18, schrieb Anthony Liguori: >>> +#define IDE_BUS(obj) OBJECT_CHECK(IDEBus, (obj), TYPE_IDE_BUS) >> >> Move macro to preceding patch? > > Do you mean an independent patch? Sorry, I re

Re: [Qemu-devel] [PATCH 11/14] qbus: move get_fw_dev_path to DeviceClass

2012-05-01 Thread Anthony Liguori
On 05/01/2012 02:34 PM, Andreas Färber wrote: Am 01.05.2012 20:18, schrieb Anthony Liguori: It should have never been a bus method. Signed-off-by: Anthony Liguori --- [...] diff --git a/hw/ide/qdev.c b/hw/ide/qdev.c index 4a468f8..5044018 100644 --- a/hw/ide/qdev.c +++ b/hw/ide/qdev.c @@ -25,

Re: [Qemu-devel] [PATCH 11/14] qbus: move get_fw_dev_path to DeviceClass

2012-05-01 Thread Andreas Färber
Am 01.05.2012 20:18, schrieb Anthony Liguori: > It should have never been a bus method. > > Signed-off-by: Anthony Liguori > --- [...] > diff --git a/hw/ide/qdev.c b/hw/ide/qdev.c > index 4a468f8..5044018 100644 > --- a/hw/ide/qdev.c > +++ b/hw/ide/qdev.c > @@ -25,22 +25,13 @@ > > /* -