Re: [Qemu-devel] [PATCH 2/2] clean-up: removed duplicate #includes

2016-10-20 Thread Anand J 
send a new patch. please check http://patchwork.ozlabs.org/patch/684532/

Thanks,
Anand

On Thu, Oct 20, 2016 at 2:41 PM, Thomas Huth  wrote:

> On 18.10.2016 14:39, Anand J wrote:
> >
> >
> > On Tue, Oct 18, 2016 at 4:03 PM, Anand J  > > wrote:
> >
> > Some files contain multiple #includes of the same header file.
> > Removed most of those unnecessary duplicate entries using
> > scripts/clean-includes.
> >
> > Signed-off-by: Anand J  > >
> > ---
> >  accel.c | 1 -
> >  cputlb.c| 1 -
> >  gdbstub.c   | 1 -
> >  hw/i386/acpi-build.c| 1 -
> >  hw/microblaze/boot.c| 1 -
> >  hw/mips/mips_malta.c| 1 -
> >  hw/nvram/fw_cfg.c   | 1 -
> >  hw/pci-bridge/pci_expander_bridge.c | 1 -
> >  hw/ppc/ppc405_boards.c  | 1 -
> >  hw/ppc/spapr.c  | 1 -
> >  hw/timer/grlib_gptimer.c| 1 -
> >  hw/tpm/tpm_tis.c| 1 -
> >  hw/unicore32/puv3.c | 1 -
> >  hw/usb/dev-mtp.c| 1 -
> >  include/hw/i386/pc.h| 1 -
> >  monitor.c   | 2 --
> >  qemu-io-cmds.c  | 1 -
> >  qmp.c   | 1 -
> >  target-i386/machine.c   | 3 ---
> >  target-mips/machine.c   | 1 -
> >  target-ppc/machine.c| 1 -
> >  target-ppc/mem_helper.c | 1 -
> >  target-sparc/machine.c  | 3 ---
> >  target-xtensa/translate.c   | 1 -
> >  tests/crypto-tls-x509-helpers.h | 3 ---
> >  tests/vhost-user-test.c | 2 --
> >  util/oslib-posix.c  | 1 -
> >  vl.c| 1 -
> >  28 files changed, 36 deletions(-)
>
> This patch looks also fine to me now - but again, please no HTML
> e-mails. Could you please resend as plain text mail with CC: to
> qemu-triv...@nongnu.org ?
>
>  Thanks,
>   Thomas
>
>

Re: [Qemu-devel] [PATCH 2/2] clean-up: removed duplicate #includes

2016-10-20 Thread Thomas Huth 
On 18.10.2016 14:39, Anand J wrote:
> 
> 
> On Tue, Oct 18, 2016 at 4:03 PM, Anand J  > wrote:
> 
> Some files contain multiple #includes of the same header file.
> Removed most of those unnecessary duplicate entries using
> scripts/clean-includes.
> 
> Signed-off-by: Anand J  >
> ---
>  accel.c | 1 -
>  cputlb.c| 1 -
>  gdbstub.c   | 1 -
>  hw/i386/acpi-build.c| 1 -
>  hw/microblaze/boot.c| 1 -
>  hw/mips/mips_malta.c| 1 -
>  hw/nvram/fw_cfg.c   | 1 -
>  hw/pci-bridge/pci_expander_bridge.c | 1 -
>  hw/ppc/ppc405_boards.c  | 1 -
>  hw/ppc/spapr.c  | 1 -
>  hw/timer/grlib_gptimer.c| 1 -
>  hw/tpm/tpm_tis.c| 1 -
>  hw/unicore32/puv3.c | 1 -
>  hw/usb/dev-mtp.c| 1 -
>  include/hw/i386/pc.h| 1 -
>  monitor.c   | 2 --
>  qemu-io-cmds.c  | 1 -
>  qmp.c   | 1 -
>  target-i386/machine.c   | 3 ---
>  target-mips/machine.c   | 1 -
>  target-ppc/machine.c| 1 -
>  target-ppc/mem_helper.c | 1 -
>  target-sparc/machine.c  | 3 ---
>  target-xtensa/translate.c   | 1 -
>  tests/crypto-tls-x509-helpers.h | 3 ---
>  tests/vhost-user-test.c | 2 --
>  util/oslib-posix.c  | 1 -
>  vl.c| 1 -
>  28 files changed, 36 deletions(-)

This patch looks also fine to me now - but again, please no HTML
e-mails. Could you please resend as plain text mail with CC: to
qemu-triv...@nongnu.org ?

 Thanks,
  Thomas

Re: [Qemu-devel] [PATCH 2/2] clean-up: removed duplicate #includes

2016-10-18 Thread Anand J 
On Tue, Oct 18, 2016 at 4:03 PM, Anand J  wrote:

> Some files contain multiple #includes of the same header file.
> Removed most of those unnecessary duplicate entries using
> scripts/clean-includes.
>
> Signed-off-by: Anand J 
> ---
>  accel.c | 1 -
>  cputlb.c| 1 -
>  gdbstub.c   | 1 -
>  hw/i386/acpi-build.c| 1 -
>  hw/microblaze/boot.c| 1 -
>  hw/mips/mips_malta.c| 1 -
>  hw/nvram/fw_cfg.c   | 1 -
>  hw/pci-bridge/pci_expander_bridge.c | 1 -
>  hw/ppc/ppc405_boards.c  | 1 -
>  hw/ppc/spapr.c  | 1 -
>  hw/timer/grlib_gptimer.c| 1 -
>  hw/tpm/tpm_tis.c| 1 -
>  hw/unicore32/puv3.c | 1 -
>  hw/usb/dev-mtp.c| 1 -
>  include/hw/i386/pc.h| 1 -
>  monitor.c   | 2 --
>  qemu-io-cmds.c  | 1 -
>  qmp.c   | 1 -
>  target-i386/machine.c   | 3 ---
>  target-mips/machine.c   | 1 -
>  target-ppc/machine.c| 1 -
>  target-ppc/mem_helper.c | 1 -
>  target-sparc/machine.c  | 3 ---
>  target-xtensa/translate.c   | 1 -
>  tests/crypto-tls-x509-helpers.h | 3 ---
>  tests/vhost-user-test.c | 2 --
>  util/oslib-posix.c  | 1 -
>  vl.c| 1 -
>  28 files changed, 36 deletions(-)
>
> diff --git a/accel.c b/accel.c
> index 403eb5e..664bb88 100644
> --- a/accel.c
> +++ b/accel.c
> @@ -33,7 +33,6 @@
>  #include "sysemu/qtest.h"
>  #include "hw/xen/xen.h"
>  #include "qom/object.h"
> -#include "hw/boards.h"
>
>  int tcg_tb_size;
>  static bool tcg_allowed = true;
> diff --git a/cputlb.c b/cputlb.c
> index 3c99c34..6a7208f 100644
> --- a/cputlb.c
> +++ b/cputlb.c
> @@ -28,7 +28,6 @@
>
>  #include "exec/memory-internal.h"
>  #include "exec/ram_addr.h"
> -#include "exec/exec-all.h"
>  #include "tcg/tcg.h"
>  #include "qemu/error-report.h"
>  #include "exec/log.h"
> diff --git a/gdbstub.c b/gdbstub.c
> index ecea8c4..67eb028 100644
> --- a/gdbstub.c
> +++ b/gdbstub.c
> @@ -31,7 +31,6 @@
>
>  #define MAX_PACKET_LENGTH 4096
>
> -#include "cpu.h"
>  #include "qemu/sockets.h"
>  #include "sysemu/kvm.h"
>  #include "exec/semihost.h"
> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> index e999654..2b49f58 100644
> --- a/hw/i386/acpi-build.c
> +++ b/hw/i386/acpi-build.c
> @@ -53,7 +53,6 @@
>  #include "hw/pci/pci_bus.h"
>  #include "hw/pci-host/q35.h"
>  #include "hw/i386/x86-iommu.h"
> -#include "hw/timer/hpet.h"
>
>  #include "hw/acpi/aml-build.h"
>
> diff --git a/hw/microblaze/boot.c b/hw/microblaze/boot.c
> index 9eebb1a..1834d22 100644
> --- a/hw/microblaze/boot.c
> +++ b/hw/microblaze/boot.c
> @@ -30,7 +30,6 @@
>  #include "qemu/option.h"
>  #include "qemu/config-file.h"
>  #include "qemu/error-report.h"
> -#include "qemu-common.h"
>  #include "sysemu/device_tree.h"
>  #include "sysemu/sysemu.h"
>  #include "hw/loader.h"
> diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c
> index e90857e..61aa8eb 100644
> --- a/hw/mips/mips_malta.c
> +++ b/hw/mips/mips_malta.c
> @@ -47,7 +47,6 @@
>  #include "elf.h"
>  #include "hw/timer/mc146818rtc.h"
>  #include "hw/timer/i8254.h"
> -#include "sysemu/block-backend.h"
>  #include "sysemu/blockdev.h"
>  #include "exec/address-spaces.h"
>  #include "hw/sysbus.h" /* SysBusDevice */
> diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c
> index 92aa563..1f0c3e9 100644
> --- a/hw/nvram/fw_cfg.c
> +++ b/hw/nvram/fw_cfg.c
> @@ -29,7 +29,6 @@
>  #include "hw/isa/isa.h"
>  #include "hw/nvram/fw_cfg.h"
>  #include "hw/sysbus.h"
> -#include "hw/boards.h"
>  #include "trace.h"
>  #include "qemu/error-report.h"
>  #include "qemu/config-file.h"
> diff --git a/hw/pci-bridge/pci_expander_bridge.c
> b/hw/pci-bridge/pci_expander_bridge.c
> index 1cc598f..6ac187f 100644
> --- a/hw/pci-bridge/pci_expander_bridge.c
> +++ b/hw/pci-bridge/pci_expander_bridge.c
> @@ -15,7 +15,6 @@
>  #include "hw/pci/pci.h"
>  #include "hw/pci/pci_bus.h"
>  #include "hw/pci/pci_host.h"
> -#include "hw/pci/pci_bus.h"
>  #include "hw/pci/pci_bridge.h"
>  #include "hw/i386/pc.h"
>  #include "qemu/range.h"
> diff --git a/hw/ppc/ppc405_boards.c b/hw/ppc/ppc405_boards.c
> index 4b2f07a..d01798f 100644
> --- a/hw/ppc/ppc405_boards.c
> +++ b/hw/ppc/ppc405_boards.c
> @@ -37,7 +37,6 @@
>  #include "qemu/log.h"
>  #include "qemu/error-report.h"
>  #include "hw/loader.h"
> -#include "sysemu/block-backend.h"
>  #include "sysemu/blockdev.h"
>  #include "exec/address-spaces.h"
>
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index ddb7438..2491287 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -37,7 +37,6 @@
>  #include "sysemu/block-backend.h"
>  #include "sysemu/cpus.h"
>  #include "sysemu/kvm.h"
>