Re: [Qemu-devel] [PATCH 2/2] qapi: deprecate implicit filters

2019-09-02 Thread Kevin Wolf
Am 23.08.2019 um 11:22 hat Vladimir Sementsov-Ogievskiy geschrieben: > 14.08.2019 13:07, Vladimir Sementsov-Ogievskiy wrote: > > To get rid of implicit filters related workarounds in future let's > > deprecate them now. > > Interesting, could we deprecate implicit filter without deprecation of >

Re: [Qemu-devel] [PATCH 2/2] qapi: deprecate implicit filters

2019-08-29 Thread John Snow
On 8/29/19 11:17 AM, Vladimir Sementsov-Ogievskiy wrote: > Aren't you going to deprecate and drop it at some moment? Libvirt's going to keep supporting older versions of QEMU in perpetuity. Apparently, there are still some barriers (SD cards?) to using only blockdev API for new versions, too:

Re: [Qemu-devel] [PATCH 2/2] qapi: deprecate implicit filters

2019-08-29 Thread Christophe de Dinechin
John Snow writes: [...] > > This might be OK to do right away, though. > > I asked Markus this not too long ago; do we want to amend the QAPI > schema specification to allow commands to return with "Warning" strings, > or "Deprecated" stings to allow in-band deprecation notices for cases > like

Re: [Qemu-devel] [PATCH 2/2] qapi: deprecate implicit filters

2019-08-29 Thread Vladimir Sementsov-Ogievskiy
29.08.2019 17:44, Peter Krempa wrote: > On Wed, Aug 28, 2019 at 13:48:10 -0400, John Snow wrote: >> (Peter: search for "pkrempa" down below.) >> >> On 8/28/19 5:20 AM, Vladimir Sementsov-Ogievskiy wrote: > > [] > > >> So that's a bit of a change, but only visually. The "reality" is still >>

Re: [Qemu-devel] [PATCH 2/2] qapi: deprecate implicit filters

2019-08-29 Thread Vladimir Sementsov-Ogievskiy
29.08.2019 18:00, Vladimir Sementsov-Ogievskiy wrote: > 28.08.2019 20:48, John Snow wrote: >> (Peter: search for "pkrempa" down below.) >> >> On 8/28/19 5:20 AM, Vladimir Sementsov-Ogievskiy wrote: >>> 27.08.2019 23:12, John Snow wrote: On 8/23/19 5:22 AM, Vladimir

Re: [Qemu-devel] [PATCH 2/2] qapi: deprecate implicit filters

2019-08-29 Thread Vladimir Sementsov-Ogievskiy
28.08.2019 20:48, John Snow wrote: > (Peter: search for "pkrempa" down below.) > > On 8/28/19 5:20 AM, Vladimir Sementsov-Ogievskiy wrote: >> 27.08.2019 23:12, John Snow wrote: >>> >>> >>> On 8/23/19 5:22 AM, Vladimir Sementsov-Ogievskiy wrote: 14.08.2019 13:07, Vladimir Sementsov-Ogievskiy

Re: [Qemu-devel] [PATCH 2/2] qapi: deprecate implicit filters

2019-08-29 Thread Peter Krempa
On Wed, Aug 28, 2019 at 13:48:10 -0400, John Snow wrote: > (Peter: search for "pkrempa" down below.) > > On 8/28/19 5:20 AM, Vladimir Sementsov-Ogievskiy wrote: [] > So that's a bit of a change, but only visually. The "reality" is still > the same, we just report it more "accurately."

Re: [Qemu-devel] [PATCH 2/2] qapi: deprecate implicit filters

2019-08-28 Thread John Snow
(Peter: search for "pkrempa" down below.) On 8/28/19 5:20 AM, Vladimir Sementsov-Ogievskiy wrote: > 27.08.2019 23:12, John Snow wrote: >> >> >> On 8/23/19 5:22 AM, Vladimir Sementsov-Ogievskiy wrote: >>> 14.08.2019 13:07, Vladimir Sementsov-Ogievskiy wrote: To get rid of implicit filters

Re: [Qemu-devel] [PATCH 2/2] qapi: deprecate implicit filters

2019-08-28 Thread Vladimir Sementsov-Ogievskiy
27.08.2019 23:12, John Snow wrote: > > > On 8/23/19 5:22 AM, Vladimir Sementsov-Ogievskiy wrote: >> 14.08.2019 13:07, Vladimir Sementsov-Ogievskiy wrote: >>> To get rid of implicit filters related workarounds in future let's >>> deprecate them now. >> >> Interesting, could we deprecate implicit

Re: [Qemu-devel] [PATCH 2/2] qapi: deprecate implicit filters

2019-08-27 Thread John Snow
On 8/23/19 5:22 AM, Vladimir Sementsov-Ogievskiy wrote: > 14.08.2019 13:07, Vladimir Sementsov-Ogievskiy wrote: >> To get rid of implicit filters related workarounds in future let's >> deprecate them now. > > Interesting, could we deprecate implicit filter without deprecation of > unnecessity

Re: [Qemu-devel] [PATCH 2/2] qapi: deprecate implicit filters

2019-08-23 Thread Vladimir Sementsov-Ogievskiy
14.08.2019 13:07, Vladimir Sementsov-Ogievskiy wrote: > To get rid of implicit filters related workarounds in future let's > deprecate them now. Interesting, could we deprecate implicit filter without deprecation of unnecessity of parameter? As actually, it's good when this parameter is not

Re: [Qemu-devel] [PATCH 2/2] qapi: deprecate implicit filters

2019-08-16 Thread Vladimir Sementsov-Ogievskiy
16.08.2019 15:33, Markus Armbruster wrote: > Kevin Wolf writes: > >> Am 15.08.2019 um 21:24 hat Markus Armbruster geschrieben: > [...] >>> Let's assume all libvirt ever does with deprecation notices is logging >>> them. Would that solve the problem of reliably alerting libvirt >>> developers to

Re: [Qemu-devel] [PATCH 2/2] qapi: deprecate implicit filters

2019-08-16 Thread Markus Armbruster
Kevin Wolf writes: > Am 15.08.2019 um 21:24 hat Markus Armbruster geschrieben: [...] >> Let's assume all libvirt ever does with deprecation notices is logging >> them. Would that solve the problem of reliably alerting libvirt >> developers to deprecation issues? Nope. But it could help >>

Re: [Qemu-devel] [PATCH 2/2] qapi: deprecate implicit filters

2019-08-16 Thread Kevin Wolf
Am 15.08.2019 um 21:24 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 15.08.2019 um 18:07 hat John Snow geschrieben: > >> > >> > >> On 8/15/19 6:49 AM, Kevin Wolf wrote: > >> > Am 14.08.2019 um 21:27 hat John Snow geschrieben: > >> >> > >> >> > >> >> On 8/14/19 6:07 AM,

Re: [Qemu-devel] [PATCH 2/2] qapi: deprecate implicit filters

2019-08-15 Thread Markus Armbruster
Kevin Wolf writes: > Am 15.08.2019 um 18:07 hat John Snow geschrieben: >> >> >> On 8/15/19 6:49 AM, Kevin Wolf wrote: >> > Am 14.08.2019 um 21:27 hat John Snow geschrieben: >> >> >> >> >> >> On 8/14/19 6:07 AM, Vladimir Sementsov-Ogievskiy wrote: >> >>> To get rid of implicit filters related

Re: [Qemu-devel] [PATCH 2/2] qapi: deprecate implicit filters

2019-08-15 Thread John Snow
On 8/15/19 12:48 PM, Kevin Wolf wrote: > Am 15.08.2019 um 18:07 hat John Snow geschrieben: >> On 8/15/19 6:49 AM, Kevin Wolf wrote: >>> Am 14.08.2019 um 21:27 hat John Snow geschrieben: This might be OK to do right away, though. I asked Markus this not too long ago; do we want

Re: [Qemu-devel] [PATCH 2/2] qapi: deprecate implicit filters

2019-08-15 Thread Kevin Wolf
Am 15.08.2019 um 18:07 hat John Snow geschrieben: > > > On 8/15/19 6:49 AM, Kevin Wolf wrote: > > Am 14.08.2019 um 21:27 hat John Snow geschrieben: > >> > >> > >> On 8/14/19 6:07 AM, Vladimir Sementsov-Ogievskiy wrote: > >>> To get rid of implicit filters related workarounds in future let's >

Re: [Qemu-devel] [PATCH 2/2] qapi: deprecate implicit filters

2019-08-15 Thread John Snow
On 8/15/19 6:49 AM, Kevin Wolf wrote: > Am 14.08.2019 um 21:27 hat John Snow geschrieben: >> >> >> On 8/14/19 6:07 AM, Vladimir Sementsov-Ogievskiy wrote: >>> To get rid of implicit filters related workarounds in future let's >>> deprecate them now. >>> >>> Signed-off-by: Vladimir

Re: [Qemu-devel] [PATCH 2/2] qapi: deprecate implicit filters

2019-08-15 Thread Kevin Wolf
Am 14.08.2019 um 21:27 hat John Snow geschrieben: > > > On 8/14/19 6:07 AM, Vladimir Sementsov-Ogievskiy wrote: > > To get rid of implicit filters related workarounds in future let's > > deprecate them now. > > > > Signed-off-by: Vladimir Sementsov-Ogievskiy > > --- > > qemu-deprecated.texi

Re: [Qemu-devel] [PATCH 2/2] qapi: deprecate implicit filters

2019-08-14 Thread John Snow
On 8/14/19 6:07 AM, Vladimir Sementsov-Ogievskiy wrote: > To get rid of implicit filters related workarounds in future let's > deprecate them now. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > qemu-deprecated.texi | 7 +++ > qapi/block-core.json | 6 -- >