On 09/20/2016 09:54 AM, Michal Privoznik wrote: > When qemu is being killed, its last words are: > > 2016-08-31T11:48:15.293587Z qemu-system-x86_64: terminating on signal 15 from > pid 11180 > > That's nice, but what process is 11180? What if I told you we can > do better: > > 2016-08-31T11:48:15.293587Z qemu-system-x86_64: terminating on signal 15 from > pid 11180 (/usr/sbin/libvirtd) > > And that's exactly what this patch does. > > Signed-off-by: Michal Privoznik <mpriv...@redhat.com> > --- > vl.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-)
> + error_report("terminating on signal %d from pid " FMT_pid "
> (%s)",
> + shutdown_signal, shutdown_pid,
> + shutdown_cmd ? shutdown_cmd : "");
Ending with " ()" looks weird if qemu_get_pid_name() can't find a name;
can we do something like " (<unknown process>)" if shutdown_cmd is NULL?
Otherwise looks like a nice idea;
Reviewed-by: Eric Blake <ebl...@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
