Re: [Qemu-devel] [PATCH 2/2] tcg: Add missing tcg_can_emit_vec_op check in tcg_gen_gvec_2s

2018-02-22 Thread Richard Henderson
On 02/22/2018 06:58 AM, Peter Maydell wrote: > Incidentally, I notice that the condition checks > (TCG_TARGET_HAS_v256 && check_size_impl(oprsz, 32) > && tcg_can_emit_vec_op(g->opc, TCG_TYPE_V256, g->vece)) > > (TCG_TARGET_HAS_v128 && check_size_impl(oprsz, 16) > &&

Re: [Qemu-devel] [PATCH 2/2] tcg: Add missing tcg_can_emit_vec_op check in tcg_gen_gvec_2s

2018-02-22 Thread Peter Maydell
On 17 February 2018 at 16:40, Richard Henderson wrote: > This lead to an assertion failure for 64-bit vector multiply, > which is not available in the AVX instruction set. > > Signed-off-by: Richard Henderson > --- > tcg/tcg-op-gvec.c