Re: [Qemu-devel] [PATCH 3/3] iotests: fix expected error message
Hi - Original Message - > Marc-André Lureau writes: > > > Missing argument returns a corresponding error message for all types > > now. > > > > Signed-off-by: Marc-André Lureau > > --- > > tests/qemu-iotests/087.out | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tests/qemu-iotests/087.out b/tests/qemu-iotests/087.out > > index a95c4b0..b213db2 100644 > > --- a/tests/qemu-iotests/087.out > > +++ b/tests/qemu-iotests/087.out > > @@ -60,7 +60,7 @@ Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=134217728 > > encryption=on > > Testing: -S > > QMP_VERSION > > {"return": {}} > > -{"error": {"class": "GenericError", "desc": "Invalid parameter type for > > 'driver', expected: string"}} > > +{"error": {"class": "GenericError", "desc": "Parameter 'driver' is > > missing"}} > > {"return": {}} > > {"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, > > "event": "SHUTDOWN"} > > Did this regress in PATCH 1? If you look at old monitor dispatch code, it does not return QERR_MISSING_PARAMETER for structure members, but only top level arguments. I don't think it's worth to keep that old error behaviour. I will update the commit message.
Re: [Qemu-devel] [PATCH 3/3] iotests: fix expected error message
Marc-André Lureau writes: > Missing argument returns a corresponding error message for all types > now. > > Signed-off-by: Marc-André Lureau > --- > tests/qemu-iotests/087.out | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/qemu-iotests/087.out b/tests/qemu-iotests/087.out > index a95c4b0..b213db2 100644 > --- a/tests/qemu-iotests/087.out > +++ b/tests/qemu-iotests/087.out > @@ -60,7 +60,7 @@ Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=134217728 > encryption=on > Testing: -S > QMP_VERSION > {"return": {}} > -{"error": {"class": "GenericError", "desc": "Invalid parameter type for > 'driver', expected: string"}} > +{"error": {"class": "GenericError", "desc": "Parameter 'driver' is missing"}} > {"return": {}} > {"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": > "SHUTDOWN"} Did this regress in PATCH 1?
Re: [Qemu-devel] [PATCH 3/3] iotests: fix expected error message
On Wed 21 Sep 2016 12:36:29 PM CEST, Marc-André Lureau wrote: > Missing argument returns a corresponding error message for all types > now. > > Signed-off-by: Marc-André Lureau Reviewed-by: Alberto Garcia Berto