Re: [Qemu-devel] [PATCH 3/3] ipoctal232: Convert to use chardev properties directly

2013-04-01 Thread Alberto Garcia
On Wed, Mar 27, 2013 at 08:29:41PM +0100, Hans de Goede wrote: Signed-off-by: Hans de Goede hdego...@redhat.com Cc: Alberto Garcia agar...@igalia.com Sorry for the delay, just came back from holidays :) I've just tested it and the change looks fine to me. Signed-off-by: Alberto Garcia

Re: [Qemu-devel] [PATCH 3/3] ipoctal232: Convert to use chardev properties directly

2013-03-28 Thread Paolo Bonzini
Signed-off-by: Hans de Goede hdego...@redhat.com Cc: Alberto Garcia agar...@igalia.com I don't think this is a show stopper, but this is a compatibility breaker, no? We should be more up front about that and include release notes as appropriate. Yes on all counts. I can work on the

Re: [Qemu-devel] [PATCH 3/3] ipoctal232: Convert to use chardev properties directly

2013-03-28 Thread Paolo Bonzini
Given that you requested this change, it indeed probably is best if you did this :) Feel free to squash this into the patch if that is preferred (and to make yourself the author of the patch in that case). So how are we going to go about upstreaming these? Anthony will you pick 1 + 2 up

Re: [Qemu-devel] [PATCH 3/3] ipoctal232: Convert to use chardev properties directly

2013-03-28 Thread Hans de Goede
Hi, On 03/28/2013 07:18 AM, Paolo Bonzini wrote: Signed-off-by: Hans de Goede hdego...@redhat.com Cc: Alberto Garcia agar...@igalia.com I don't think this is a show stopper, but this is a compatibility breaker, no? We should be more up front about that and include release notes as

Re: [Qemu-devel] [PATCH 3/3] ipoctal232: Convert to use chardev properties directly

2013-03-27 Thread Anthony Liguori
Hans de Goede hdego...@redhat.com writes: Signed-off-by: Hans de Goede hdego...@redhat.com Cc: Alberto Garcia agar...@igalia.com I don't think this is a show stopper, but this is a compatibility breaker, no? We should be more up front about that and include release notes as appropriate.