Re: [Qemu-devel] [PATCH 3/3] target/ppc: filter out non-zero PCR values when using TCG

2018-06-14 Thread David Gibson
On Thu, Jun 14, 2018 at 05:38:16PM -1000, Richard Henderson wrote: > On 06/14/2018 03:45 PM, David Gibson wrote: > >>> To wit, the instructions are recognized and transactions always fail. > >>> Which is > >>> not a bad way to test the required fallback paths that rarely fail on > >>> hardware.

Re: [Qemu-devel] [PATCH 3/3] target/ppc: filter out non-zero PCR values when using TCG

2018-06-14 Thread Richard Henderson
On 06/14/2018 03:45 PM, David Gibson wrote: >>> To wit, the instructions are recognized and transactions always fail. >>> Which is >>> not a bad way to test the required fallback paths that rarely fail on >>> hardware. >>> ;-) >> >> If TM instructions don't cause an exception, I guess its reaso

Re: [Qemu-devel] [PATCH 3/3] target/ppc: filter out non-zero PCR values when using TCG

2018-06-14 Thread David Gibson
On Fri, Jun 15, 2018 at 12:00:20AM +0200, Greg Kurz wrote: > On Thu, 14 Jun 2018 09:52:55 -1000 > Richard Henderson wrote: > > > On 06/12/2018 10:19 PM, Greg Kurz wrote: > > > I'm confused... I don't see anything related to HTM in TCG. Also we have > > > the following in cap_htm_apply(): > > > >

Re: [Qemu-devel] [PATCH 3/3] target/ppc: filter out non-zero PCR values when using TCG

2018-06-14 Thread Greg Kurz
On Thu, 14 Jun 2018 09:52:55 -1000 Richard Henderson wrote: > On 06/12/2018 10:19 PM, Greg Kurz wrote: > > I'm confused... I don't see anything related to HTM in TCG. Also we have > > the following in cap_htm_apply(): > > > > if (tcg_enabled()) { > > error_setg(errp, > >

Re: [Qemu-devel] [PATCH 3/3] target/ppc: filter out non-zero PCR values when using TCG

2018-06-14 Thread Richard Henderson
On 06/12/2018 10:19 PM, Greg Kurz wrote: > I'm confused... I don't see anything related to HTM in TCG. Also we have > the following in cap_htm_apply(): > > if (tcg_enabled()) { > error_setg(errp, >"No Transactional Memory support in TCG, try cap-htm=off"); > > I'm

Re: [Qemu-devel] [PATCH 3/3] target/ppc: filter out non-zero PCR values when using TCG

2018-06-13 Thread David Gibson
On Wed, Jun 13, 2018 at 04:26:39PM +0200, Greg Kurz wrote: > On Wed, 13 Jun 2018 22:05:02 +1000 > David Gibson wrote: > > > On Wed, Jun 13, 2018 at 10:19:15AM +0200, Greg Kurz wrote: > > > On Wed, 13 Jun 2018 10:45:06 +1000 > > > David Gibson wrote: > > > > > > > On Tue, Jun 12, 2018 at 07:04

Re: [Qemu-devel] [PATCH 3/3] target/ppc: filter out non-zero PCR values when using TCG

2018-06-13 Thread Greg Kurz
On Wed, 13 Jun 2018 22:05:02 +1000 David Gibson wrote: > On Wed, Jun 13, 2018 at 10:19:15AM +0200, Greg Kurz wrote: > > On Wed, 13 Jun 2018 10:45:06 +1000 > > David Gibson wrote: > > > > > On Tue, Jun 12, 2018 at 07:04:15PM +0200, Greg Kurz wrote: > > > > Bits set in the PCR disable feature

Re: [Qemu-devel] [PATCH 3/3] target/ppc: filter out non-zero PCR values when using TCG

2018-06-13 Thread David Gibson
On Wed, Jun 13, 2018 at 10:19:15AM +0200, Greg Kurz wrote: > On Wed, 13 Jun 2018 10:45:06 +1000 > David Gibson wrote: > > > On Tue, Jun 12, 2018 at 07:04:15PM +0200, Greg Kurz wrote: > > > Bits set in the PCR disable features of the processor. TCG currently > > > doesn't implement that, ie, we al

Re: [Qemu-devel] [PATCH 3/3] target/ppc: filter out non-zero PCR values when using TCG

2018-06-13 Thread Greg Kurz
On Wed, 13 Jun 2018 10:45:06 +1000 David Gibson wrote: > On Tue, Jun 12, 2018 at 07:04:15PM +0200, Greg Kurz wrote: > > Bits set in the PCR disable features of the processor. TCG currently > > doesn't implement that, ie, we always act like if PCR is all zeros. > > > > But it is still possible fo

Re: [Qemu-devel] [PATCH 3/3] target/ppc: filter out non-zero PCR values when using TCG

2018-06-12 Thread David Gibson
On Tue, Jun 12, 2018 at 07:04:15PM +0200, Greg Kurz wrote: > Bits set in the PCR disable features of the processor. TCG currently > doesn't implement that, ie, we always act like if PCR is all zeros. > > But it is still possible for the PCR to have a non-null value. This may > confuse the guest. >