On 3/17/19 1:22 AM, Philippe Mathieu-Daudé wrote: > Now that we use Kconfig, we can simplify this Makefile. > > Suggested-by: Paolo Bonzini <pbonz...@redhat.com> > Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com> > --- > hw/acpi/Makefile.objs | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/hw/acpi/Makefile.objs b/hw/acpi/Makefile.objs > index 2d46e3789a..c86edfbed9 100644 > --- a/hw/acpi/Makefile.objs > +++ b/hw/acpi/Makefile.objs > @@ -1,4 +1,3 @@ > -ifeq ($(CONFIG_ACPI),y) > common-obj-$(CONFIG_ACPI_X86) += core.o piix4.o pcihp.o > common-obj-$(CONFIG_ACPI_X86_ICH) += ich9.o tco.o > common-obj-$(CONFIG_ACPI_CPU_HOTPLUG) += cpu_hotplug.o > @@ -6,16 +5,11 @@ common-obj-$(CONFIG_ACPI_MEMORY_HOTPLUG) += memory_hotplug.o > common-obj-$(CONFIG_ACPI_CPU_HOTPLUG) += cpu.o > common-obj-$(CONFIG_ACPI_NVDIMM) += nvdimm.o > common-obj-$(CONFIG_ACPI_VMGENID) += vmgenid.o > -common-obj-$(call lnot,$(CONFIG_ACPI_X86)) += acpi-stub.o > - > common-obj-y += acpi_interface.o > common-obj-y += bios-linker-loader.o > common-obj-y += aml-build.o > common-obj-$(CONFIG_TPM) += tpm.o > - > common-obj-$(CONFIG_IPMI) += ipmi.o > + > common-obj-$(call lnot,$(CONFIG_IPMI)) += ipmi-stub.o > -else > -common-obj-y += acpi-stub.o > -endif > -common-obj-$(CONFIG_ALL) += acpi-stub.o ipmi-stub.o > +common-obj-$(call lnot,$(CONFIG_ACPI)) += acpi-stub.o
MinGW unhappy here :( make[1]: *** No rule to make target '../hw/acpi/ipmi-stub.o', needed by 'qemu-system-aarch64w.exe'. Stop. make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:449: subdir-aarch64-softmmu] Error 2 make: *** Waiting for unfinished jobs.... GEN x86_64-softmmu/qemu-system-x86_64.exe https://patchew.org/logs/20190317002259.25994-1-phi...@redhat.com/testing.docker-mingw@fedora/?type=message
