Re: [Qemu-devel] [PATCH 4/8] virtio: add detach element for packed ring(1.1)

2018-06-04 Thread Wei Xu
On Mon, Jun 04, 2018 at 04:54:45AM +0300, Michael S. Tsirkin wrote: > On Mon, Jun 04, 2018 at 09:34:35AM +0800, Wei Xu wrote: > > On Tue, Apr 10, 2018 at 03:32:53PM +0800, Jason Wang wrote: > > > > > > > > > On 2018年04月04日 20:54, w...@redhat.com wrote: > > > >From: Wei Xu > > > > > > > >helper

Re: [Qemu-devel] [PATCH 4/8] virtio: add detach element for packed ring(1.1)

2018-06-03 Thread Michael S. Tsirkin
On Mon, Jun 04, 2018 at 09:34:35AM +0800, Wei Xu wrote: > On Tue, Apr 10, 2018 at 03:32:53PM +0800, Jason Wang wrote: > > > > > > On 2018年04月04日 20:54, w...@redhat.com wrote: > > >From: Wei Xu > > > > > >helper for packed ring > > > > It's odd and hard to review if you put detach patch first.

Re: [Qemu-devel] [PATCH 4/8] virtio: add detach element for packed ring(1.1)

2018-06-03 Thread Wei Xu
On Tue, Apr 10, 2018 at 03:32:53PM +0800, Jason Wang wrote: > > > On 2018年04月04日 20:54, w...@redhat.com wrote: > >From: Wei Xu > > > >helper for packed ring > > It's odd and hard to review if you put detach patch first. I think this > patch needs to be reordered after the implementation of

Re: [Qemu-devel] [PATCH 4/8] virtio: add detach element for packed ring(1.1)

2018-04-10 Thread Jason Wang
On 2018年04月04日 20:54, w...@redhat.com wrote: From: Wei Xu helper for packed ring It's odd and hard to review if you put detach patch first. I think this patch needs to be reordered after the implementation of pop/map. Thanks Signed-off-by: Wei Xu ---