Re: [Qemu-devel] [PATCH RFC 09/21] qapi: Don't absolutize include file name in error messages

2018-02-06 Thread Eric Blake
On 02/06/2018 01:49 AM, Markus Armbruster wrote: Probably not, as our make rule strips off $(SRC_PATH): @perl -p -e 's|\Q$(SRC_PATH)\E/||g' $*.test.err | diff -q $(SRC_PATH)/$*.err - I've kept that, because it might also occur in stack backtraces. I think. Ideally, we don't have

Re: [Qemu-devel] [PATCH RFC 09/21] qapi: Don't absolutize include file name in error messages

2018-02-05 Thread Markus Armbruster
Eric Blake writes: > On 02/03/2018 03:08 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> On 02/02/2018 07:03 AM, Markus Armbruster wrote: Error messages print absolute filenames of included files even gave a >>> >>> s/even gave/even when

Re: [Qemu-devel] [PATCH RFC 09/21] qapi: Don't absolutize include file name in error messages

2018-02-05 Thread Eric Blake
On 02/03/2018 03:08 AM, Markus Armbruster wrote: > Eric Blake writes: > >> On 02/02/2018 07:03 AM, Markus Armbruster wrote: >>> Error messages print absolute filenames of included files even gave a >> >> s/even gave/even when given/ > > I meant to write "even if the user

Re: [Qemu-devel] [PATCH RFC 09/21] qapi: Don't absolutize include file name in error messages

2018-02-05 Thread Marc-Andre Lureau
On Fri, Feb 2, 2018 at 2:03 PM, Markus Armbruster wrote: > Error messages print absolute filenames of included files even gave a > relative one on the command line: > > PYTHONPATH=scripts python -B tests/qapi-schema/test-qapi.py > tests/qapi-schema/include-cycle.json >

Re: [Qemu-devel] [PATCH RFC 09/21] qapi: Don't absolutize include file name in error messages

2018-02-03 Thread Markus Armbruster
Eric Blake writes: > On 02/02/2018 07:03 AM, Markus Armbruster wrote: >> Error messages print absolute filenames of included files even gave a > > s/even gave/even when given/ I meant to write "even if the user gave". Is that okay? >> relative one on the command line: >>

Re: [Qemu-devel] [PATCH RFC 09/21] qapi: Don't absolutize include file name in error messages

2018-02-02 Thread Eric Blake
On 02/02/2018 07:03 AM, Markus Armbruster wrote: > Error messages print absolute filenames of included files even gave a s/even gave/even when given/ > relative one on the command line: > > PYTHONPATH=scripts python -B tests/qapi-schema/test-qapi.py > tests/qapi-schema/include-cycle.json