Re: [Qemu-devel] [PATCH RFC 2/2] vfio-ccw: support for halt/clear subchannel

2018-06-12 Thread Cornelia Huck
On Tue, 12 Jun 2018 16:08:42 +0200 Halil Pasic wrote: > On 06/12/2018 03:56 PM, Pierre Morel wrote: > >> So, what are you proposing? Being more specific and stating that the > >> scsw is not necessarily a real scsw, but merely a vehicle for sending a > >> command? Or keeping it as it is now for s

Re: [Qemu-devel] [PATCH RFC 2/2] vfio-ccw: support for halt/clear subchannel

2018-06-12 Thread Halil Pasic
On 06/12/2018 03:56 PM, Pierre Morel wrote: So, what are you proposing? Being more specific and stating that the scsw is not necessarily a real scsw, but merely a vehicle for sending a command? Or keeping it as it is now for ssch, and adding a second interface for hsch/csch (and maybe rsch, msc

Re: [Qemu-devel] [PATCH RFC 2/2] vfio-ccw: support for halt/clear subchannel

2018-06-12 Thread Pierre Morel
On 12/06/2018 11:59, Cornelia Huck wrote: On Fri, 8 Jun 2018 17:51:27 +0200 Pierre Morel wrote: On 08/06/2018 16:45, Cornelia Huck wrote: On Fri, 8 Jun 2018 15:13:28 +0200 Halil Pasic wrote: On 06/08/2018 02:20 PM, Cornelia Huck wrote: My proposal is to do the same copying to scsw(r) ag

Re: [Qemu-devel] [PATCH RFC 2/2] vfio-ccw: support for halt/clear subchannel

2018-06-12 Thread Cornelia Huck
On Fri, 8 Jun 2018 17:51:27 +0200 Pierre Morel wrote: > On 08/06/2018 16:45, Cornelia Huck wrote: > > On Fri, 8 Jun 2018 15:13:28 +0200 > > Halil Pasic wrote: > > > >> On 06/08/2018 02:20 PM, Cornelia Huck wrote: > > My proposal is to do the same > > copying to scsw(r) again, which w

Re: [Qemu-devel] [PATCH RFC 2/2] vfio-ccw: support for halt/clear subchannel

2018-06-08 Thread Halil Pasic
On 06/08/2018 04:45 PM, Cornelia Huck wrote: On Fri, 8 Jun 2018 15:13:28 +0200 Halil Pasic wrote: On 06/08/2018 02:20 PM, Cornelia Huck wrote: My proposal is to do the same copying to scsw(r) again, which would mean we get a request with both the halt and the start bit set. The vfio code n

Re: [Qemu-devel] [PATCH RFC 2/2] vfio-ccw: support for halt/clear subchannel

2018-06-08 Thread Pierre Morel
On 08/06/2018 16:45, Cornelia Huck wrote: On Fri, 8 Jun 2018 15:13:28 +0200 Halil Pasic wrote: On 06/08/2018 02:20 PM, Cornelia Huck wrote: My proposal is to do the same copying to scsw(r) again, which would mean we get a request with both the halt and the start bit set. The vfio code now nee

Re: [Qemu-devel] [PATCH RFC 2/2] vfio-ccw: support for halt/clear subchannel

2018-06-08 Thread Cornelia Huck
On Fri, 8 Jun 2018 15:13:28 +0200 Halil Pasic wrote: > On 06/08/2018 02:20 PM, Cornelia Huck wrote: > >>> My proposal is to do the same > >>> copying to scsw(r) again, which would mean we get a request with both > >>> the halt and the start bit set. The vfio code now needs to do a hsch > >>> (ins

Re: [Qemu-devel] [PATCH RFC 2/2] vfio-ccw: support for halt/clear subchannel

2018-06-08 Thread Halil Pasic
On 06/08/2018 02:20 PM, Cornelia Huck wrote: My proposal is to do the same copying to scsw(r) again, which would mean we get a request with both the halt and the start bit set. The vfio code now needs to do a hsch (instead of a ssch). The real channel subsystem should figure this out, as we ca

Re: [Qemu-devel] [PATCH RFC 2/2] vfio-ccw: support for halt/clear subchannel

2018-06-08 Thread Cornelia Huck
On Thu, 7 Jun 2018 18:37:16 +0200 Pierre Morel wrote: > On 07/06/2018 11:54, Cornelia Huck wrote: > > -- > > | scsw(g) | ssch > > -- | > > | guest > > ---

Re: [Qemu-devel] [PATCH RFC 2/2] vfio-ccw: support for halt/clear subchannel

2018-06-07 Thread Pierre Morel
On 07/06/2018 11:54, Cornelia Huck wrote: On Wed, 6 Jun 2018 16:15:31 +0200 Pierre Morel wrote: On 06/06/2018 14:21, Cornelia Huck wrote: On Tue, 5 Jun 2018 17:23:02 +0200 Pierre Morel wrote: On 05/06/2018 15:14, Cornelia Huck wrote: On Tue, 22 May 2018 17:10:44 +0200 Pierre Morel wrot

Re: [Qemu-devel] [PATCH RFC 2/2] vfio-ccw: support for halt/clear subchannel

2018-06-07 Thread Cornelia Huck
On Wed, 6 Jun 2018 16:15:31 +0200 Pierre Morel wrote: > On 06/06/2018 14:21, Cornelia Huck wrote: > > On Tue, 5 Jun 2018 17:23:02 +0200 > > Pierre Morel wrote: > > > >> On 05/06/2018 15:14, Cornelia Huck wrote: > >>> On Tue, 22 May 2018 17:10:44 +0200 > >>> Pierre Morel wrote: > >>> >

Re: [Qemu-devel] [PATCH RFC 2/2] vfio-ccw: support for halt/clear subchannel

2018-06-06 Thread Pierre Morel
On 06/06/2018 14:21, Cornelia Huck wrote: On Tue, 5 Jun 2018 17:23:02 +0200 Pierre Morel wrote: On 05/06/2018 15:14, Cornelia Huck wrote: On Tue, 22 May 2018 17:10:44 +0200 Pierre Morel wrote: On 22/05/2018 14:52, Cornelia Huck wrote: On Wed, 16 May 2018 15:32:48 +0200 Pierre Morel wro

Re: [Qemu-devel] [PATCH RFC 2/2] vfio-ccw: support for halt/clear subchannel

2018-06-06 Thread Cornelia Huck
On Tue, 5 Jun 2018 17:23:02 +0200 Pierre Morel wrote: > On 05/06/2018 15:14, Cornelia Huck wrote: > > On Tue, 22 May 2018 17:10:44 +0200 > > Pierre Morel wrote: > > > >> On 22/05/2018 14:52, Cornelia Huck wrote: > >>> On Wed, 16 May 2018 15:32:48 +0200 > >>> Pierre Morel wrote: > >>> >

Re: [Qemu-devel] [PATCH RFC 2/2] vfio-ccw: support for halt/clear subchannel

2018-06-05 Thread Cornelia Huck
On Tue, 5 Jun 2018 17:23:02 +0200 Pierre Morel wrote: > May be I should try to integrate your patches so we have a better view. Not sure whether it is worth trying to do so in the current state. (Also, I really need to get the information into my personal cache again, before I write too many w

Re: [Qemu-devel] [PATCH RFC 2/2] vfio-ccw: support for halt/clear subchannel

2018-06-05 Thread Pierre Morel
On 05/06/2018 15:14, Cornelia Huck wrote: On Tue, 22 May 2018 17:10:44 +0200 Pierre Morel wrote: On 22/05/2018 14:52, Cornelia Huck wrote: On Wed, 16 May 2018 15:32:48 +0200 Pierre Morel wrote: On 15/05/2018 18:10, Cornelia Huck wrote: On Fri, 11 May 2018 11:33:35 +0200 Pierre Morel wr

Re: [Qemu-devel] [PATCH RFC 2/2] vfio-ccw: support for halt/clear subchannel

2018-06-05 Thread Cornelia Huck
On Tue, 22 May 2018 17:10:44 +0200 Pierre Morel wrote: > On 22/05/2018 14:52, Cornelia Huck wrote: > > On Wed, 16 May 2018 15:32:48 +0200 > > Pierre Morel wrote: > > > >> On 15/05/2018 18:10, Cornelia Huck wrote: > >>> On Fri, 11 May 2018 11:33:35 +0200 > >>> Pierre Morel wrote: > >>>

Re: [Qemu-devel] [PATCH RFC 2/2] vfio-ccw: support for halt/clear subchannel

2018-05-22 Thread Pierre Morel
On 22/05/2018 14:52, Cornelia Huck wrote: On Wed, 16 May 2018 15:32:48 +0200 Pierre Morel wrote: On 15/05/2018 18:10, Cornelia Huck wrote: On Fri, 11 May 2018 11:33:35 +0200 Pierre Morel wrote: On 09/05/2018 17:48, Cornelia Huck wrote: @@ -126,7 +192,24 @@ static void fsm_io_request(str

Re: [Qemu-devel] [PATCH RFC 2/2] vfio-ccw: support for halt/clear subchannel

2018-05-22 Thread Cornelia Huck
On Wed, 16 May 2018 15:32:48 +0200 Pierre Morel wrote: > On 15/05/2018 18:10, Cornelia Huck wrote: > > On Fri, 11 May 2018 11:33:35 +0200 > > Pierre Morel wrote: > > > >> On 09/05/2018 17:48, Cornelia Huck wrote: > >>> @@ -126,7 +192,24 @@ static void fsm_io_request(struct vfio_ccw_private

Re: [Qemu-devel] [PATCH RFC 2/2] vfio-ccw: support for halt/clear subchannel

2018-05-16 Thread Pierre Morel
On 15/05/2018 18:10, Cornelia Huck wrote: On Fri, 11 May 2018 11:33:35 +0200 Pierre Morel wrote: On 09/05/2018 17:48, Cornelia Huck wrote: Currently, vfio-ccw only relays start subchannel requests to the real hardware, which is enough in many cases but falls short e.g. during error recovery.

Re: [Qemu-devel] [PATCH RFC 2/2] vfio-ccw: support for halt/clear subchannel

2018-05-15 Thread Cornelia Huck
On Fri, 11 May 2018 11:33:35 +0200 Pierre Morel wrote: > On 09/05/2018 17:48, Cornelia Huck wrote: > > Currently, vfio-ccw only relays start subchannel requests to the real > > hardware, which is enough in many cases but falls short e.g. during > > error recovery. > > > > Fortunately, it is easy

Re: [Qemu-devel] [PATCH RFC 2/2] vfio-ccw: support for halt/clear subchannel

2018-05-11 Thread Pierre Morel
On 09/05/2018 17:48, Cornelia Huck wrote: Currently, vfio-ccw only relays start subchannel requests to the real hardware, which is enough in many cases but falls short e.g. during error recovery. Fortunately, it is easy to add support for halt and clear subchannel requests to the existing infras